all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Nathaniel Flath <flat0103@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 5376@debbugs.gnu.org
Subject: bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH]
Date: Thu, 14 Jan 2010 10:37:58 -0500	[thread overview]
Message-ID: <5e3a506e1001140737q172bd0eep5ab8b98519a3e10a@mail.gmail.com> (raw)
In-Reply-To: <jwvk4vk3ez9.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

That may be better, yes - the only isue with that is when large chunks of
input are messaged due to a improper match, which could still be annoying.
However, that is probably fine, and would let the user know if they were
just starting with dirtrack.el that their regex was incorrect.

On Thu, Jan 14, 2010 at 10:04 AM, Stefan Monnier
<monnier@iro.umontreal.ca>wrote:

> > RCS file: /sources/emacs/emacs/lisp/dirtrack.el,v
> > retrieving revision 1.28
> > diff -u -r1.28 dirtrack.el
> > @@ -270,7 +270,7 @@
> >                         (run-hooks 'dirtrack-directory-change-hook)
> >                         (dirtrack-debug-message
> >                          (format "Changing directory to %s"
> prompt-path)))
> > -                (error "Directory %s does not exist" prompt-path)))
> > +                input))
> >              )))))
> >    input)
>
> I agree it shouldn't signal an error.  But we turn the `error' into
> a `message', so the user is kept informed of the problem.
>
>
>        Stefan
>

[-- Attachment #2: Type: text/html, Size: 1422 bytes --]

  reply	other threads:[~2010-01-14 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14  2:16 bug#5376: 23.1; dirtrack.el unnecessary errors [PATCH] flat0103
2010-01-14 15:04 ` Stefan Monnier
2010-01-14 15:37   ` Nathaniel Flath [this message]
2010-01-29 19:09 ` Chong Yidong
2010-01-29 19:17   ` Nathaniel Flath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e3a506e1001140737q172bd0eep5ab8b98519a3e10a@mail.gmail.com \
    --to=flat0103@gmail.com \
    --cc=5376@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.