From: Nathaniel Flath <flat0103@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Miles Bader <miles@gnu.org>
Subject: Re: Overalays and point-entered
Date: Fri, 8 Jan 2010 02:19:26 -0500 [thread overview]
Message-ID: <5e3a506e1001072319l25ee20c1yb7775fe1ebe86517@mail.gmail.com> (raw)
In-Reply-To: <5e3a506e1001011934n445eaf82ya478f51709ae11f5@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2708 bytes --]
I'm going to go ahead and file this as a bug in the next few days, if
everyone is too busy with the bzr switchover to discuss - that way the
manual reminders won't be needed and this can be brought up at a later
date.
On Fri, Jan 1, 2010 at 10:34 PM, Nathaniel Flath <flat0103@gmail.com> wrote:
> What is happening with this?
>
> Thanks,
> Nathaniel Flath
>
>
> On Sun, Dec 20, 2009 at 6:39 PM, Nathaniel Flath <flat0103@gmail.com>wrote:
>
>>
>>
>> On Thu, Dec 10, 2009 at 3:32 AM, Stefan Monnier <monnier@iro.umontreal.ca
>> > wrote:
>>
>>> > The patch is attached - please let me know if you have any comments.
>>>
>>> I'm wondering whether it should be described as complete or complex.
>>> Especially for a feature which hsan't yet found a user.
>>>
>>>
>> Yes, I didn't think it would be nearly as complex when I started. The
>> latest revision removes the argument for whether it was called due to a
>> buffer change; this doesn't seem as necessary when the overlay is only run
>> once instead of multiple times.
>>
>>
>> > run_point_motion_hooks (prev_c_buffer)
>>
>>>
>>> This seems to run the hooks for all overlays at the starting position
>>> and all overlays at the ending position. If you add to that the fact
>>> that it runs them for windows and for the buffer, you get that under the
>>> usual circumstance of a command within the same buffer displayed in
>>> a single window, moving within the same overlay we run the hook 4 times?
>>>
>>> I think we need to be more careful and only run the hook when crossing
>>> the boundary, i.e. when moving out of or into an overlay with that
>>> property. But even if we decide to run it for all movements, we should
>>> be careful to run it a bit less liberally. It's probably OK to
>>> occasionally have a few spurious extra runs of the hook, but your
>>> current code needs to be a lot more careful.
>>>
>>
>> The code has been fixed so that the same overlay or text property should
>> only run once, and only if a boundary has been crossed. I'm not really sure
>> whether it should run on all motion; either way would be fairly easy to
>> implement.
>>
>> One more thing: I think the buffer and window object should only store
>>> the few overlays that do have a point-motion property. Maybe they could
>>> even limit themselves to storing "the" overlay with a point-motion
>>> property (if there are several, it should take the one with highest
>>> priority).
>>>
>>>
>>>
>> It seemed to be more consistent with the priority mechanism to only store
>> and run one, so that's what it currently does. The patch with these fixes
>> is attached; please let me know if there are any other comments.
>>
>> Thanks,
>> Nathaniel Flath
>>
>
>
[-- Attachment #2: Type: text/html, Size: 4059 bytes --]
next prev parent reply other threads:[~2010-01-08 7:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 0:09 Overalays and point-entered Nathaniel Flath
2009-09-11 1:57 ` Stefan Monnier
[not found] ` <5e3a506e0909101902h72747299u2e306830ce63b11d@mail.gmail.com>
[not found] ` <jwvmy52p4re.fsf-monnier+emacs@gnu.org>
2009-09-11 4:08 ` Nathaniel Flath
2009-09-13 16:47 ` Nathaniel Flath
2009-09-14 1:16 ` Stefan Monnier
[not found] ` <5e3a506e0909140810r38a83a84l387fb6bafeb962c1@mail.gmail.com>
[not found] ` <jwvzl8x49un.fsf-monnier+emacs@gnu.org>
2009-09-16 20:46 ` Nathaniel Flath
2009-09-17 1:05 ` Stefan Monnier
2009-09-23 15:41 ` Nathaniel Flath
2009-09-23 20:55 ` Stefan Monnier
2009-09-24 1:07 ` Stephen J. Turnbull
2009-09-24 14:31 ` Overlays " Stefan Monnier
2009-09-24 13:47 ` Overalays " Nathaniel Flath
2009-09-24 14:04 ` Nathaniel Flath
2009-09-24 14:26 ` Stefan Monnier
2009-10-06 18:33 ` Nathaniel Flath
2009-10-17 17:00 ` Nathaniel Flath
2009-10-18 1:09 ` Stefan Monnier
2009-10-22 3:35 ` Nathaniel Flath
2009-10-22 15:37 ` Stefan Monnier
2009-10-23 15:43 ` Nathaniel Flath
2009-10-25 2:30 ` Stefan Monnier
2009-10-27 8:42 ` Nathaniel Flath
2009-10-27 13:28 ` Stefan Monnier
2009-10-28 0:44 ` Miles Bader
2009-10-31 17:03 ` Nathaniel Flath
2009-11-06 14:54 ` Nathaniel Flath
2009-12-09 23:41 ` Nathaniel Flath
2009-12-10 3:37 ` Nathaniel Flath
2009-12-10 8:32 ` Stefan Monnier
2009-12-20 23:39 ` Nathaniel Flath
2010-01-02 3:34 ` Nathaniel Flath
2010-01-08 7:19 ` Nathaniel Flath [this message]
2010-01-15 2:38 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e3a506e1001072319l25ee20c1yb7775fe1ebe86517@mail.gmail.com \
--to=flat0103@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.