From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#16943: 24.3.50; [PATCH] `icomplete-exhibit' needs `with-current-buffer' for minibuffer Date: Wed, 5 Mar 2014 10:50:07 -0800 (PST) Message-ID: <5d97809c-5fbf-4b3e-b864-8badfbd532da@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1394045523 22418 80.91.229.3 (5 Mar 2014 18:52:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Mar 2014 18:52:03 +0000 (UTC) To: 16943@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 05 19:52:10 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WLGvJ-0000Ew-4g for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 19:52:09 +0100 Original-Received: from localhost ([::1]:54041 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGvI-0001Tv-QE for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Mar 2014 13:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33470) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGuO-0000MP-Sk for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:51:22 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLGuE-0005CX-QD for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:51:12 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGuE-0005CQ-My for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WLGuE-0007Ay-Es for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Mar 2014 18:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.139404544427534 (code B ref -1); Wed, 05 Mar 2014 18:51:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 5 Mar 2014 18:50:44 +0000 Original-Received: from localhost ([127.0.0.1]:51933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLGtv-0007A1-S0 for submit@debbugs.gnu.org; Wed, 05 Mar 2014 13:50:44 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:59864) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLGtt-00079s-7p for submit@debbugs.gnu.org; Wed, 05 Mar 2014 13:50:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLGti-00053w-0p for submit@debbugs.gnu.org; Wed, 05 Mar 2014 13:50:40 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:35594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGth-00053o-MH for submit@debbugs.gnu.org; Wed, 05 Mar 2014 13:50:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGtZ-0007dH-0v for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:50:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLGtQ-0004oE-AC for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:50:20 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:34303) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLGtQ-0004kp-3N for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 13:50:12 -0500 Original-Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s25Io9Is016369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 5 Mar 2014 18:50:09 GMT Original-Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s25Io8Fa025594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Wed, 5 Mar 2014 18:50:09 GMT Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s25Io8DP025574 for ; Wed, 5 Mar 2014 18:50:08 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86582 Archived-At: I have noticed, with both my version (icomplete+.el) and vanilla icomplete.el, that in some cases no match of the user input is found because the field string gets picked up from buffer *Completions*, not from the minibuffer. This might be because in my case I use a separate frame for the minibuffer and for *Completions* (the latter has its input redirected to the former). The fix that seems most appropriate, I think, is this: wrap the body of the `icomplete-exhibit' code with this: (with-current-buffer (window-buffer (active-minibuffer-window)) E.g.: (defun icomplete-exhibit () "Insert Icomplete completions display. Should be run via minibuffer `post-command-hook'. See `icomplete-mode' and `minibuffer-setup-hook'." (when (and icomplete-mode (icomplete-simple-completing-p)) ;Shouldn't be necessary. (with-current-buffer (window-buffer (active-minibuffer-window)) (save-excursion (goto-char (point-max)) ... In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2014-03-04 on ODIEONE Bzr revision: 116662 kbrown@cornell.edu-20140304190249-6s13s5bwn3un3hfe Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' 'CPPFLAGS=3D-DGC_MCHECK=3D1 -Ic:/Devel/emacs/include' LDFLAGS=3D-Lc:/Devel/emacs/lib'