From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Messages from autogen Date: Thu, 7 Sep 2017 00:17:12 -0700 Organization: UCLA Computer Science Department Message-ID: <5d9199ce-1bee-10e6-5080-33c902d36542@cs.ucla.edu> References: <2138279215.903300.1504608249695@mail.libero.it> <838tht2o0o.fsf@gnu.org> <583864340.842004.1504625187429@mail.libero.it> <83zia915g9.fsf@gnu.org> <83k21b248b.fsf@gnu.org> <2082246123.1003353.1504734023438@mail.libero.it> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------EA277FE35B85E283D0FA11DE" X-Trace: blaine.gmane.org 1504768730 28186 195.159.176.226 (7 Sep 2017 07:18:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 7 Sep 2017 07:18:50 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 Cc: emacs-devel@gnu.org To: Angelo Graziosi , John Wiegley , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 07 09:18:41 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpr4q-0005dn-2r for ged-emacs-devel@m.gmane.org; Thu, 07 Sep 2017 09:18:16 +0200 Original-Received: from localhost ([::1]:39081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpr4u-0001PH-2q for ged-emacs-devel@m.gmane.org; Thu, 07 Sep 2017 03:18:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dpr43-0001Ol-Ls for emacs-devel@gnu.org; Thu, 07 Sep 2017 03:17:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dpr42-0003dw-D2 for emacs-devel@gnu.org; Thu, 07 Sep 2017 03:17:27 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43580) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dpr3w-0003bB-TN; Thu, 07 Sep 2017 03:17:21 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 42BF2160976; Thu, 7 Sep 2017 00:17:19 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id PJK103M9uOPq; Thu, 7 Sep 2017 00:17:13 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 574F7160991; Thu, 7 Sep 2017 00:17:13 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Lysh3-4RroDa; Thu, 7 Sep 2017 00:17:13 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 2AEF5160056; Thu, 7 Sep 2017 00:17:13 -0700 (PDT) In-Reply-To: <2082246123.1003353.1504734023438@mail.libero.it> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217973 Archived-At: This is a multi-part message in MIME format. --------------EA277FE35B85E283D0FA11DE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Angelo Graziosi wrote: > but I haven't a .git directory! Yes, in that case the intent was to skip the 'git' stuff by default. I never test in an environment that lacks 'git' so I didn't run into the problem when hacking on autoconf.sh. I installed the attached, which should fix the problem. Please give it a try (from the previous paragraph one can easily see that I have not tested that the patch actually fixes the problem :-). --------------EA277FE35B85E283D0FA11DE Content-Type: text/x-patch; name="0001-autogen.sh-omit-bogus-chatter-if-no-.git.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-autogen.sh-omit-bogus-chatter-if-no-.git.patch" >From 1836e5616699d553eb73b66d1c77135cf8a8e1e9 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 7 Sep 2017 00:10:05 -0700 Subject: [PATCH] autogen.sh: omit bogus chatter if no .git Problem reported by Angelo Graziosi in: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00045.html * autogen.sh (git_config): Do not execut 'git' if $do_git fails. --- autogen.sh | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/autogen.sh b/autogen.sh index 0d00d56..b3c5f48 100755 --- a/autogen.sh +++ b/autogen.sh @@ -269,23 +269,23 @@ fi git_config () { + $do_git || return + name=$1 value=$2 ovalue=`git config --get "$name"` && test "$ovalue" = "$value" || { - if $do_git; then - if $git_was_ok; then - echo 'Configuring local git repository...' - case $cp_options in - --backup=*) - config=$git_common_dir/config - cp $cp_options --force -- "$config" "$config" || exit;; - esac - fi - echo "git config $name '$value'" - git config "$name" "$value" || exit - fi - git_was_ok=false + if $git_was_ok; then + echo 'Configuring local git repository...' + case $cp_options in + --backup=*) + config=$git_common_dir/config + cp $cp_options --force -- "$config" "$config" || exit;; + esac + fi + echo "git config $name '$value'" + git config "$name" "$value" || exit + git_was_ok=false } } -- 2.7.4 --------------EA277FE35B85E283D0FA11DE--