From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#44294: No widen by xref-find-definitions Date: Thu, 29 Oct 2020 13:31:28 +0200 Message-ID: <5cfcbbf0-beef-3c0a-9641-a010925dbda4@yandex.ru> References: <87mu06p1aw.fsf_-_@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18133"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Juri Linkov , 44294@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 29 12:32:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kY6A8-0004bl-E4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 12:32:12 +0100 Original-Received: from localhost ([::1]:44440 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kY6A6-0008EG-OM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Oct 2020 07:32:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY69y-0008E3-S9 for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 07:32:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kY69y-0007V2-IP for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 07:32:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kY69y-000773-Ev for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 07:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Oct 2020 11:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44294 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch Original-Received: via spool by 44294-submit@debbugs.gnu.org id=B44294.160397109926117 (code B ref 44294); Thu, 29 Oct 2020 11:32:02 +0000 Original-Received: (at 44294) by debbugs.gnu.org; 29 Oct 2020 11:31:39 +0000 Original-Received: from localhost ([127.0.0.1]:52053 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY69b-0006mu-0P for submit@debbugs.gnu.org; Thu, 29 Oct 2020 07:31:39 -0400 Original-Received: from mail-ej1-f52.google.com ([209.85.218.52]:37036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY69Z-0006gj-IZ for 44294@debbugs.gnu.org; Thu, 29 Oct 2020 07:31:37 -0400 Original-Received: by mail-ej1-f52.google.com with SMTP id p9so3345667eji.4 for <44294@debbugs.gnu.org>; Thu, 29 Oct 2020 04:31:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ir20V+/9H01SsERMonsQk1xIFWbBEU+fZ6UU5JAezsU=; b=XGwpQYW/x3mc8TEnFEjNdtQyoicDTHiFWqAmldUAhCbnOci0RG5vwmstc0F+Fdjwxt Dvu0ZLT49wMkP0aw1jtEl6rFBbWPFJ+2UuuLNK/9DehYLB9sM2jTR0ucUXUPLb0WPlqQ J4xz9lMe8WtzMSfgOXvN8rbsSaP3uOWVH+TS572SNmLjySRUQPZaDqnVz8lltdDrRPTI e3jjSh/EvvEA+KxVHup70UddB+/OYsDjWBIEF8VvDijp4809Q6vd7oJdUAWCZb7P96AU LeeSDAP0xZKpTd9fzwZ8NBFqg6Ktst9BvEh0Fsg5sgEOTvhJl13ATnIiz2U+vPon8P3K RTBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ir20V+/9H01SsERMonsQk1xIFWbBEU+fZ6UU5JAezsU=; b=mHyWYthl1shEGENn0iz30/7hcfzl4T+XgUwR/LRubu9P32VTvnam6BHgGxpLrtbjaX OeeHbLo/bSEbndmFH6sxLNYQH9M/xpcz1EcfdjUUnCGvlkPwOoMLFyX7NmI0mueSjWQz DZWPzrYezN4K0MqELwutlCp/b4VXFpDJj+RPaewVnPB954aFe1Lg7bEDB/nMRzv7qOEP X90VHEcJW/NIdrdB/x5wWAFe7vPF/YPJTyBpNolipHhh7jacVOP6KGcpNPVd7oNbHHk+ RIFvqw6y2WSCH7avMctLHQ+GWTEkG1J2X8067ifUvsOAL4stWtAu/dez7EFlHNqSPjZj 46fw== X-Gm-Message-State: AOAM531Z9y0Zpdo3sM9t2lCHZjp6CL6Kdxj3ADIz1AyT6CKHlN36i4+W fW1N9QdesbMUW1GCQs+kHlvwZto86Er7og== X-Google-Smtp-Source: ABdhPJy44/PJ91GskxqD3/IVk3iFmSmSCsZVLaemsJigFbID1Fwk4KqTbtMNdDqQYZNQl0qORX0KyQ== X-Received: by 2002:a17:906:660f:: with SMTP id b15mr3661832ejp.333.1603971091442; Thu, 29 Oct 2020 04:31:31 -0700 (PDT) Original-Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id o20sm1362968eja.34.2020.10.29.04.31.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 04:31:30 -0700 (PDT) In-Reply-To: <87mu06p1aw.fsf_-_@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191949 Archived-At: On 28.10.2020 22:01, Juri Linkov wrote: > - (user-error "Rerun etags: `%s' not found in %s" > - pat buffer-file-name))) > + (if (or (= (point-min) 1) (not widen-automatically)) > + (user-error "Rerun etags: `%s' not found in %s" > + pat buffer-file-name) > + ;; Rerun after removing narrowing > + (widen) > + (etags-goto-tag-location tag-info)))) By the way... have you tried to use the same method here as in elisp-mode? Meaning, widen unconditionally inside 'save-restriction'. There should be no reason for backends to do it differently. And this way, you don't have to always search twice for a missing tag when inside a narrowing.