From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>, 44294@debbugs.gnu.org
Subject: bug#44294: No widen by xref-find-definitions
Date: Thu, 29 Oct 2020 13:31:28 +0200 [thread overview]
Message-ID: <5cfcbbf0-beef-3c0a-9641-a010925dbda4@yandex.ru> (raw)
In-Reply-To: <87mu06p1aw.fsf_-_@mail.linkov.net>
On 28.10.2020 22:01, Juri Linkov wrote:
> - (user-error "Rerun etags: `%s' not found in %s"
> - pat buffer-file-name)))
> + (if (or (= (point-min) 1) (not widen-automatically))
> + (user-error "Rerun etags: `%s' not found in %s"
> + pat buffer-file-name)
> + ;; Rerun after removing narrowing
> + (widen)
> + (etags-goto-tag-location tag-info))))
By the way... have you tried to use the same method here as in
elisp-mode? Meaning, widen unconditionally inside 'save-restriction'.
There should be no reason for backends to do it differently. And this
way, you don't have to always search twice for a missing tag when inside
a narrowing.
next prev parent reply other threads:[~2020-10-29 11:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 20:01 bug#44294: No widen by xref-find-definitions Juri Linkov
2020-10-28 21:37 ` Dmitry Gutov
2020-10-29 8:30 ` Philipp Stephani
2020-10-29 9:11 ` Juri Linkov
2020-10-29 9:09 ` Juri Linkov
2020-10-29 21:20 ` Juri Linkov
2020-10-29 11:31 ` Dmitry Gutov [this message]
2020-10-29 21:18 ` Juri Linkov
2020-10-29 21:33 ` Dmitry Gutov
2020-10-30 7:38 ` Juri Linkov
2020-10-30 16:54 ` Dmitry Gutov
2020-10-31 19:41 ` Juri Linkov
2020-10-31 23:14 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cfcbbf0-beef-3c0a-9641-a010925dbda4@yandex.ru \
--to=dgutov@yandex.ru \
--cc=44294@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.