From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Newsgroups: gmane.emacs.bugs Subject: bug#36009: [PATCH] Use lexical-binding in textmodes/page.el and add tests Date: Sun, 02 Jun 2019 12:25:04 +0200 Message-ID: <5cf3a401.1c69fb81.d8546.e65d@mx.google.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="241761"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 36009@debbugs.gnu.org, stefan@marxist.se To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 02 12:26:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hXNh0-0010lo-0J for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jun 2019 12:26:22 +0200 Original-Received: from localhost ([127.0.0.1]:47299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXNgz-0005RD-13 for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jun 2019 06:26:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXNgj-0005Kc-70 for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 06:26:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXNgi-0002Dr-6t for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 06:26:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54199) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXNgi-0002DV-0H for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 06:26:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXNgf-00012g-VZ for bug-gnu-emacs@gnu.org; Sun, 02 Jun 2019 06:26:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2019 10:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36009 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36009-submit@debbugs.gnu.org id=B36009.15594711163926 (code B ref 36009); Sun, 02 Jun 2019 10:26:01 +0000 Original-Received: (at 36009) by debbugs.gnu.org; 2 Jun 2019 10:25:16 +0000 Original-Received: from localhost ([127.0.0.1]:39510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXNfv-00011F-IB for submit@debbugs.gnu.org; Sun, 02 Jun 2019 06:25:15 -0400 Original-Received: from mail-lf1-f67.google.com ([209.85.167.67]:39256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXNfs-0000xX-IA for 36009@debbugs.gnu.org; Sun, 02 Jun 2019 06:25:13 -0400 Original-Received: by mail-lf1-f67.google.com with SMTP id p24so4832109lfo.6 for <36009@debbugs.gnu.org>; Sun, 02 Jun 2019 03:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:from:to:cc:subject:in-reply-to:date:mime-version; bh=LY68XbO0ZyAuH17rQzprRAHtyLodptdkv/i2iuV0KfM=; b=B5vbQvdhPd1qMOMoLEboyEkruH7IaXPBX9OZ/LFOATqgQWneU8kyVbJgVC8k9K0QPg uvcH6EdrZpJFD2nZaUwAaMs+bmRk/REiAZvHHzslrE5sF0yj2/p7kVQoOSH3HOlZ1Zqg tcvoBK/oRA++f3Rq8jK27BEV6ojRH15qb8ZQZzkf2FtgtfcdvEaE+t/9/jJKQII9FwDh VfDZ0mgcg2vGpnotNGok4nFhc0A92YmLLOxdoRb/45XjJDp7tM+jFa2BjJUieLx6jl1M uiHj4cKApSkP14+Cb0DMNJsk+TF2GGPj5K2yplq3ouz42m8YN/tmMlwVkv0fkz+97NTQ lptw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:from:to:cc:subject:in-reply-to:date :mime-version; bh=LY68XbO0ZyAuH17rQzprRAHtyLodptdkv/i2iuV0KfM=; b=M9WUbIlFZLNtmoMMiOs5h5oyNiOH4AB36kiboWzwHgm4s51yCWY/fg7AcRc70qMnzl ZSlIY4Hgru2Ess3AhidHuYEdBntLfkWiR+EnKD3zTeq5nkncj+gUHtSsCVCq74qdaNyR Nang591ff6sCKHYjkGSAREyH0uuqr7rg2vHx/5QndS9oWN6DFIEUBNd3UCiPYolqjQsE +MqbiUzwgYO+DDSSeEsL9plZMdqanLDYjJg8THAgZjWy4q+B7dUPXxyYJLVc7ggGvd4S z5PMd4d+RSFMydwCGiOf1svvwFeujfZ89S9AW6B+1JcfECMJ/om1c9nJwLbOwPvrqRyV kTWQ== X-Gm-Message-State: APjAAAUd7xiySNuBcic5AtHL9DxcEGh6MuCF33S2Q7nBnVd1mhv1mAjz eqnKbxw/433EQ2iIZhRGCgWK+eiQ X-Google-Smtp-Source: APXvYqyl+dGtyODPXnTJ23Pk1kfcv0YhFw9at1u4hfGOnkVp6IeQDxkNjotSDwjs+BnrVEOiggCSvQ== X-Received: by 2002:a19:740e:: with SMTP id v14mr11366875lfe.144.1559471106306; Sun, 02 Jun 2019 03:25:06 -0700 (PDT) Original-Received: from ae25 (cm-84.210.143.4.getinternet.no. [84.210.143.4]) by smtp.gmail.com with ESMTPSA id f5sm2418320ljc.25.2019.06.02.03.25.05 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 02 Jun 2019 03:25:05 -0700 (PDT) X-Google-Original-Message-ID: <871s0cl1xb.fsf@simenheg@gmail.com> In-Reply-To: (message from Paul Eggert on Sat, 1 Jun 2019 18:58:02 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160025 Archived-At: Oh, sorry Stefan, what a coincidence! I chose that file at random yesterday. I should do a Debbugs search in advance next time. Regarding the tests they look almost identical, except that I left out tests for `count-lines-page' and `what-page', because I was unsure whether they would be too dependent on the format of the user messages. Maybe it would be good to factor out the meat of `count-lines-page' and `what-page' into two internal functions returning just the raw numbers, test those, and turn the interactive functions into interfaces for them? -- Simen