From: "Simen Heggestøyl" <simenheg@gmail.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 36009@debbugs.gnu.org, stefan@marxist.se
Subject: bug#36009: [PATCH] Use lexical-binding in textmodes/page.el and add tests
Date: Sun, 02 Jun 2019 12:25:04 +0200 [thread overview]
Message-ID: <5cf3a401.1c69fb81.d8546.e65d@mx.google.com> (raw)
In-Reply-To: <c3564a92-dda8-24df-cde5-399cddb2bef7@cs.ucla.edu> (message from Paul Eggert on Sat, 1 Jun 2019 18:58:02 -0700)
Oh, sorry Stefan, what a coincidence! I chose that file at random
yesterday. I should do a Debbugs search in advance next time.
Regarding the tests they look almost identical, except that I left out
tests for `count-lines-page' and `what-page', because I was unsure
whether they would be too dependent on the format of the user messages.
Maybe it would be good to factor out the meat of `count-lines-page'
and `what-page' into two internal functions returning just the raw
numbers, test those, and turn the interactive functions into
interfaces for them?
-- Simen
next prev parent reply other threads:[~2019-06-02 10:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 18:31 bug#36009: [PATCH] Use lexical-binding in textmodes/page.el and add tests Stefan Kangas
2019-06-02 1:58 ` Paul Eggert
2019-06-02 10:25 ` Simen Heggestøyl [this message]
2019-06-13 22:02 ` Stefan Kangas
2019-06-22 10:55 ` Simen Heggestøyl
2019-06-22 21:32 ` Stefan Kangas
2019-06-22 23:57 ` Paul Eggert
2019-06-23 5:29 ` Simen Heggestøyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf3a401.1c69fb81.d8546.e65d@mx.google.com \
--to=simenheg@gmail.com \
--cc=36009@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.