From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Phil Sainty Newsgroups: gmane.emacs.bugs Subject: bug#38575: 27.0.50; Document that `diff' arguments OLD and NEW can be buffers Date: Thu, 12 Dec 2019 20:44:15 +1300 Message-ID: <5ce9330b0930c6a72c26fd08f66156d4@webmail.orcon.net.nz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="28371"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Orcon Webmail To: 38575@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 12 08:45:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ifJ9s-0007EH-Su for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Dec 2019 08:45:13 +0100 Original-Received: from localhost ([::1]:55626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifJ9r-0004xH-Ar for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Dec 2019 02:45:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37442) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifJ9j-0004x5-52 for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:45:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifJ9i-0008CT-2c for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53014) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ifJ9h-0008C5-UU for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ifJ9h-0003wg-T0 for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:45:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Dec 2019 07:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38575 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.157613666415051 (code B ref -1); Thu, 12 Dec 2019 07:45:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Dec 2019 07:44:24 +0000 Original-Received: from localhost ([127.0.0.1]:58987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifJ96-0003uh-Be for submit@debbugs.gnu.org; Thu, 12 Dec 2019 02:44:24 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:36125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ifJ93-0003uW-T1 for submit@debbugs.gnu.org; Thu, 12 Dec 2019 02:44:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57155) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ifJ92-0004t3-OM for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:44:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ifJ91-0006lA-Hc for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:44:20 -0500 Original-Received: from smtp-2.orcon.net.nz ([60.234.4.43]:34335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ifJ91-0006gm-5q for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 02:44:19 -0500 Original-Received: from [10.253.37.70] (port=44246 helo=webmail.orcon.net.nz) by smtp-2.orcon.net.nz with esmtpa (Exim 4.90_1) (envelope-from ) id 1ifJ8w-000052-6g for bug-gnu-emacs@gnu.org; Thu, 12 Dec 2019 20:44:14 +1300 Original-Received: from wlgwil-nat-office.catalyst.net.nz ([202.78.240.7]) via [10.253.37.253] by webmail.orcon.net.nz with HTTP (HTTP/1.1 POST); Thu, 12 Dec 2019 20:44:15 +1300 In-Reply-To: X-Sender: psainty@orcon.net.nz X-GeoIP: -- X-Spam_score: -2.9 X-Spam_score_int: -28 X-Spam_bar: -- X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173210 Archived-At: This feature dates to the following commit, which I believe was first released in 24.1. Because this seems such a useful feature, I'm inclined to add a NEWS entry as well, with the note "This change was made in Emacs 24.1, but wasn't documented until now." -Phil commit b2e4481906ec08e2c6072b6fe14dd1efca4784b9 Author: Stefan Monnier Date: Mon Nov 22 14:22:03 2010 -0500 Cleanup diff-buffer-with-file. * lisp/vc/diff.el (diff-old-temp-file, diff-new-temp-file): Remove. (diff-sentinel): Get them as arguments instead. (diff-old-file, diff-new-file, diff-extra-args): Remove. (diff-file-local-copy, diff-better-file-name): New funs. (diff-no-select): Rename from diff-into-buffer. Support buffers additionally to files. Move `buf' arg. Don't display buf. Prefer closures to buffer-local variables. (diff): Adjust accordingly. (diff-buffer-with-file): Move from files.el. * lisp/files.el (diff-buffer-with-file): Move to vc/diff.el. (diff-buffer-internal): Remove. (diff-buffer-buffer): Remove. (save-some-buffers-action-alist): Use diff-no-select so as not to guess the buffer name used, and so as not to mess up windows and frames.