From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Tue, 19 Nov 2019 13:12:10 +0200 Message-ID: <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="199845"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: Lars Ingebrigtsen , Stephen Berman , 38044@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 19 12:13:19 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iX1Rf-000pr3-HL for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Nov 2019 12:13:19 +0100 Original-Received: from localhost ([::1]:44040 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX1Re-0003ho-Ev for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Nov 2019 06:13:18 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46321) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iX1RX-0003gG-Vv for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 06:13:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iX1RX-00015h-2R for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 06:13:11 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37867) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iX1RW-00015a-Uf for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 06:13:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iX1RW-0003NI-Jn for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2019 06:13:10 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2019 11:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157416194212918 (code B ref 38044); Tue, 19 Nov 2019 11:13:02 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 19 Nov 2019 11:12:22 +0000 Original-Received: from localhost ([127.0.0.1]:46688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX1Qj-0003MI-PD for submit@debbugs.gnu.org; Tue, 19 Nov 2019 06:12:21 -0500 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:54596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iX1Qh-0003Lv-Fo for 38044@debbugs.gnu.org; Tue, 19 Nov 2019 06:12:19 -0500 Original-Received: by mail-wm1-f43.google.com with SMTP id z26so2711213wmi.4 for <38044@debbugs.gnu.org>; Tue, 19 Nov 2019 03:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iF8xm+387vtRJ+4NdCc/OdJYKoSocdqpGGyDCyWa0NE=; b=gjzjD2H/dUpN0eGLEwjPtxQ3kAwFHdQvI0O9R3t+rrgO73NPmlAdBBHwyU8/MjU7bj BeGE7VKWlUHpyxUYGmrBO5wZTdj2cLAHngfvbjIhzwS2o0DMdmakwqUapiVpd0oByuSx 5UROWeMoBUefa9vlQgf7tdaZz4wVUIe59paE4rdTFHqwWUNyWGFe9HQ3nwpX0RQgJuSR BQMQc/ugJ3NY04+cbMSC3Ftl79HzX9pkITE+A7Fl+LzAeVykYODy03qP+n4LowTp2ytR 9e0sKg10Cs4QC8zY6VKC2D4P7MXVlG97rzbbhnEWUoxFOjGRBfoZLVebNt6hL/BvZbql 1LPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iF8xm+387vtRJ+4NdCc/OdJYKoSocdqpGGyDCyWa0NE=; b=s7WQ1IYFcGAzYILcdp5skC5lcuhioUsoLpm7J+MuNmxteQZB9+kws+Q0S1nsD1HoGO brq/5NOo8U0Eg4rijsu2gsjItXUeDsgAJzbXB29+Ne7OZrfU9jtRgLvXB1wP4aFeRtT4 2O75fYIzJoW+ti9y6+V58d4Xuj6GYS+mlHZ+Tqv0hmI2GHUx88ts4ZR9WtuqVHqKww0L AVAuy+iWavKFfGmZpwF/E2gLZlTU/gLBumv59s5W96Jz20rkHsKhBWBYhJU9IxvPdWWF Ma/WQ4u5lIlI9URziyRnjukdtUdFIPJw6vFGlsQGL7XVrsNyOtinmYXyLlEizQ3ek6NF msng== X-Gm-Message-State: APjAAAUXs0gLQzsU+Yy2lFFprd8vfh/yExyUB2QdcHaQqqJ734RwPB6O cegJcVMlXXAZ6IZ8flfl1mQ9SLx2 X-Google-Smtp-Source: APXvYqyll31aZNmbG32CMpZLQVMMrInlgQC/UOrsjyTaNyl2iD63IdrQ2PSaDYm4kKiBFQ42AcOm7w== X-Received: by 2002:a05:600c:2549:: with SMTP id e9mr4627638wma.177.1574161933040; Tue, 19 Nov 2019 03:12:13 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id z8sm26167208wrp.49.2019.11.19.03.12.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Nov 2019 03:12:11 -0800 (PST) In-Reply-To: <877e3wub09.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171967 Archived-At: On 18.11.2019 23:31, Juri Linkov wrote: > +(defun vc-git-log-search (buffer pattern &optional limit) > > + (let ((args (if limit > + `("log" "--no-color" "-n" "1" ,(or pattern "")) > + `("log" "--no-color" "-i" > + ,(format "--grep=%s" (or pattern "")))))) Why would we hardcode that if LIMIT is passed then PATTERN is a revision, not a search string? Let's please make it another backend command instead of piggy-backing on 'log-search'.