From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Sun, 23 Apr 2023 00:19:24 -0700 Message-ID: <5c8a8bd8-e0b3-42ac-e278-242379b146e6@gmail.com> References: <838rel46ou.fsf@gnu.org> <865y9ptfa3.fsf@aarsen.me> <83354t44kn.fsf@gnu.org> <875y9p2h3u.fsf@thaodan.de> <83h6t82yao.fsf@gnu.org> <0a76fcd4-df69-56e0-ba90-30dc211ad56e@gmail.com> <83v8hnyvou.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11255"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bjorn.bidar@thaodan.de, arsen@aarsen.me, acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 23 09:20:27 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqU1K-0002lz-Tq for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Apr 2023 09:20:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqU0Q-0002Qe-B7; Sun, 23 Apr 2023 03:19:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqU0O-0002QN-Hm for emacs-devel@gnu.org; Sun, 23 Apr 2023 03:19:28 -0400 Original-Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqU0M-0006n6-R1; Sun, 23 Apr 2023 03:19:28 -0400 Original-Received: by mail-pj1-x1029.google.com with SMTP id 98e67ed59e1d1-24782fdb652so2488066a91.3; Sun, 23 Apr 2023 00:19:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682234365; x=1684826365; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=XRn+wPifKiGr+4ihSX69tMK9Be+5K5Cb3NenLOv5a/Q=; b=IBW67J0+FhjJFuMgG1/aEJmInL9vaacbjjIue6BiTO1ZaV9Ok4SKbdzpWk+qj9bEcy Q3xnBJtaHf0TfDLxJfFsWPFtZPG0nnh1yfxHLIVtOicCXxCsIIoEMNpmcvoeTsB4zPbC mnzJmU7kz0EfuZe+Hlc/5tkyEam0mmO4goCVekEr5ZVpXyvgVzOC66MmmlkL7gb8u5La YgL8Va425ga+LLLF9btCfAsig7CiiZ8hBEuYgNBAmUPI9eQLv1BgGN53saRS33ejeHGb gNXmwasgn4Er4iftZtu5JFKJfbnJUc9lfdIFhrGkXK15OSFYHGO6uU3kF9iWfJwVzPIt njaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682234365; x=1684826365; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XRn+wPifKiGr+4ihSX69tMK9Be+5K5Cb3NenLOv5a/Q=; b=bRJqg/+SBC+UfWW/QWni0mLOsa9SAX5Q5hTaJa2KeVZkurLZj6txSSzDzJyavDWzhA +8wyX9MASgWdyPH55aRRnIce2XwFAKnEHvgthS059DpABRKVvrtEXJ2NCp7pd3o04lDh /CQ1ihOebX3Bp3FJNJCmxnn+JUE8AHCoxRyzJuX1zbsODGJ39qFx2VLkxOSKDLu3eog8 MwMwpw2N5yKLGO3ALhBUIGBGALror9xvtbMco6eWUtZ6T0cE9PHh4jRQtF1iO87IXVEn Yuhgh/WdmVkISQjg+sqIK2skBNNgwwThnxWPD5y1HdZihct0effvW1G78eRiMXnkeZHV moWw== X-Gm-Message-State: AAQBX9d8K215h/8QjXKMR8TPsVdGiB8L12RjtZnX/vf/taLQXs+ASM2h MP4J+dnO44QH/bcnLBmjeP9aH48FFXkuhQ== X-Google-Smtp-Source: AKy350Y6pKf0RMjhFH4nOb02L2+oJgk8tUNplEZYN0psSPdNGsfkvlyvw7OEcZXXMDsQvbvYrWRbtw== X-Received: by 2002:a17:90b:120c:b0:23f:ebf2:d3e9 with SMTP id gl12-20020a17090b120c00b0023febf2d3e9mr10154401pjb.6.1682234364658; Sun, 23 Apr 2023 00:19:24 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x15-20020a17090a46cf00b00247164c1947sm8022100pjg.0.2023.04.23.00.19.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Apr 2023 00:19:24 -0700 (PDT) Content-Language: en-US In-Reply-To: <83v8hnyvou.fsf@gnu.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305598 Archived-At: (I forgot to reply to this part of the message previously...) On 4/22/2023 11:11 PM, Eli Zaretskii wrote: > But if so, what do you want the user who does the merge do? The log > messages of past commits cannot be amended, so this would simply > preclude people from pushing merges and/or force them to use the > "--no-verify" switch. For example, a frequent situation for merges is > a merge from the release branch to master -- if one or more of the > commits being merged has bad log messages, we don't want to block the > merge, because nothing can be done about those bad messages at the > time of the merge. I wonder if we should get rid of the pre-push hook entirely then. While a committer can theoretically amend old commits prior to the merge, this is messy, a lot of work, and could cause other problems too. This would mean that a committer sees a warning about bad log messages (at post-commit time), but it doesn't actually prevent them from doing anything. A warning might be too easy to ignore, but maybe it's better than being silent about it. I'm not sure what to do here...