Re: Proposal: new default bindings for winner and windmove

[Dmitry Gutov <dmitry@gutov.dev>]

On 02/07/2024 15:18, Eli Zaretskii wrote:
>> Cc: Stefan Kangas <stefankangas@gmail.com>,  Stefan Monnier
>>   <monnier@iro.umontreal.ca>,  emacs-devel@gnu.org
>> Date: Tue, 02 Jul 2024 09:02:12 +0800
>> From:  Po Lu via "Emacs development discussions." <emacs-devel@gnu.org>
>>
>> Daniel Colascione <dancol@dancol.org> writes:
>>
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [left] 'windmove-left)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [right] 'windmove-right)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [up] 'windmove-up)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [down] 'windmove-down)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [(shift left)] 'windmove-swap-states-left)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [(shift right)] 'windmove-swap-states-right)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [(shift up)] 'windmove-swap-states-up)
>>> +;;;###autoload
>>> +(define-key ctl-x-4-map [(shift down)] 'windmove-swap-states-down)
>>> +
>>>   \f
>>>   (provide 'windmove)
>>>   
>>
>> Disabling windmove-mode must disable these bindings as well.
> 
> I tend to agree.

The most straightforward path toward this might be:

- Set the option windmove-default-keybindings to the new set (like 
above) by default.
- Actually enable windmove-mode by default, which will load the package. 
But also set up the keymap filled by the previous item.
- We might also change the function windmove-default-keybindings so that 
is clears up the previous bindings (saved to the value of the option 
with the same name). I think that also was one of your concerns.

The apparent downside is that the package will have to be loaded before 
any of the commands are used for the first time.