From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#33498: 26.1; Unable to delete minibuffer-only+child frames Date: Wed, 6 Mar 2019 11:07:14 -0800 Organization: UCLA Computer Science Department Message-ID: <5c5d4a99-2b3f-785b-82f8-2ba5fb6da6cc@cs.ucla.edu> References: <8736rpfklv.fsf@hochschule-trier.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------A94519812E319ABA5F7C464F" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="229209"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 Cc: 33498@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 06 20:08:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1btl-000xWJ-9F for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Mar 2019 20:08:13 +0100 Original-Received: from localhost ([127.0.0.1]:37887 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1btk-0004XV-9Q for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Mar 2019 14:08:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1btd-0004XA-6h for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 14:08:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1btb-0006dX-Gg for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 14:08:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49357) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1bta-0006cF-1N for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 14:08:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1btZ-0000Ts-OF for bug-gnu-emacs@gnu.org; Wed, 06 Mar 2019 14:08:01 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <8736rpfklv.fsf@hochschule-trier.de> Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Mar 2019 19:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33498 X-GNU-PR-Package: emacs Original-Received: via spool by 33498-submit@debbugs.gnu.org id=B33498.15518992471798 (code B ref 33498); Wed, 06 Mar 2019 19:08:01 +0000 Original-Received: (at 33498) by debbugs.gnu.org; 6 Mar 2019 19:07:27 +0000 Original-Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1bt1-0000Sv-2V for submit@debbugs.gnu.org; Wed, 06 Mar 2019 14:07:27 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:35798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1bsy-0000Sf-TX for 33498@debbugs.gnu.org; Wed, 06 Mar 2019 14:07:25 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9A361161517; Wed, 6 Mar 2019 11:07:18 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nR57WS1lT68S; Wed, 6 Mar 2019 11:07:17 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C1479161509; Wed, 6 Mar 2019 11:07:17 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Xs9q6PTNAeky; Wed, 6 Mar 2019 11:07:17 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id A5066161400; Wed, 6 Mar 2019 11:07:17 -0800 (PST) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156107 Archived-At: This is a multi-part message in MIME format. --------------A94519812E319ABA5F7C464F Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit > I think I fixed this now on master. Please have a look. Unfortunately the fix broke builds configured with --enable-gcc-warnings, as GCC complains about the use of an uninitialized variable that appears to be a typo in the fix. I installed the attached patch to unbreak the build; please check it to make sure that I understood the intent of the fix correctly. It's a good idea to use './configure --enable-gcc-warnings' when making changes to the C code in Emacs, as GCC is reasonably good at catching typos like this, and typically does not generate too many false alarms. --------------A94519812E319ABA5F7C464F Content-Type: text/x-patch; name="0001-Fix-typo-in-fix-for-Bug-33498.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Fix-typo-in-fix-for-Bug-33498.patch" >From 62879cbeae0221033a40d9f66e08673e4975e332 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 6 Mar 2019 11:04:57 -0800 Subject: [PATCH] Fix typo in fix for Bug#33498 * src/frame.c (delete_frame): Fix typo in previous patch, which caused GCC to complain about the use of an uninitialized variable. --- src/frame.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frame.c b/src/frame.c index 3d83dc0a0d..1219569068 100644 --- a/src/frame.c +++ b/src/frame.c @@ -2236,7 +2236,7 @@ delete_frame (Lisp_Object frame, Lisp_Object force) for at least one other frame - so make it visible and quit. */ if (!FRAME_VISIBLE_P (f1) && !FRAME_ICONIFIED_P (f1)) - Fmake_frame_visible (frame1); + Fmake_frame_visible (minibuffer_child_frame); return Qnil; } -- 2.20.1 --------------A94519812E319ABA5F7C464F--