From: Dmitry Gutov <dmitry@gutov.dev>
To: Stefan Monnier <monnier@iro.umontreal.ca>, Yuan Fu <casouri@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 66732@debbugs.gnu.org, dominik@honnef.co
Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably
Date: Wed, 20 Dec 2023 04:01:20 +0200 [thread overview]
Message-ID: <5c59b83b-87e7-6f8e-2372-740efcc102f6@gutov.dev> (raw)
In-Reply-To: <jwv4jgi2icc.fsf-monnier+emacs@gnu.org>
On 16/12/2023 19:11, Stefan Monnier wrote:
>> Hmm... This `put-text-property` can't be right.
>> Can you trace `font-lock-fontify-region` and
>> `font-lock-default-fontify-region` to check that they correctly return
>> the proper (extended) bounds of the region they (re)fontified?
> BTW, using the extend-region-function isn't ideal: this is meant for
> things which can't be refontified separately, so if a change in the
> buffer causes notification to make changes over a large portion of the
> buffer we'll end up (re)fontified*right away* that whole large
> portion even if only a small part (or even no part at all) is displayed.
BTW, do you have an example of a "thing which can't be refontified
separately"?
Otherwise, I think a reorganization would be possible where when the
region is extended to more than the visible area of the buffer, some
parts of the buffer are marked as unfontified, but don't force their
highlighting in the same cycle. Basically, what the
pre-redisplay-functions patch does, but using the
*-extend-region-functions protocol.
Might not be trivial code-wise. I guess it also depends on how much we
consider the current approach of requesting an additional display
iteration, to be a problem (e.g. does that create any real difference
performance-wise).
The use of pre-redisplay-functions avoid that question, but asks the
programmer to work on a lower level of abstraction (i.e. know about
'fontified' => nil), as well as possibly apply this change to a bigger
region than necessary (again, not sure about the performance impact).
next prev parent reply other threads:[~2023-12-20 2:01 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 14:22 bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Dominik Honnef
2023-10-24 23:15 ` Dmitry Gutov
2023-10-29 12:22 ` Eli Zaretskii
2023-11-18 8:37 ` Eli Zaretskii
2023-12-11 4:16 ` Yuan Fu
2023-12-11 12:05 ` Eli Zaretskii
2023-12-11 14:35 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-11 15:53 ` Dmitry Gutov
2023-12-12 7:50 ` Yuan Fu
2023-12-12 12:43 ` Dmitry Gutov
2023-12-13 3:28 ` Yuan Fu
2023-12-13 3:45 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-13 7:12 ` Yuan Fu
2023-12-13 14:30 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-14 1:43 ` Dmitry Gutov
2023-12-14 8:29 ` Yuan Fu
2023-12-15 1:01 ` Dmitry Gutov
2023-12-15 7:12 ` Yuan Fu
2023-12-16 5:56 ` Yuan Fu
2023-12-16 15:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 17:11 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 17:23 ` Dmitry Gutov
2023-12-16 17:43 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 19:18 ` Yuan Fu
2023-12-16 19:57 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 23:09 ` Dmitry Gutov
2023-12-17 1:16 ` Yuan Fu
2023-12-17 18:32 ` Dmitry Gutov
2023-12-19 3:12 ` Yuan Fu
2023-12-20 1:52 ` Dmitry Gutov
2023-12-20 5:43 ` Yuan Fu
2023-12-20 11:31 ` Dmitry Gutov
2023-12-16 23:02 ` Dmitry Gutov
2023-12-20 2:01 ` Dmitry Gutov [this message]
2023-12-20 3:08 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-16 22:56 ` Dmitry Gutov
2023-12-18 18:27 ` Dmitry Gutov
2023-12-18 19:12 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-18 19:33 ` Eli Zaretskii
2023-12-18 23:10 ` Dmitry Gutov
2023-12-19 3:22 ` Eli Zaretskii
2023-12-19 3:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-19 12:41 ` Eli Zaretskii
2023-12-19 12:44 ` Dmitry Gutov
2023-12-20 20:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-23 10:17 ` Eli Zaretskii
2023-12-23 18:02 ` Yuan Fu
2023-12-23 20:46 ` Dmitry Gutov
2023-12-23 20:51 ` Dmitry Gutov
2023-12-23 23:07 ` Yuan Fu
2023-12-24 2:10 ` Dmitry Gutov
2023-12-24 3:02 ` Yuan Fu
2023-12-23 20:55 ` Dmitry Gutov
2023-12-24 6:03 ` Eli Zaretskii
2024-02-08 1:40 ` Yuan Fu
2023-12-18 23:08 ` Dmitry Gutov
2023-12-20 20:50 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-12 15:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c59b83b-87e7-6f8e-2372-740efcc102f6@gutov.dev \
--to=dmitry@gutov.dev \
--cc=66732@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=dominik@honnef.co \
--cc=eliz@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.