From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] contrib: ob-sclang: Fix compilation issue. Date: Mon, 26 Mar 2018 19:38:42 +0800 Message-ID: <5c112467-9e76-4e2f-6c29-05e2fa04f6a5@gmail.com> References: <878tahvytr.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------AA703959BDE7EB6A84E67D24" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52312) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f0QSi-00055b-4V for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 07:38:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f0QSe-0007WU-SE for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 07:38:52 -0400 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]:33171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f0QSe-0007W7-N3 for emacs-orgmode@gnu.org; Mon, 26 Mar 2018 07:38:48 -0400 Received: by mail-it0-x243.google.com with SMTP id z143-v6so12147752itc.0 for ; Mon, 26 Mar 2018 04:38:48 -0700 (PDT) Received: from [0.0.0.0] ([119.28.89.243]) by smtp.gmail.com with ESMTPSA id s142-v6sm4253934itb.4.2018.03.26.04.38.45 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 04:38:46 -0700 (PDT) In-Reply-To: <878tahvytr.fsf@gmail.com> Content-Language: en-US List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org This is a multi-part message in MIME format. --------------AA703959BDE7EB6A84E67D24 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` for built-time defaults. When user load sclang from source code of `scel`. This will cause error. Really don't understand why you have to `(require 'sclang)` instead of `(require 'sclang-interp)`? Can you tell me why? On 03/25/2018 07:27 AM, Maxim Cournoyer wrote: > Hello! > > The attached patch fixes a byte compilation issue in ob-sclang.el. > > Thank you! > > Maxim > --------------AA703959BDE7EB6A84E67D24 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

You `(require 'sclang)` cause error on `(require 'sclang-vars)` failed. Because there is no file `sclang-vars.el`. Only file `sclang-vars.el.in` for built-time defaults. When user load sclang from source code of `scel`. This will cause error.

Really don't understand why you have to `(require 'sclang)` instead of `(require 'sclang-interp)`? Can you tell me why?

On 03/25/2018 07:27 AM, Maxim Cournoyer wrote:

Hello!

The attached patch fixes a byte compilation issue in ob-sclang.el.

Thank you!

Maxim

--------------AA703959BDE7EB6A84E67D24--