* Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes [not found] ` <20180217154025.25F47206A2@vcs0.savannah.gnu.org> @ 2018-02-20 0:06 ` Dmitry Gutov 2018-02-21 10:06 ` Richard Stallman 0 siblings, 1 reply; 4+ messages in thread From: Dmitry Gutov @ 2018-02-20 0:06 UTC (permalink / raw) To: emacs-devel, Charles A. Roelli Hi all, On 2/17/18 5:40 PM, Charles A. Roelli wrote: > (defun change-log-get-method-definition () > -"For Objective C, return the method name if we are in a method." > + "For Objective C, return the method name if we are in a method." > (let ((change-log-get-method-definition-md "[")) > (save-excursion > (if (re-search-backward "^@implementation\\s-*\\([A-Za-z_]*\\)" nil t) Isn't it weird how we have an Objective-C specific function inside add-log.el? It isn't used anywhere in Emacs these days, AFAICT. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes 2018-02-20 0:06 ` [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes Dmitry Gutov @ 2018-02-21 10:06 ` Richard Stallman 2018-02-21 16:33 ` Dmitry Gutov 0 siblings, 1 reply; 4+ messages in thread From: Richard Stallman @ 2018-02-21 10:06 UTC (permalink / raw) To: Dmitry Gutov; +Cc: charles, emacs-devel [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > Isn't it weird how we have an Objective-C specific function inside > add-log.el? It makes sense for add-log.el to support all sorts of obscure languages. If change-log-get-method-definition is not used anywhere, maybe that failure to call it is a bug. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) Skype: No way! See https://stallman.org/skype.html. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes 2018-02-21 10:06 ` Richard Stallman @ 2018-02-21 16:33 ` Dmitry Gutov 2018-02-22 8:01 ` Richard Stallman 0 siblings, 1 reply; 4+ messages in thread From: Dmitry Gutov @ 2018-02-21 16:33 UTC (permalink / raw) To: rms; +Cc: charles, emacs-devel On 2/21/18 12:06 PM, Richard Stallman wrote: > [[[ To any NSA and FBI agents reading my email: please consider ]]] > [[[ whether defending the US Constitution against all enemies, ]]] > [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > > Isn't it weird how we have an Objective-C specific function inside > > add-log.el? > > It makes sense for add-log.el to support all sorts of obscure languages. It would be silly, code organization-wise. Major modes should contain that support code. And indeed, they do that via add-log-current-defun-function or add-log-current-defun-header-regexp. objc-mode sets both variables. > If change-log-get-method-definition is not used anywhere, maybe that failure > to call it is a bug. It seems to me people simply forgot to remove it after the code was factored out. Around Emacs 20.1, the definition of add-log-current-defun was much longer and called this function (named differently back then), among many other things. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes 2018-02-21 16:33 ` Dmitry Gutov @ 2018-02-22 8:01 ` Richard Stallman 0 siblings, 0 replies; 4+ messages in thread From: Richard Stallman @ 2018-02-22 8:01 UTC (permalink / raw) To: Dmitry Gutov; +Cc: charles, emacs-devel [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > It makes sense for add-log.el to support all sorts of obscure languages. > It would be silly, code organization-wise. Major modes should contain > that support code. And indeed, they do that via > add-log-current-defun-function or add-log-current-defun-header-regexp. > objc-mode sets both variables. Your statement and mine do not conflict. -- Dr Richard Stallman President, Free Software Foundation (https://gnu.org, https://fsf.org) Internet Hall-of-Famer (https://internethalloffame.org) Skype: No way! See https://stallman.org/skype.html. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-22 8:01 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20180217154022.29183.21950@vcs0.savannah.gnu.org> [not found] ` <20180217154025.25F47206A2@vcs0.savannah.gnu.org> 2018-02-20 0:06 ` [Emacs-diffs] emacs-26 e5a2933: lisp/vc/: documentation fixes Dmitry Gutov 2018-02-21 10:06 ` Richard Stallman 2018-02-21 16:33 ` Dmitry Gutov 2018-02-22 8:01 ` Richard Stallman
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.