From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Sat, 5 Sep 2020 11:10:31 -0400 Message-ID: <5bd82b3a-0108-5dd4-88dd-e3def6b77e01@cornell.edu> References: <5889C6B4.8060506@gmx.at> <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <83eengpgdn.fsf@gnu.org> <83d030pfrf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="320"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, Noam Postavsky To: Dani Moncayo , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:12:06 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEZrJ-000ATP-Sk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:12:06 +0200 Original-Received: from localhost ([::1]:45450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEZrI-0006iv-Vz for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:12:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEZqI-0005rc-6A for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:11:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60526) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEZqH-0001hQ-QI for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:11:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEZqH-0001ux-MT for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.15993186437347 (code B ref 25542); Sat, 05 Sep 2020 15:11:01 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 5 Sep 2020 15:10:43 +0000 Original-Received: from localhost ([127.0.0.1]:43839 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEZpz-0001uQ-34 for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:10:43 -0400 Original-Received: from mail-bn8nam11on2112.outbound.protection.outlook.com ([40.107.236.112]:25340 helo=NAM11-BN8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEZpw-0001uC-Gj for 25542@debbugs.gnu.org; Sat, 05 Sep 2020 11:10:41 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B5vUIXTIXFta6JAZCx552N3tyB98JXSUJxztY5HTuij0YpMFC9wjf495wTaSyn/hY+b3Va1eZEuXUqv+DaA87MFiuP7F1/ARF1oyjjkfZRug4cKrMZiWKrWf/LD8EjAzp/Wv5RM2dD+Ra+wdFJ3WGatctcsBsOEiZp7bh7C7xSRLYTdVyMUrVj/th3PQyPmnXLaxwYn0cZLHtIjaOH+h+mLh5rxnfyyxIod8PVoIQXk4fUrAcDJNKMjm6K/V6/tMqj5EMh3Bn5Dg65hN3ACF5N8VUn4CQc1osvoiZqw9yJmWYreXmMav94suzXw5cMrupiqpz0BZ0oPQCM2LYg2YnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=buyup+9NmDRoNDzAp4465fYdnm/8zeohy2z+YySWLSU=; b=Obkd8WnDF3xsA46+TrbHqdZZQiD+BJjMnWZvFhetEfUYbCYN6qm6oe9pm/NuurrqapxGHi0wxRZbqQkOgDlvmxIq99yKKTDGF8VYNKUFIBcKjUnMcA3M+jj17ONamrI6QFhjQVoGmbvuuViD5S789ZotKERN1Ou/r6++ph5sJCrys1KoaONk4vkjvAqSBmtkj/tvLB4yYGK/I0SwGogTkoWXdoF6KdzwSC6LLopUdjaWWdgjdpP0SPN62ehxCfDLowpQsDDRj0tYmH4qpQ34/frCfFvmuvSu+x9W2CtGfq/21DUYR0VaIsjE3ry1zVZrxQYincy0RKfBP/okWcroLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=buyup+9NmDRoNDzAp4465fYdnm/8zeohy2z+YySWLSU=; b=Ppc2vSHJbFlHIA4lKBRdfKyim3XEosvZ8DjGD6FlmerDahVqGsq/RrQ756W1KBtnGXL50nCbF+VGCWss7ygez1LAP6/0sYFR0s2wdiG2OgCJLIWCjOGDlOm55Ops0i4Jasl19xukA2yJWyu6dekw8QJjEUB8dE5NNZ0JtSboclk= Authentication-Results: gmx.at; dkim=none (message not signed) header.d=none;gmx.at; dmarc=none action=none header.from=cornell.edu; Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) by MN2PR04MB5487.namprd04.prod.outlook.com (2603:10b6:208:d5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.16; Sat, 5 Sep 2020 15:10:34 +0000 Original-Received: from MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44]) by MN2PR04MB6176.namprd04.prod.outlook.com ([fe80::c144:d206:c369:af44%7]) with mapi id 15.20.3348.017; Sat, 5 Sep 2020 15:10:34 +0000 In-Reply-To: Content-Language: en-US X-ClientProxiedBy: BL0PR0102CA0027.prod.exchangelabs.com (2603:10b6:207:18::40) To MN2PR04MB6176.namprd04.prod.outlook.com (2603:10b6:208:e3::13) X-MS-Exchange-MessageSentRepresentingType: 1 Original-Received: from [IPv6:2604:6000:b407:7f00:6c3f:b207:591d:92fb] (2604:6000:b407:7f00:6c3f:b207:591d:92fb) by BL0PR0102CA0027.prod.exchangelabs.com (2603:10b6:207:18::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.19 via Frontend Transport; Sat, 5 Sep 2020 15:10:32 +0000 X-Originating-IP: [2604:6000:b407:7f00:6c3f:b207:591d:92fb] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3595f81-341d-4684-7675-08d851add63b X-MS-TrafficTypeDiagnostic: MN2PR04MB5487: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CNvK7z3QZd8Cu9BMTdapkk0+xS8Im8fRUtXmFAR0GKRLnYFD89NG10b4qMDz4/kdoe1zwMsQHfOHlr9agonsettEJKO1W2CGHI/+mMBBe2AElzz53Cs2IBmH1qnot+0RG3Nnb/fz1PvizW5eujKpZNjNfPA4IeOxwOORDE6FXq/9EpbTpGwemvjpEuSl/RphOAOggJVwIfl9Ayjmc3s4LDeclK51lNdicrJi3QB3RKmVSatHqIXLuz/cEULHfjrTir8ZP1EVc57nI/UWwArRfCx9NBd2amIS56gEs4AVSMzAlNMOgrKJpqP25Xl/sgEkC+y2s6i0L+L91ZGHvcQT3gSKJrTAWdnOIwIo4vhwl8X87eKmoPJY79VOEZ24ot2m/0AfasJ9JSYUdI5K9oq+UX/gDRp0zHLAFYxUp2vdg1yB6Up/b7OIJ2amCgFt50XbpDT5M9rbVPH+0hw8t0eZQ+oB3Gq+wiAMwAZ0DxG5H0M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR04MB6176.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(54906003)(8936002)(110136005)(2906002)(8676002)(52116002)(186003)(16526019)(53546011)(316002)(786003)(75432002)(478600001)(36756003)(6486002)(66556008)(5660300002)(2616005)(66476007)(4326008)(31686004)(86362001)(31696002)(66946007)(83380400001)(14963001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: L3s7j0AA3MUzsKsXcy5FmbiSAzx7KKa0vPWJj6qGQAgPKdoiHPSimDUSAPg0AGDktWcQ1gkPqS4fhR91ZG1DZe4CSOCm/kG//07sI1Q6JA1TcgWJ9ZAXP0idB5CPOgqZu0GT/5odFoxZVU5k8Ws+mQa5jPB7gtzkaF/YUZOgs/GhB1JIMcXSo5Hv4cqixBx5/c9/HX7Y9UBSeC4PLsltU7K7hhMxK6P0WBsec9qZ1VV+4qi5bKOuFGK+990m4itUVFm0Ghmc+QM+IFUiArlLTkjpFrgDRf0e+SGY5mbJjV8J2fMCt0Hi+xXqh8U9bxtc3j83z1uoifM4YRDLgStFH9+h8grYW/VH8OkUovCy5SA2OYxoP0h1jcZmGyeerAWM/Rh/a7JNkmjmQ1XqmfgSMDP+KIPJfrCYLaLlV57lNcKw8jGkhjYVDc67AsQWoDDe3DgCCPYtMshZ6gI9gNHPx8MTI9d9NfiyBaEDcCbY4jqzNLy0J2Ho38SWHsgn3LO1F56AP+VTuqZSEVGXn8uJK8k38JIgzZPkWoBY53aEDZjlowmtNOPCXVuEcO+fHpEQgGoDlvUSBKWfYIZvs7HqAvweLrd0ZYGzYL/XKEWlmHQ0TZwqHXX1o++IplJjpCiebowcqofRUKsO2zfFFutJuCg+DVGRZajcqJtR0omik3RwJHbo+YufbOusAbQS9bef22rrM8pAyMobAJoB+PiUog== X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: d3595f81-341d-4684-7675-08d851add63b X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6176.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2020 15:10:34.1076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pPjjuOuS05YVua/hT320AdqOGnE5dy2U//cQe7wwFYwvcOqc0qe6joViDUuddFtqZbnHtZXkV1VhCvrlqviktA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB5487 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187260 Archived-At: On 9/5/2020 8:32 AM, Dani Moncayo wrote: > On Sat, Sep 5, 2020 at 2:30 PM Eli Zaretskii wrote: >> >>> From: Dani Moncayo >>> Date: Sat, 5 Sep 2020 14:19:10 +0200 >>> Cc: Ken Brown , Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, >>> Noam Postavsky , martin rudalics >>> >>> On Sat, Sep 5, 2020 at 2:17 PM Eli Zaretskii wrote: >>>> [...] >>>> Then we have a reproducibility problem, because I don't see this with >>>> the native build, and neither did Martin at the time (see his initial >>>> response to the original bug report). >>> >>> Did you try with the taskbar attached to the left side of the screen? >> >> No. And it isn't clear to me whether Martin did. > > OK. So, are you able to reproduce the problem now? > > BTW, another detail I've just noticed to reproduce the problem: in the > "taskbar settings" the flag "Automatically hide the taskbar" must be > turned off. I can reproduce the problem on the Cygwin w32 build, but Martin's suggestion (https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25542#83) doesn't fix it. He suggested the following, if I understand correctly: diff --git a/src/w32term.c b/src/w32term.c index 76cf6bd696..c7da95528b 100644 --- a/src/w32term.c +++ b/src/w32term.c @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal, simple hack to check that based on the fact that only a maximized fullscreen frame should have both top/left outside the screen. */ - if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight) - || NILP (fullscreen)) - { - int x, y; - - w32_real_positions (f, &x, &y); - if (x < 0 && y < 0) - store_frame_param (f, Qfullscreen, Qmaximized); - } + store_frame_param (f, Qfullscreen, Qmaximized); } break; If I make this change and follow Dani's recipe from the original bug report, the second F11 press doesn't restore the previous state. Instead, the frame appears to get slightly smaller for an instant and then immediately reverts to fullscreen mode. Ken