From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Sat, 18 May 2024 16:33:43 +0300 Message-ID: <5baa5d54-2fff-4cc6-8bb5-a46976cb8b33@gutov.dev> References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> <8f3b86fa-a7ee-4ef0-8953-944efb65f9df@gutov.dev> <418c5f45-9f89-43dd-b8b8-00f0aab9192b@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2485"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat May 18 15:34:46 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8KCz-0000Q8-SG for ged-emacs-devel@m.gmane-mx.org; Sat, 18 May 2024 15:34:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8KCB-0007CK-0j; Sat, 18 May 2024 09:33:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8KC8-0007Bo-G8 for emacs-devel@gnu.org; Sat, 18 May 2024 09:33:52 -0400 Original-Received: from wfhigh3-smtp.messagingengine.com ([64.147.123.154]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8KC6-0008F9-Jz for emacs-devel@gnu.org; Sat, 18 May 2024 09:33:52 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailfhigh.west.internal (Postfix) with ESMTP id EB3A218000B8; Sat, 18 May 2024 09:33:46 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Sat, 18 May 2024 09:33:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1716039226; x=1716125626; bh=yyIiu01NuhVcIFF37AkqRii47ifuk9hQ0xbsvnUjzfQ=; b= T2GjSrcDoPCHHb/0dIOPHYRCRqCbzWiCji/4j4xKD8zJKI63ZLDw5jxMOZJpGE3s JL5LgIhV+kFreLcvRJkrWOld4lDLE6tG14+24fncwX5/EyDu2ZUiZOO4iE2Ia1bq 7/YwakZtVIFKz36TdEPEL9Y8OPMlCAKr0VgXMdPSXFj4T4MB2PxhoGQ5F7RildT3 PCQ6Tc1iWUMovfE9mZhVhKeGLAgcWHxpsFPTbbXuLHed52oLDKXPw62UEPTTcJB9 +ZO4ij8WOFrF10ptkRJhbiP+yLHcvvi239wozInOqCTHTvermstEvnoK83G38NHZ YEyycAvXZx5xZK1uW+6DCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716039226; x= 1716125626; bh=yyIiu01NuhVcIFF37AkqRii47ifuk9hQ0xbsvnUjzfQ=; b=E qNs7ErMg4uPF7+B/9MPfhtxKpwiNYJK0Oy7rpaeuuf3Yx5rOIJBlRq9jO6vSy0Dt 28iQvoLV7Xm8T/F6VnC7/idplmAjhJRm2zE/h6Onyc7O78YQvYYYLNQuiXSArikx 5gi50V8bHn9zkP4OOLRi1v3gmBEK0vEefSXvjnlZU+c6fM6E30bRA3q+lyRg53A7 Djd+/5Zxq+ZMn0JqEi7E/JwDkcAopYTQmbvOMRp6tuL84DqWrn0I/QYPfKp3r8y3 qEtZYaI5GZRDNG5oqG8BZCsZn6QxP/8XBG8vq44ii9wypgwMBqdhE8Ls7VIrVs2+ WZheVe/gpy+sjMomKD8Og== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdehiedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttddvjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehg uhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhe dvveeikeeufedtvddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 May 2024 09:33:45 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.154; envelope-from=dmitry@gutov.dev; helo=wfhigh3-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319344 Archived-At: On 18/05/2024 09:55, Eshel Yaron wrote: > Dmitry Gutov writes: > >> Hi Eshel, >> >> On 17/05/2024 11:56, Eshel Yaron wrote: > [...] >>> I'm afraid there might be another regression, here's what I see: >> >> Thanks for keeping an eye out. >> >>> 1. emacs -Q >>> 2. C-x C-f >>> 3. C-a C-k to clear the minibuffer >>> 4. Insert the path an Emacs checkout, e.g. "~/checkouts/emacs/" >>> 5. Further insert "l/mi" >>> 6. Hit ? to pop the completions list, which includes >>> "lisp/minibuffer.el" and "leim/MISC-DIC/", among others. >> >> FWIW, I don't see "leim/MISC-DIC" among completions, even if I first >> evaluate (setq completion-ignore-case t). > > Weird, perhaps you have read-file-name-completion-ignore-case set to nil > and that takes effect rather than plain completion-ignore-case? Indeed, it's nil. I started with 'emacs -Q' to avoid my settings' interference, and assumed your scenario used it as well. Anyway... >> But the crux of the problem reproduces fine. > > Great. > >>> 7. Lean on M- to cycle between completion candidates. >>> After the last fix, I see M- accumulate text after point in >>> the >>> minibuffer instead of replacing the part it previously inserted. Do you >>> see that as well? >> >> Please take the attached patch for a spin. > > Nice, this seems to fix the regression at hand, and so far I'm not > seeing any other issues. Great! I've pushed it to master now. >> It would be great if someone looked into writing integration tests for >> this somehow. This is brittle stuff, and the variety of scenarios is >> high enough. > > I agree. The default completion UI supports various interactions that > can break in subtle ways, and that's without even configuring stuff. > I'll try to code a couple of test cases when I have the time. That would be very welcome, thanks.