From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#37563: 27.0.50; fit-frame-to-buffer does not account for line-spacing Date: Tue, 1 Oct 2019 10:10:44 +0200 Message-ID: <5b9fda23-4a2b-f5ff-5e49-22cdd4c857a5@gmx.at> References: <87tv8tsk3f.fsf@kenko.localhost.com> <87lfu4aook.fsf@kenko.localhost.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="11079"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37563@debbugs.gnu.org To: Ingo Lohmar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 01 10:12:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFDGS-0002ln-EO for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 10:12:08 +0200 Original-Received: from localhost ([::1]:59686 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFDGR-0000jV-0O for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Oct 2019 04:12:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53931) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iFDFR-0000jL-7M for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 04:11:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iFDFQ-0006Tk-9O for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 04:11:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52000) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iFDFQ-0006Tf-2L for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 04:11:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iFDFO-0006Mw-HK for bug-gnu-emacs@gnu.org; Tue, 01 Oct 2019 04:11:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 08:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37563 X-GNU-PR-Package: emacs Original-Received: via spool by 37563-submit@debbugs.gnu.org id=B37563.156991745624467 (code B ref 37563); Tue, 01 Oct 2019 08:11:02 +0000 Original-Received: (at 37563) by debbugs.gnu.org; 1 Oct 2019 08:10:56 +0000 Original-Received: from localhost ([127.0.0.1]:60821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFDFI-0006MZ-AC for submit@debbugs.gnu.org; Tue, 01 Oct 2019 04:10:56 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:46929) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFDFF-0006MM-Fy for 37563@debbugs.gnu.org; Tue, 01 Oct 2019 04:10:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1569917444; bh=zk4JGuA/tWXvv21MpulorjUJegFdr1Zgm+qH+LUTwSk=; h=X-UI-Sender-Class:Subject:To:References:Cc:From:Date:In-Reply-To; b=GfkD/eb/CWL0nLr+X3Zq49J7SwfuwvQoz+LG8vNcX0gpmSUZIfs+mePxu4uaow+VC TRuXkYRm4jcnWRICV0YxIKLkFJXIUro9OrQKrFshfOyW9bETVTQHAcdYFfOMryWtm4 CVWoVTZfkkxHCVwcpJ1W97OrrltdaoYipg1PGErM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.101] ([212.95.5.139]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N17Ye-1i8IHe2fko-012Zfi; Tue, 01 Oct 2019 10:10:44 +0200 In-Reply-To: <87lfu4aook.fsf@kenko.localhost.com> Content-Language: de-AT X-Provags-ID: V03:K1:T7/VNHusTAlHS48cr16cd152Px7iHQJtYSEUVg6pK4AERc8LNre pRrrWkYGBnc/uDyECa61FfacOBQ/FAtyLkjpyzpRvmgs99JkMAgxUKDEna5iqNCoU5dw1Hn Ry+e48pjVZuaLcnxd4iCvqkrBMA1IYi+S7J1ZnEFMUe66401BNBwGnv5jS8lBBo255QvD5c aUykG1r/nMu9qYyp2DTfg== X-UI-Out-Filterresults: notjunk:1;V03:K0:nSs03OJ51UQ=:TV3lWCcza/0n1rmXtdECZP VmyoNwlyrnnI+OUFtDXEtu0tiqiUxVuAW9joVknhiJd9HPqg0fKfk/We2/A8Nh493qX6wI4JH QOEPsRd4fKt7/44MxznkCdIhkk+FI5ojs+0y2YvYBAdqduNkmr7e0qd6+9v4ahou7P/X0q2pF DLzH/qLEJSaHLpdreum8ZuS3+5wLSWPwwhn1zMd4lU5z4zlIxFief2/aIMRJ4uqHa2WwJFrwY hEjPW797gQd5MJLP1XUnIUwuKbFzq9AsAVaYj1uIAD0vxF+c/KOtzIiC9UW0PH63hVAatMTt5 GoZvtmGNwtk/RRi3wUn1nQ8p7GDzZf1Ljna2MjiZT+3hdSbqFKGhhGPPDmkqS30Co2AUx9HNp Yep/DuzVP/OfzTC9EGlFJEVxSeYGseU49FYlYGewvfWIpEtyuBG1u/FecB0J1Y7OSMGGmHH1f IP8bbMuPqPGPqpEE5f75rBepF21AxnfYBn7LtnJp+RHcosHMDOuSE8xLHAWS6Y7jLTCuiMFMT sjQZVwYU+TplY1MfX/gJM4bz3Ohqyn9NI9klF8zWNNog9uYNP4tlA/wbk7ggrZIck7HhkjnNX 9844+oLTEk08m412msE8bO7UsWOSKjPQKBfBa/GDOcAXQTIYCe42wQKdrcgvAtXf5D0rfHJsl L3v6KG7g/3tsdnVZUbUfrxsYbH46B68Ll2aIhKjf8L1GHyspfxCTtqGVdLeyOKGNWdnJ+Dl07 8a/+Htu7COqDgOW1dIMfJFgpg6Oc69j4ctr4qSVxjZNfztOIfcdVgKOIP2LkEyE0s/V4oJ3I X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167975 Archived-At: > thanks for the quick reply! The fix is working for me. The separate > window-*-height functions are much better than what I sent a few > minutes ago, I missed all kinds of scenarios, of course. For consistency, I would use these functions in 'fit-window-to-buffer' as well. But I haven't looked into all consequences yet. There's also Bug#14825 still sitting around the corner, awaiting a proper solution. It's somehow troubling that all these substitute canonical character height with real line height fixes are inherently backward incompatible. What if someone did mean to use the canonical character height there? > There's one thing from my patch, however, that I think is missing in > yours: I think you're right but I need to see your patch first. It's not here yet. > In ll 8831ff, the height is rounded if frame-resize-pixelwise is > nil. That also uses char-height, and I think it should be line-height > there as well. In that case, char-height is no longer used in the > function. Which certainly would be an asset. Thanks, martin