From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: Some developement questions Date: Sun, 9 Sep 2018 16:05:59 -0700 (PDT) Message-ID: <5b906c57-fbb7-459d-8d29-da91f0ce509a@default> References: <<8336v6cvem.fsf@gnu.org>> <<87zhxcbmtr.fsf@himinbjorg.adminart.net> <83in409lub.fsf@gnu.org>> <<871sanb71j.fsf@himinbjorg.adminart.net> <83y3cu7t9j.fsf@gnu.org>> <<87lg8t2ki9.fsf@himinbjorg.adminart.net> <20180827015422.lcq44zvsjffeau4j@Ergus>> <<83a7p76f5e.fsf@gnu.org> <87lg8p9o6y.fsf@russet.org.uk>> <<83pnxx1foj.fsf@gnu.org> <87k1o1a06q.fsf@russet.org.uk>> <<877ek1ql6u.fsf@toy.adminart.net> <87tvn2g665.fsf@russet.org.uk> <83r2i6wv4v.fsf@gnu.org>> <<87ftylu327.fsf@toy.adminart.net> <838t4dvefc.fsf@gnu.org>> <<87tvn1qw75.fsf@toy.adminart.net> <83worxtlbw.fsf@gnu.org>> <<87sh2lm1xs.fsf@toy.adminart.net> <83in3gtsqa.fsf@gnu.org>> <<87mussp1zu.fsf@toy.adminart.net>> <> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1536535030 8479 195.159.176.226 (9 Sep 2018 23:17:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Sep 2018 23:17:10 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org, spacibba@aol.com, phillip.lord@russet.org.uk To: "Charles A. Roelli" , hw Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 10 01:17:05 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fz8wx-00024s-J8 for ged-emacs-devel@m.gmane.org; Mon, 10 Sep 2018 01:17:03 +0200 Original-Received: from localhost ([::1]:49002 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz8z3-0004pl-Np for ged-emacs-devel@m.gmane.org; Sun, 09 Sep 2018 19:19:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51894) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fz8yp-0004ia-1e for emacs-devel@gnu.org; Sun, 09 Sep 2018 19:19:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fz8ma-00030l-H5 for emacs-devel@gnu.org; Sun, 09 Sep 2018 19:06:21 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:40158) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fz8mS-0002wV-O3; Sun, 09 Sep 2018 19:06:13 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w89N5W5g079337; Sun, 9 Sep 2018 23:06:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=JCeDknnDq9rrLOIay3yxruujRLHl87/7jEkgkvAvPI8=; b=kR2i/UfO6tdD11IG6/Bov2NGB/dGSPRcdGbxMVdKmzQaEszML4b8IAVDZEuhKF6g+Dj3 SNwXVlV7v0nNvrQOAQuJJ5K7Mk8enTjlMvyUT6F7M4zZkGMzlw8F0aSiLJ5DXmkdcQ2N WLqpcmiPGxLOOAfwRcTyhSA1MnYQYigPKOllqTnXZ16R5hzi35vEQ7Zk7EIWVbwFqgfH SCgUECAWIoUH0+wvV1gvvzy0Ee4Y8r71dg4MZhZuBzDUIKYQwMgWsAGlzydrvX24wWsw xz1O3wjGKWGec5RK09bvGuwqEA+oal7mSevDHfecqYIZDER2ES3m6akKEXglA/OdHBzQ UQ== Original-Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2mc6cpb1gq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 09 Sep 2018 23:06:01 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id w89N61Bi002271 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 9 Sep 2018 23:06:01 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w89N60gP004836; Sun, 9 Sep 2018 23:06:00 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4735.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9011 signatures=668708 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1809090252 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 141.146.126.78 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229578 Archived-At: > The prefix-arg thing works with some other Info navigation > commands too. E.g. `C-u g Screen' goes to node `Screen' in a > new, cloned buffer, `C-u f Emacs Lisp' follows an xref to the > Emacs Lisp manual in a cloned buffer. (It doesn't work with > `l', `r', `n', `p', `u', however. (Maybe it should.) FWIW, in my own code I've added this to `n', `p', `u', `l', `r', `d', `]', and `['. So it's now available with those keys, plus `g', `f', and `m'. https://www.emacswiki.org/emacs/download/info%2b.el This could be added to Emacs, if someone is interested. The change is trivial. One thing I changed, which is peripherally related: Vanilla Emacs wraps the body of this and similar functions with `save-window-excursion'. I think that's wrong. It's problematic, for example, if you use a dedicated window for the new, cloned buffer or when it is otherwise shown in a separate frame. (defun Info-next (&optional fork) "Go to the next node of this node. If FORK is non-nil (interactively with a prefix arg), show the node in a new Info buffer. If FORK is a string, it is the name to use for the new buffer." (interactive "P") (unless (derived-mode-p 'Info-mode) (switch-to-buffer "*info*")) (Info-goto-node (Info-extract-pointer "next") fork)) But maybe someone can set me straight about this: let me know why the `save-window-excursion' was there and what a better fix would be than just removing it. I haven't yet noticed any problem from removing it. I see that in Emacs 23 the code used `pop-to-buffer' here, and that was changed to `switch-to-buffer'. It's also not clear to me why that change was made. (I left `switch-to-buffer' in my version, but it's not clear that "the selected window" would always be used to display the new buffer.)