bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Drew Adams]

dired-x.el has bound `M-o' to `dired-omit-mode', which is a toggle,
since Time Immemorial.  The facemenu commands were originally on
prefix key `M-g'.

Someone later had the bright idea to change `M-g' to prefix "go to"
commands.  And so, presumably without too much reflection about Dired X,
facemenu commands were moved to prefix key `M-o'.

So now you cannot put font-lock- or face-related commands on prefix
`M-o' in Dired, if you also use Dired X (which you should, of course).

`M-o' makes much more sense as a prefix key than as a toggle key.

I propose that we change the Dired X binding of `dired-omit-mode' to
`C-x M-o'.  Or to some other not-easily-repeatable key.  This toggle
does not need to be a quick key to use, at all.

In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2014-01-01 on ODIEONE
Bzr revision: 115827 eggert@cs.ucla.edu-20140101192741-bi5hb4xb4kdi2zpw
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Leo Liu]

On 2014-01-06 03:29 +0800, Drew Adams wrote:
> I propose that we change the Dired X binding of `dired-omit-mode' to
> `C-x M-o'.  Or to some other not-easily-repeatable key.  This toggle
> does not need to be a quick key to use, at all.

This seems like a good proposal. In general it is a bad idea to shadow a
prime global key without good reasons.

BTW, do you think C-x C-o delete-blank-lines similar to the omit mode
which delete uninteresting lines? If so may be use C-x C-o?

Leo

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Stefan Monnier]

>> I propose that we change the Dired X binding of `dired-omit-mode' to
>> `C-x M-o'.  Or to some other not-easily-repeatable key.  This toggle
>> does not need to be a quick key to use, at all.
> This seems like a good proposal. In general it is a bad idea to shadow a
> prime global key without good reasons.

Indeed, I find the "conflicts with global M-o binding" to be very weak,
but the I see no reason for dired-omit-mode to have a short key-binding,
so C-x <something> is perfectly fine for it.


        Stefan

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Leo Liu]

Fixed in 24.4.

On 2014-01-06 12:07 +0800, Stefan Monnier wrote:
> Indeed, I find the "conflicts with global M-o binding" to be very weak,
> but the I see no reason for dired-omit-mode to have a short key-binding,
> so C-x <something> is perfectly fine for it.

OK, I rebound it to C-x M-o as suggested by Drew.

Leo

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Drew Adams]

> This seems like a good proposal. In general it is a bad idea to
> shadow a prime global key without good reasons.
> 
> BTW, do you think C-x C-o delete-blank-lines similar to the omit
> mode which delete uninteresting lines? If so may be use C-x C-o?

That would be OK too, IMO.

[FWIW, so far I happen to use C-x C-o for `occur-by-moccur', and I
think others might too (it is suggested in the `color-moccur.el'
commentary), but this is not important.]

bug#16354: 24.3.50; `M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Juri Linkov]

> dired-x.el has bound `M-o' to `dired-omit-mode', which is a toggle,
> since Time Immemorial.  The facemenu commands were originally on
> prefix key `M-g'.

dired-x.el solves a similar problem for the conflicting key M-g
by using the upper-case G:

(define-key dired-mode-map "\M-G" 'dired-goto-subdir)

so doing the same we could use upper-case M-O for dired-omit-mode.
Actually dired-x.el already uses the upper-case O for the related command:

(define-key dired-mode-map "*O" 'dired-mark-omitted)

But before taking M-O into use it should be tested to work in emacs -nw
without problems.

bug#16354: 24.3.50; ?`M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Alan Mackenzie]

Juri Linkov <juri@jurta.org> wrote:
>> dired-x.el has bound `M-o' to `dired-omit-mode', which is a toggle,
>> since Time Immemorial.  The facemenu commands were originally on
>> prefix key `M-g'.

> dired-x.el solves a similar problem for the conflicting key M-g
> by using the upper-case G:

> (define-key dired-mode-map "\M-G" 'dired-goto-subdir)

> so doing the same we could use upper-case M-O for dired-omit-mode.
> Actually dired-x.el already uses the upper-case O for the related command:

> (define-key dired-mode-map "*O" 'dired-mark-omitted)

> But before taking M-O into use it should be tested to work in emacs -nw
> without problems.

M-O doesn't work on a Linux tty.  The shift-key is silently ignored,
producing M-o.

-- 
Alan Mackenzie (Nuremberg, Germany).

bug#16354: 24.3.50; ?`M-o' conflict in Dired - change Omit mode to `C-x M-o'

[Andreas Schwab]

Alan Mackenzie <acm@muc.de> writes:

> M-O doesn't work on a Linux tty.  The shift-key is silently ignored,
> producing M-o.

You can always use ESC.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."