From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring Date: Mon, 2 Nov 2020 08:18:24 -0800 (PST) Message-ID: <5af254d0-9bad-4443-919e-b05382e90b56@default> References: <87361u64oo.fsf@thb.lt> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16063"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44341@debbugs.gnu.org, Thibault Polge To: Philipp Stephani , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 02 17:19:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZcYA-00044R-Eg for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 17:19:18 +0100 Original-Received: from localhost ([::1]:44746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZcY9-0006iC-FE for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 02 Nov 2020 11:19:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40894) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZcXu-0006h3-Do for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:19:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59038) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZcXu-0007Tz-3R for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZcXt-00009r-Uu for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2020 11:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2020 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44341 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 44341-submit@debbugs.gnu.org id=B44341.1604333921578 (code B ref 44341); Mon, 02 Nov 2020 16:19:01 +0000 Original-Received: (at 44341) by debbugs.gnu.org; 2 Nov 2020 16:18:41 +0000 Original-Received: from localhost ([127.0.0.1]:42351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcXZ-00009G-0V for submit@debbugs.gnu.org; Mon, 02 Nov 2020 11:18:41 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:47406) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZcXV-000092-Vi for 44341@debbugs.gnu.org; Mon, 02 Nov 2020 11:18:39 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0A2G92nK034845; Mon, 2 Nov 2020 16:18:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=RulARSAzvhikJEjfs5n0EUA62a3+TXwyjF/bPfyJrDU=; b=qWurFW4IVQypeD3Z72tXvT24J2ddaC+De1Zo+AjXzmQsEbypGSNyJUjMFcYi9X5yJUkN m4UeGFH/70h9mxzyxohuhd+T/sTUmFD4vR7tUbLhqAD9+soICqisKRUhufwzKOZjj9zo cVydG7O8nF1DqYbxLcQYElenr3ycp4xdyTGW20xQ0AIrqs8aqE0MYWd/pvC/U1gt6CI0 DROyvdX4qJsctiEAbqLDOvn2HJQf4YVsv9eviaX+s2VeLUecNJLohcdJb8KftUnwROBF l+6qC6kZKYfDM1fBPpYE49nd3OL78il24KpzFhwt3x3N4UORpFgoBj4cJosNwFIr8PDt GA== Original-Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 34hhw2ctwx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 02 Nov 2020 16:18:32 +0000 Original-Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0A2GB0rH057954; Mon, 2 Nov 2020 16:18:31 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 34jf46r3ay-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 02 Nov 2020 16:18:31 +0000 Original-Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0A2GIQRV027981; Mon, 2 Nov 2020 16:18:27 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9793 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=994 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011020125 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9793 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 mlxscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 impostorscore=0 spamscore=0 lowpriorityscore=0 mlxlogscore=999 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011020125 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192547 Archived-At: > We should definitely signal an error here. A form such as (my-mode > 'enable) actually disabling the mode is very confusing. The mode > function needs to check for the various cases anyway, it might as well > use `cond' and signal an error in the non-matching case. Not to argue, but this kind of thing is all over Emacs Lisp. The ability to use an unspecified non-nil value, to mean/do something that might work against the natural-language "meaning" of the name of a symbol argument, is just one example of the vast amounts of rope that Lisp gives its users to hang themselves with. Do you really think `define-minor-mode' should be fiddled with specially here, to prevent use of an unfortunately named symbol arg to disable the mode? `define-minor-mode' and its doc, and the doc of minor modes, are already complex/confusing enough. Do you think fiddling to eliminate confusion over poorly named symbol values won't actually add to that confusion?