From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] (icomplete-vertical-mode): Add support for affixations and, annotations Date: Sat, 5 Jun 2021 04:08:21 +0300 Message-ID: <5adc993f-6f74-f9c3-ccbc-52646d7864bb@yandex.ru> References: <87y2c24lww.fsf@mail.linkov.net> <871r9t2lsy.fsf@mail.linkov.net> <22880197-6d05-c821-2c58-328ed3cfc02e@daniel-mendler.de> <87eedruui3.fsf@gmail.com> <8dd915fe-fe67-2a45-67ff-8aaa3e9b9aca@daniel-mendler.de> <878s3zuq47.fsf@gmail.com> <09f2a253-84ba-5cfd-552e-0b89109864a5@daniel-mendler.de> <875yyxaoxp.fsf@gmail.com> <871r9laj6a.fsf@gmail.com> <1a183c3b.2f2f.179cb27f64c.Coremail.tumashu@163.com> <87lf7s7lli.fsf@gmail.com> <2dd59f1c-1d4d-a7d7-fae5-d9ca9b5c90c2@yandex.ru> <8e0cfb49-4ce3-c9aa-21fd-f0063b7c8107@yandex.ru> <1792c288-18ef-410f-479f-6dec5da16aef@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32176"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: tumashu , Juri Linkov , "emacs-devel@gnu.org" , Daniel Mendler To: =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 05 03:09:09 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpKoH-00089t-QQ for ged-emacs-devel@m.gmane-mx.org; Sat, 05 Jun 2021 03:09:09 +0200 Original-Received: from localhost ([::1]:53192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lpKoG-00043y-70 for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Jun 2021 21:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lpKne-0003Ok-U7 for emacs-devel@gnu.org; Fri, 04 Jun 2021 21:08:30 -0400 Original-Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:35401) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lpKna-0005Os-0R for emacs-devel@gnu.org; Fri, 04 Jun 2021 21:08:30 -0400 Original-Received: by mail-wr1-x433.google.com with SMTP id m18so10944633wrv.2 for ; Fri, 04 Jun 2021 18:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DxtkPJisrSSXuOKdwkLjT/YTzAZeRmr33ga/toK4RYA=; b=qE3iYZFAwoILZNhxjlj7hsvf6lECvk582oWllzRjN0PBAjxXbGu+9GkNKgzwqw4WR9 wpX1j6+WeoCyF+PQCes8arsZyuTHQ7IVc84y/vSmKU9Ly3ENlEt0UBJGIY7NVv/Iu7J0 XuaJmmUDTxu3AcAEKVzR0iduWvwX5lKSShTc2w9elWrDjSTV4MICjLgWJtXF6/RBVpCK 98KhYjCMaApHe71V/2ZlpKhREQSBYy3bVVoauIkXpreM46uvDlcyhRDEfRSczsKvDFyH sNx4VOpq2UY/XFRtmqw2o2TfARzA6JKYrz/R14XIdrzL6vxiUSz1jC7P1RWx4iEh1Wzs 3vaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DxtkPJisrSSXuOKdwkLjT/YTzAZeRmr33ga/toK4RYA=; b=jsleMx8kqZBeP9lhMbKiCcY6t9VklLWrw9y28yBfp91Iy/VqL+CjlAA/g5dn9DULFE VyX8G0G9OsYEHhWrI6IYljZVp/EG9dNnSqbzl5B13LLD6y6+l9RwUM5mS+dj4xQMWjie wQKZeO1ntLVCaLs7XUFqB8FFzQI2mXyuQlEgDTQ9iPQoM3gHR0WbkyrAp6WCRVCyGiuW puJBKB1RtExM0er8nb8arAL/m/LE7RrCAS9WaBDwJsjW7hVl0pnswcU3v64+lDJb40Kj ndyDEA/4iVebAkErkxqSOyak5dtdoUG5uEqeBr4RsrWBd9MLTdcTIQSYTXqsBtwphFT7 1VPg== X-Gm-Message-State: AOAM530Od9TMcybbYR0PAM+kyncWA/w9tTT0Tb6URDlR2MeFJMu/QPIs iZvZcxsXrnPqZIW2LeVRZLcZ9QXk4tg= X-Google-Smtp-Source: ABdhPJzofSLe8L+QmS7lh+qidpEC4IV9ImrGqd151wHL9BCrJUPzajCzQ4UPXGAVDhRjPMApLkiOGg== X-Received: by 2002:a5d:6daf:: with SMTP id u15mr4529614wrs.400.1622855303432; Fri, 04 Jun 2021 18:08:23 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o129sm10030053wmo.22.2021.06.04.18.08.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jun 2021 18:08:22 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=raaahh@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.59, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270413 Archived-At: On 02.06.2021 18:07, João Távora wrote: > On Wed, Jun 2, 2021 at 3:54 PM Stefan Monnier wrote: >> >>>> AFAIK it was written under the assumption that the >>>> `icomplete-tidy` call would be automatically "undone" by the >>>> `post-command-hook` before the next redisplay. >>> Are you okay with the proposed change, then? >> >> I think it's worth a try. >> >>> And how do you feel about reducing icomplete-compute-delay to 100ms at most? > > For me maybe also not much less than that. For the first few chars, I > usuallly type fast enough, and I appreciate this CPU saving measure. > > 150ms down from 300ms maybe a good compromise to cut down on the > xx/xx transient inconsistency and still have the CPU saving thing. OK, so I went ahead with this change. And also took the liberty of changing icomplete-max-delay-chars to 2: in this day and age, we can certainly deal with longer lists than we could in 1998. But we can undo either change, of course, upon negative feedback. > Even better, as I suggested, is to make that proposed change be > conditional on the delay. Then people wanting no flicker just reduce > the delay, which is quite intuitive. I'm not sure who would want to change the delay to a higher value, and why (people are welcome to tell us). But even if someone decides to go back to 300 ms, I suspect they would still benefit from the new behavior.