From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#19551: 25.0.50; No lighter shown for `text-scale-mode' when it should be `+0' Date: Fri, 9 Jan 2015 14:53:42 -0800 (PST) Message-ID: <5a7e10ff-e3b4-4770-80e3-bf8c6e914443@default> References: <73f694e6-cb65-478a-96a2-05749ac658e0@default> <87sifj8tlt.fsf@gmx.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1420844061 22802 80.91.229.3 (9 Jan 2015 22:54:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Jan 2015 22:54:21 +0000 (UTC) Cc: 19551@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jan 09 23:54:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Y9iRZ-0001L4-9R for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jan 2015 23:54:13 +0100 Original-Received: from localhost ([::1]:52538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9iRX-0004On-UW for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Jan 2015 17:54:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9iRT-0004OV-LJ for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 17:54:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9iRO-0001mZ-7O for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 17:54:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9iRO-0001mT-3i for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 17:54:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Y9iRN-0006u4-Ka for bug-gnu-emacs@gnu.org; Fri, 09 Jan 2015 17:54:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 09 Jan 2015 22:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19551 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19551-submit@debbugs.gnu.org id=B19551.142084402826517 (code B ref 19551); Fri, 09 Jan 2015 22:54:01 +0000 Original-Received: (at 19551) by debbugs.gnu.org; 9 Jan 2015 22:53:48 +0000 Original-Received: from localhost ([127.0.0.1]:41234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9iR9-0006ta-VV for submit@debbugs.gnu.org; Fri, 09 Jan 2015 17:53:48 -0500 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:50339) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Y9iR8-0006tS-4b for 19551@debbugs.gnu.org; Fri, 09 Jan 2015 17:53:46 -0500 Original-Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id t09Mride006949 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 9 Jan 2015 22:53:45 GMT Original-Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id t09Mrgh3012178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 9 Jan 2015 22:53:43 GMT Original-Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id t09MrgGE000811; Fri, 9 Jan 2015 22:53:42 GMT In-Reply-To: <87sifj8tlt.fsf@gmx.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8.2 (807160) [OL 12.0.6691.5000 (x86)] X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:98152 Archived-At: > > I don't know how or why this happens, but when buffer text is zoomed ou= t > > and back in, so that the resulting text scale is neutral (100%, zero > > increase/decrease), the mode-line lighter should say `+0', as specified > > in the code (`face-remap.el'). For some reason, the lighter just > > disappears, as if the value of `text-scale-mode-lighter' were nil. >=20 > I don't think this is a bug. If I understand the code correctly, the > lighter disappears because the minor mode is turned off when the text > scale is 0; see this line in `text-scale-increase': >=20 > (text-scale-mode (if (zerop text-scale-mode-amount) -1 1)) Ah, right you are. I didn't notice that. I should have guessed this. > I also don't see anywhere in face-remap.el that specifies the lighter is > "+0" when the text scale is 0 (the default value of > `text-scale-mode-lighter' is "+0", but changes as soon as > text-scale-mode is enabled). It's done in `text-scale-mode': (setq text-scale-mode-lighter =09(format (if (>=3D text-scale-mode-amount 0) "+%d" "%d") =09=09text-scale-mode-amount)) That sets `text-scale-mode-lighter' to "+0" when `text-scale-mode-amount' i= s 0. I'm OK with the bug being closed.