From: "H.-J. Heitländer" <Heiner.Heitlaender@posteo.de>
To: 62239@debbugs.gnu.org
Subject: bug#62239: patch feedback
Date: Mon, 27 Mar 2023 08:27:48 +0000 [thread overview]
Message-ID: <5a6682df-f4fc-5ce7-1d04-6f40b5e2d955@posteo.de> (raw)
In-Reply-To: <6445c1ab-07e5-1473-c4a0-9e4f21f4eb6d@posteo.de>
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
Hi there,
Michael Heerdegen developed a patch for the problem.
Feedback: apply patch - not quite successfull
When trying to apply the patch
M-diff-mode
open patch-file
M-n
C-c C-a
I get "Hunk seriously messed up"
If I understand diff correctly, the patch aims for line 2204 =
"(add-hook 'change-major-mode-hook..."
In my version of doc-view.el that line: "(add-hook
'change-major-mode-hook..." is contained in line 2207.
That is probably the reason for "Hunk seriously messed up"
... So what I did is: I changed the source code of view-doc.el manually
and not via the delevered patch. Then I tested it and ...
TADA!!! Success!!! It works.
Thanks for the effort
Heiner
[-- Attachment #2: 62239.patch --]
[-- Type: text/x-patch, Size: 648 bytes --]
diff --git a/lisp/doc-view.el b/lisp/doc-view.el
index b14655fb274..00240ebf08d 100644
--- a/lisp/doc-view.el
+++ b/lisp/doc-view.el
@@ -2204,7 +2204,9 @@ doc-view-mode
(add-hook 'change-major-mode-hook
(lambda ()
(doc-view-kill-proc)
- (remove-overlays (point-min) (point-max) 'doc-view t))
+ (remove-overlays (point-min) (point-max) 'doc-view t)
+ (remove-function (local 'revert-buffer-function)
+ #'doc-view--revert-buffer))
nil t)
(add-hook 'clone-indirect-buffer-hook #'doc-view-clone-buffer-hook nil t)
(add-hook 'kill-buffer-hook #'doc-view-kill-proc nil t)
prev parent reply other threads:[~2023-03-27 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 9:02 bug#62239: 30.0.50; emacs 30.5.0 editing epub encoding system H.-J. Heitländer
2023-03-18 0:06 ` Michael Heerdegen
2023-03-27 8:27 ` H.-J. Heitländer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a6682df-f4fc-5ce7-1d04-6f40b5e2d955@posteo.de \
--to=heiner.heitlaender@posteo.de \
--cc=62239@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.