From: Dmitry Gutov <dgutov@yandex.ru>
To: Juri Linkov <juri@linkov.net>
Cc: 35624@debbugs.gnu.org
Subject: bug#35624: log-view-diff regression
Date: Wed, 15 May 2019 03:34:24 +0300 [thread overview]
Message-ID: <5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru> (raw)
In-Reply-To: <87bm04vky9.fsf@mail.linkov.net>
On 14.05.2019 23:29, Juri Linkov wrote:
>> Sorry, I don't. Can you find the change that removed it?
>
> I don't remember what VC backend produced such header, maybe
> vc-bzr or vc-svn. Or probably vc-cvs because CVS has the same
> header as RCS, and I can easily check what headers RCS produces
> because it doesn't require any configuration. For brevity
> only essential part of RCS log is left here for demonstration:
Thank you.
> Working file:
I guess RCS at least outputs some pertinent information here, not just
that text, so it's less puzzling. I don't know how useful it is, though.
> ----------------------------
> revision 1.4
> ----------------------------
> revision 1.3
> ----------------------------
> revision 1.2
> ----------------------------
> revision 1.1
>
> When the beginning of the region is on the "Working file" line
> in the header, and the end of the region is on a revision line,
> e.g. "revision 1.4", then typing `=' displays:
>
> No changes between 1.4 and workfile
You can also type 'C-u C-x v =', then '1.4', RET and C-j to omit the end
version. That would also show the diff against the workfile.
> and if the current workfile has some changes, then differences
> between 1.4 and workfile are displayed.
>
> This means that RCS supports this nice feature, but Git doesn't.
Just how nice is it, really? It seems pretty niche to me, and I don't
remember the last time I needed something like this exactly.
>>> + (with-current-buffer buffer
>>> + (insert "Working\n")
>>
>> How does the result look? Just the word "Working" at the beginning of
>> the buffer?
>
> If the word "Working" is too ambiguous, then at least an empty line
> at the beginning of the buffer will enable this feature for Git.
Should we really make the log look weirder for the sake of a feature one
would use at most, I don't know... once a month?
Why don't we create a 'fake history' entry in vc-diff and vc-root-diff
instead? Then the user could move point to a revision and type
C-u C-x v = M-n RET C-j
It's not as quick maybe, but this way you also avoid having to set the
"other' region bound.
next prev parent reply other threads:[~2019-05-15 0:34 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 21:56 bug#35624: log-view-diff regression Juri Linkov
2019-05-07 22:54 ` Dmitry Gutov
2019-05-08 19:52 ` Juri Linkov
2019-05-09 13:26 ` Dmitry Gutov
2019-05-09 19:41 ` Juri Linkov
2019-05-10 0:14 ` Dmitry Gutov
2019-05-10 7:56 ` Eli Zaretskii
2019-05-11 20:58 ` Juri Linkov
2019-05-13 0:32 ` Dmitry Gutov
2019-05-13 20:40 ` Juri Linkov
2019-05-13 21:21 ` Dmitry Gutov
2019-05-14 20:29 ` Juri Linkov
2019-05-15 0:34 ` Dmitry Gutov [this message]
2019-05-15 21:12 ` Juri Linkov
2019-05-15 22:05 ` Dmitry Gutov
2019-05-16 20:04 ` Juri Linkov
2019-05-19 20:11 ` Juri Linkov
2019-05-20 23:29 ` Dmitry Gutov
2019-05-21 20:12 ` Juri Linkov
2019-05-21 20:39 ` Dmitry Gutov
2019-05-21 21:32 ` Juri Linkov
2019-05-21 21:52 ` Dmitry Gutov
2019-05-22 21:52 ` Dmitry Gutov
2019-05-23 21:07 ` Juri Linkov
2019-05-24 1:29 ` Dmitry Gutov
2019-05-24 18:41 ` Juri Linkov
2019-05-27 15:26 ` Dmitry Gutov
2019-05-27 19:47 ` Juri Linkov
2019-06-10 0:57 ` Dmitry Gutov
2019-06-10 20:50 ` Juri Linkov
2019-06-10 22:19 ` Dmitry Gutov
2019-06-16 0:55 ` Dmitry Gutov
2019-06-16 20:13 ` Juri Linkov
2019-06-17 13:48 ` Dmitry Gutov
2019-06-17 20:42 ` Juri Linkov
2019-06-17 22:23 ` Dmitry Gutov
2019-05-20 23:39 ` Dmitry Gutov
2019-05-10 7:54 ` Eli Zaretskii
2019-05-08 6:01 ` Eli Zaretskii
2019-05-08 19:52 ` Juri Linkov
2019-05-10 7:51 ` Eli Zaretskii
2019-05-11 20:53 ` Juri Linkov
2019-05-12 2:36 ` Eli Zaretskii
2019-05-12 19:15 ` Juri Linkov
2019-05-13 14:24 ` Eli Zaretskii
2019-05-13 14:44 ` Dmitry Gutov
2019-05-13 15:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a4d3875-5cb5-bc84-c72e-d1840aa8d7c3@yandex.ru \
--to=dgutov@yandex.ru \
--cc=35624@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.