From: Jared Finder via "Emacs development discussions." <emacs-devel@gnu.org>
To: emacs-devel@gnu.org, aaronjensen@gmail.com
Subject: 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check
Date: Fri, 15 Jan 2021 22:33:47 -0800 [thread overview]
Message-ID: <5a359bd86b4af0378ed63f12670fd355@finder.org> (raw)
"4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 Fix 'window-text-pixel-size'
when there are leading/trailing spaces" adds some tests that don't run
correctly in my environment. The tests do run fine interactively.
The output log:
Test xdisp-tests--window-text-pixel-size backtrace:
make-terminal-frame(((parent-frame . #<frame F1 0x56424bb8b2c8>)))
tty-create-frame-with-faces(((parent-frame . #<frame F1 0x56424bb8b2
#f(compiled-function (params) #<bytecode 0x6b0cf7c833dbfd2>)(((paren
apply(#f(compiled-function (params) #<bytecode 0x6b0cf7c833dbfd2>) (
frame-creation-function(((parent-frame . #<frame F1 0x56424bb8b2c8>)
make-frame(((parent-frame . #<frame F1 0x56424bb8b2c8>)))
display-buffer-in-child-frame(#<killed buffer> nil)
display-buffer(#<killed buffer> (display-buffer-in-child-frame))
#f(compiled-function () #<bytecode -0x18c672b9d813486f>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name xdisp-tests--window-text-pixel-size :
ert-run-or-rerun-test(#s(ert--stats :selector (not (or ... ...)) :te
ert-run-tests((not (or (tag :expensive-test) (tag :unstable))) #f(co
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable)))
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":." "-l" "ert" "-l" "src/xdisp-tests" "--eval"
command-line()
normal-top-level()
Test xdisp-tests--window-text-pixel-size condition:
(error "Unknown terminal type")
xdisp-tests--window-text-pixel-size-leading-space and
xdisp-tests--window-text-pixel-size-trailing-space fail in the same way.
I don't know if these tests should just be marked expected to fail or
not.
-- MJF
next reply other threads:[~2021-01-16 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 6:33 Jared Finder via Emacs development discussions. [this message]
2021-01-16 6:38 ` 4dc72dd9deb1c3394ada3de3f52bc7c1ff831ab6 breaks make check Aaron Jensen
2021-01-16 8:42 ` Eli Zaretskii
2021-01-16 17:14 ` Aaron Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a359bd86b4af0378ed63f12670fd355@finder.org \
--to=emacs-devel@gnu.org \
--cc=aaronjensen@gmail.com \
--cc=jared@finder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.