remove -prebind on macOS?

remove -prebind on macOS?

[Robert Pluim]

Every time I build on macos I get a warning about the '-prebind' option
passed to LD. As far as I can tell, that option has been obsolete and
without effect since macOS 10.3. Can we remove it yet?

Robert

diff --git i/configure.ac w/configure.ac
index 7529719429..16491a95d5 100644
--- i/configure.ac
+++ w/configure.ac
@@ -5395,7 +5395,7 @@ AC_DEFUN
    else
      libs_nsgui=
    fi
-   LD_SWITCH_SYSTEM_TEMACS="-fno-pie -prebind $libs_nsgui -Xlinker -headerpad -Xlinker $headerpad_extra"
+   LD_SWITCH_SYSTEM_TEMACS="-fno-pie $libs_nsgui -Xlinker -headerpad -Xlinker $headerpad_extra"
 
    ## This is here because src/Makefile.in did some extra fiddling around
    ## with LD_SWITCH_SYSTEM.  It seems cleaner to put this in

Re: remove -prebind on macOS?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 111 bytes --]

On 1/30/19 4:39 AM, Robert Pluim wrote:
> Can we remove it yet?

Don't see why not. I installed the attached.


[-- Attachment #2: 0001-Stop-using-macOS-prebind-option.patch --]
[-- Type: text/x-patch, Size: 1121 bytes --]

From b19397df20806ccda902aca35354613414320e10 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Fri, 1 Feb 2019 08:45:20 -0800
Subject: [PATCH] Stop using macOS -prebind option

* configure.ac (LD_SWITCH_SYSTEM_TEMACS): Remove -prebind,
which has been obsolete and ineffective since Mac OS X 10.4 (2005),
which was never necessary for correct operation, and which now
generates annoying warnings.  Problem reported by Robert Pluim in:
https://lists.gnu.org/r/emacs-devel/2019-01/msg00761.html
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 7529719429..16491a95d5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5395,7 +5395,7 @@ AC_DEFUN
    else
      libs_nsgui=
    fi
-   LD_SWITCH_SYSTEM_TEMACS="-fno-pie -prebind $libs_nsgui -Xlinker -headerpad -Xlinker $headerpad_extra"
+   LD_SWITCH_SYSTEM_TEMACS="-fno-pie $libs_nsgui -Xlinker -headerpad -Xlinker $headerpad_extra"
 
    ## This is here because src/Makefile.in did some extra fiddling around
    ## with LD_SWITCH_SYSTEM.  It seems cleaner to put this in
-- 
2.20.1