all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* vc-next-action delete files from ready-for-commit incorectly
@ 2008-07-25  9:15 Alex Harsanyi
  0 siblings, 0 replies; only message in thread
From: Alex Harsanyi @ 2008-07-25  9:15 UTC (permalink / raw)
  To: Emacs Devel

Hi,

Before commiting a fileset, `vc-next-action' will revert all the  
unchanged files form the changeset and remove them from the `read-for- 
commmit' list.  Unfortunately it uses the `delete' function  
incorrectly, leaving the reverted file in the list if it is the first  
one.  The patch below contains a fix for the problem:

--- vc.el	25 Jul 2008 17:08:11 +0800	1.698
+++ vc.el	25 Jul 2008 17:10:35 +0800	
@@ -1085,7 +1085,7 @@ merge in the changes into your working c
  			 ;; finishing the log entry and committing.
  			 (not (and visited (buffer-modified-p))))
  		(vc-revert-file file)
-		(delete file ready-for-commit)))))
+		(setq ready-for-commit (delete file ready-for-commit))))))
  	;; Remaining files need to be committed
  	(if (not ready-for-commit)
  	    (message "No files remain to be committed")

Best Regards,
Alex.




^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-07-25  9:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-25  9:15 vc-next-action delete files from ready-for-commit incorectly Alex Harsanyi

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.