From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: Redisplay: NS port, high CPU load Date: Tue, 14 Jun 2016 20:07:01 +0800 Message-ID: <5EBA241B-68F8-4A4D-BEAD-66EACD20333E@gmail.com> References: <9793F9E3-979A-4888-8662-F6E0C27C8B37@gmail.com> <20160608195552.GA66865@breton.holly.idiocy.org> <7B0CAF99-689D-4128-8E33-7D9BA8F1823E@gmail.com> <41E503B6-5048-4E20-92CE-1FAD4C05A279@gmail.com> <525668A8-4B0E-4791-A423-F1D4903F4511@gmail.com> <83lh2dpetr.fsf@gnu.org> <83fuslpclx.fsf@gnu.org> <62E0B0C4-4D9B-4E1C-ACE5-06E674C8A342@gmail.com> <837fdsgarj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1465906227 21580 80.91.229.3 (14 Jun 2016 12:10:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 14 Jun 2016 12:10:27 +0000 (UTC) Cc: Alan Third , Anders Lindgren , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 14 14:10:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCn98-0003iV-W6 for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 14:08:43 +0200 Original-Received: from localhost ([::1]:34716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCn97-0003GB-R9 for ged-emacs-devel@m.gmane.org; Tue, 14 Jun 2016 08:08:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCn7q-0001q4-2w for emacs-devel@gnu.org; Tue, 14 Jun 2016 08:07:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCn7o-0000gU-01 for emacs-devel@gnu.org; Tue, 14 Jun 2016 08:07:20 -0400 Original-Received: from mail-pf0-x22f.google.com ([2607:f8b0:400e:c00::22f]:35800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCn7i-0000fH-W8; Tue, 14 Jun 2016 08:07:15 -0400 Original-Received: by mail-pf0-x22f.google.com with SMTP id c2so56973773pfa.2; Tue, 14 Jun 2016 05:07:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=v1bp1Pmn4MHm7Qa/DB0fyK2TcIze/3EXX49CaoIZAFA=; b=t2Xy1jDVa5ul+lln7awoiRlzi7dvxqWaQCsG7fOB8XeSSxJMhb3N2UOgnEMpgVGZRG 9BeDwMOOcEq0CEYNNcZqKPdyGozC8+kGfd9dRqV5tYEVoSk58qNmZZGXwbYO8C19Ixfk ZzJo2r0pCah+P26ZtNajAC7ExBZRgS8gD+z+k56uP3+1gywe2gkLQtuxnvmEd8xhtiDB UiPGdyOX0zgrXOJ9cjQUHnw3IPtS9QXoQ2v0PBoOEl3PESbBrG9osFRkKha/6Hjpbx+b /Xx+dkx+pTqpbUsthifYC9bsvuiBKA12M/laZM1BaWzAD425jMgXNVe8vmupSWsL3P9Y Ey2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=v1bp1Pmn4MHm7Qa/DB0fyK2TcIze/3EXX49CaoIZAFA=; b=EAWYvNC9RRHJ46lYxKawM2FJdxY3T8bfbN91ksoDmsCGNgkGjXGFAxfLO7NmgRrHBx XjAoONFR/PHW7uMAJNtDetOw77wngB0ESL8qmOkvcp9bbMDjp3oOnR1oMhMS69hUxjK8 GkFPAneJrEqvKuts2CZauyf5osIwBTGZhjVjzz5TrNZdDWM2OYveUCfEj8Ok1Obd5VqJ FNAvK1OqyqTCm6ogin1lDO8wvoBd0RSv5amZgV6iOlzmoGGjgjlPSLG8J2regWkVv+Vc 1Qo6BKtE4781GL3/s9V8mWHQdWCD1AIZur/1O0vuL9PxaUuu3vYI2HNjm4wWZlvUcyRY lffw== X-Gm-Message-State: ALyK8tJ6erTY2mPxiJavvOMvBN5lhsROaJGlGHY7Bkf8fn/R7l1rVzTIHfuxfOlH8XgBAg== X-Received: by 10.98.76.211 with SMTP id e80mr3354809pfj.28.1465906033071; Tue, 14 Jun 2016 05:07:13 -0700 (PDT) Original-Received: from [192.168.1.13] ([180.249.130.40]) by smtp.gmail.com with ESMTPSA id t24sm40863257pfj.75.2016.06.14.05.07.08 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 14 Jun 2016 05:07:12 -0700 (PDT) In-Reply-To: <837fdsgarj.fsf@gnu.org> X-Mailer: Apple Mail (2.3124) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400e:c00::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204354 Archived-At: On Jun 14, 2016, at 3:16 AM, Eli Zaretskii wrote: > David said that it didn't happen in "emacs -Q", but did happen in his > normal setup, and AFAIU intended to come up with a recipe. OK, I looked into this. I don=E2=80=99t have time right now for a = recipe, but what=E2=80=99s happening is that I=E2=80=99m loading (my = version of) tabbar.el, which does this: (add-hook 'first-change-hook 'tabbar-window-update-tabsets-when-idle) Only when first-change-hook is set are those extraneous toolbar = refreshes made. The tabbar-window-update function at some point calls = (force-window-update (window-buffer)), which may be what triggers the = toolbar refresh. So, I think that we should think about disabling hooks such as = buffer-list-update-hook, first-change-hook, kill-buffer-hook, for = temporary buffers. In my view it just does not make sense to run the = hooks for temporary buffers in any sensible scenario. I also think that this change might affect some modes, if only by = triggering bugs. Therefore I would argue that the change to = ucs-normalize is the minimal change to fix my bug, and a good = housekeeping change in general.