From: David Reitter <david.reitter@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Alan Third <alan@idiocy.org>, Anders Lindgren <andlind@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Redisplay: NS port, high CPU load
Date: Tue, 14 Jun 2016 20:07:01 +0800 [thread overview]
Message-ID: <5EBA241B-68F8-4A4D-BEAD-66EACD20333E@gmail.com> (raw)
In-Reply-To: <837fdsgarj.fsf@gnu.org>
On Jun 14, 2016, at 3:16 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> David said that it didn't happen in "emacs -Q", but did happen in his
> normal setup, and AFAIU intended to come up with a recipe.
OK, I looked into this. I don’t have time right now for a recipe, but what’s happening is that I’m loading (my version of) tabbar.el, which does this:
(add-hook 'first-change-hook 'tabbar-window-update-tabsets-when-idle)
Only when first-change-hook is set are those extraneous toolbar refreshes made. The tabbar-window-update function at some point calls (force-window-update (window-buffer)), which may be what triggers the toolbar refresh.
So, I think that we should think about disabling hooks such as buffer-list-update-hook, first-change-hook, kill-buffer-hook, for temporary buffers. In my view it just does not make sense to run the hooks for temporary buffers in any sensible scenario.
I also think that this change might affect some modes, if only by triggering bugs. Therefore I would argue that the change to ucs-normalize is the minimal change to fix my bug, and a good housekeeping change in general.
next prev parent reply other threads:[~2016-06-14 12:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 6:04 Redisplay: NS port, high CPU load David Reitter
2016-06-08 7:50 ` Anders Lindgren
2016-06-08 10:44 ` David Reitter
2016-06-08 19:55 ` Alan Third
2016-06-08 20:12 ` David Reitter
2016-06-09 1:03 ` David Reitter
2016-06-09 8:22 ` David Reitter
2016-06-09 9:25 ` Anders Lindgren
2016-06-09 13:04 ` David Reitter
2016-06-09 14:11 ` Anders Lindgren
2016-06-09 18:03 ` David Reitter
2016-06-09 18:52 ` Anders Lindgren
2016-06-09 23:03 ` David Reitter
2016-06-10 6:02 ` Anders Lindgren
2016-06-10 8:16 ` David Reitter
2016-06-10 9:34 ` Eli Zaretskii
2016-06-10 9:46 ` David Reitter
2016-06-10 10:22 ` Eli Zaretskii
2016-06-10 10:36 ` David Reitter
2016-06-13 18:44 ` Anders Lindgren
2016-06-13 19:16 ` Eli Zaretskii
2016-06-14 12:07 ` David Reitter [this message]
2016-06-14 17:02 ` Eli Zaretskii
2016-06-15 3:55 ` Stefan Monnier
2016-06-14 11:50 ` David Reitter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5EBA241B-68F8-4A4D-BEAD-66EACD20333E@gmail.com \
--to=david.reitter@gmail.com \
--cc=alan@idiocy.org \
--cc=andlind@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.