From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= Newsgroups: gmane.emacs.bugs Subject: bug#68756: Uninstalling emacs does not remove Start Menu entries created during the installation Date: Thu, 15 Feb 2024 18:27:17 +0000 Message-ID: <5E06E817-4C3F-42F1-8901-73DA5A069CB9@aegee.org> References: <37a30898d11190e4e6e03faafecde143d90b7d9d.camel@aegee.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=----5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38676"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: K-9 Mail for Android Cc: 68756@debbugs.gnu.org, 67667@debbugs.gnu.org To: Corwin Brust , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 15 19:28:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ragSx-0009pa-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Feb 2024 19:28:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ragSb-0004wl-7v; Thu, 15 Feb 2024 13:27:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ragSW-0004wT-Cr for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 13:27:44 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ragSW-0000WF-4s for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 13:27:44 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ragSo-0003SD-RU for bug-gnu-emacs@gnu.org; Thu, 15 Feb 2024 13:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD_?= =?UTF-8?Q?=D0=9F=D0=B0=D0=BB=D0=B0=D1=83=D0=B7=D0=BE=D0=B2?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Feb 2024 18:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68756 X-GNU-PR-Package: emacs Original-Received: via spool by 68756-submit@debbugs.gnu.org id=B68756.170802168013261 (code B ref 68756); Thu, 15 Feb 2024 18:28:02 +0000 Original-Received: (at 68756) by debbugs.gnu.org; 15 Feb 2024 18:28:00 +0000 Original-Received: from localhost ([127.0.0.1]:57004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ragSl-0003Rj-Cy for submit@debbugs.gnu.org; Thu, 15 Feb 2024 13:28:00 -0500 Original-Received: from mail.aegee.org ([144.76.142.78]:33128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ragSh-0003RH-5g; Thu, 15 Feb 2024 13:27:56 -0500 Authentication-Results: mail.aegee.org/41FIROwJ3977909; auth=pass (PLAIN) smtp.auth=didopalauzov@aegee.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=aegee.org; s=k4096; t=1708021645; i=dkim+MSA-ssl@aegee.org; bh=pch9I7uJrjnlF0HgKgdC8sJfzUOVyLEFk0ImVFci6mE=; h=Date:From:To:CC:Subject:In-Reply-To:References; b=Bp0pvxTraTUQTw3yguRatVuez3D/LzkibCQoTrhd+yeOWZYEV/OoeEKAamdC/zcHB rnT4NyFSn+VPl0okpjQPhcbE7mmnn5o4H8VuA7+U9guOlbK0QEgFWvCsY454wb8/ua u6+YofqVGtxopoRuoepa36ClcEP9BmXY6/CbLF4cXHshiHq5+yT/I0g1D+A9mHA7tE 5MnuUELJLM5MPci66MfCEYYbC8FycwyUmNhtkv7CmhHa+qINcq7kFlI3RXKyP3tdyg lYkVWTcPbcSVJosmKFVf6NnnUBojrJxdpDQCjf42dQXWYU/YiyuX69P+v1jkLrWZK/ CTtwVbFwWfsgfa5olueb9SqayKlYjDdW65Kk2buEoKjc94DHEt71RTk07APzXm/ZXJ uFnjjcHRsLvVtAamLUM0ybjn15pTJi+MHCgLRqhu30iuaKKtFy1qqSF/LJIcBwziD0 RAhk/hfOvxc2KOc8nFR+7425LgpEL8YDfwS9+DYX6T/OKmhQ14gKcP0I4Fe0wzERud s7as+NIzjmrBOBr+FU+mDha7IVKih37+DxO2jxh6/xixlr3R1qqO+15QNvPSlrcFIW Ylxp9dmLZuO+dPfoNmPF95rPrbM1rG7POxZQxoPfvBjmGnHkOc2QIq4HvIVNWjQ//u z Authentication-Results: mail.aegee.org/41FIROwJ3977909; dkim=none Original-Received: from [127.0.0.1] (x527162f2.dyn.telefonica.de [82.113.98.242] (may be forged)) (authenticated bits=0) by mail.aegee.org (8.17.2/8.17.2) with ESMTPSA id 41FIROwJ3977909 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 15 Feb 2024 18:27:25 GMT In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280071 Archived-At: ------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello Corwin, before installing emacs-29=2E2=2E50_bug#58756-installer=2Eexe I have insta= lled emacs-29=2E2-installer=2Eexe =2E The latter has created a Start Menu g= roup emacs 29=2E2 with two icons - emacs and uninstall=2E After installing = emacs-29=2E2=2E50_bug#58756-installer=2Eexe it creates separate Start Menu = directory 29=2E2=2E50=2E The Start menu Emacs 29=2E2/uninstall disappears= =2E After clicking Start Menu/emacs 29=2E2=2E50/uninstall the entry Emacs 2= 9=2E2/uninstall appears again, but it is now dysfunctional=2E Apart from th= is, uninstalling 29=2E2=2E50 does remove the Start Menu entries it has crea= ted=2E I cannot test if two different versions work during install/uninstal= l as expected, since I have no two different versions which are at the same= time =E2=80=9Cfixed=E2=80=9D=2E Kind regards =D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20 =D0=9D=D0=B0 11 =D1=84=D0=B5=D0=B2=D1=80=D1=83=D0=B0=D1=80=D0=B8 2024 =D0= =B3=2E 22:56:17 UTC, Corwin Brust =D0=BD=D0=B0=D0=BF=D0= =B8=D1=81=D0=B0: >tags 68756 + patch >thanks > >=D0=94=D0=B8=D0=BB=D1=8F=D0=BD, I have created an installer based on the= attached patch and >posted it to my own site=2E If you try that out please let me know what >you think=2E > >https://bru=2Est/i/emacs-29=2E2=2E50_bug%2358756-installer=2Eexe > >Note, this is based on the "tip" of the emacs-29 branch, and not built >from the release sources for no other reason than expediency: I am >running a CI locally so I can easily test changes to the NSI installer >without (especially) compiling other things=2E And that also means I'm >quite open to trying things, if we come up with more adventurous >changes than those proposed here=2E > >Reprising your original expectations: > >> =E2=80=A2 Uninstalling emacs should remove the Start Menu directories, = created during installing emacs=2E > >This is fixed, I believe, however a bug remains (I will file a new bug >given we wind up taking things in pieces, as I'm suggesting): >customizing the name of the Start Menu folder isn't working for me >with or without this patch=2E Meanwhile: > >> =E2=80=A2 Installing emacs should ask to first remove the previously in= stalled emacs version, as long as it does not do inplace upgrade (substitut= ion)=2E > >Per this patch I did not add any Sections or controls, however a given >uninstaller will no-longer delete any other versions beside the one it >installed=2E > >I am open to better and more dramatic changes, but I think it might >make sense to work in stages, perhaps under quite granular bug >reports=2E In any event, I expect to "work my way up" to any more >complex changes needed to the NSI script incrementally=2E > >Stefan, > >I think the attached minimal change, plus the other patch for not >needing to "accept" licensing in 67667 (which tracker I've added in >CC), would be a good basis for making a 29=2E2_2=2E Ideally, we could >push these two and then I will create a 29=2E2_2 set=2E From there, I'll >probably focus on improving things for the 30=2E1 series pre-tests >notwithstanding "show stoppers" with the top-of-stack 29=2Ex binaries=2E >I can work on (each of) this smaller changes as much as needed, but >I'd like to keep the installer simple while we do=2E (E=2Eg=2E defer addi= ng >any new Sections/pages or controls we can live without until Emacs >30=2E) > >As an example of something not addressed by the patch, only the mostly >recently installed Emacs can be uninstalled=2E To address that will >require giving each uninstaller a unique name as part of creating it >under the installation target directory=2E I'm fairly confident I'll >get that right, but I'm not as confident as I am of the one attached=2E >Moreover, I would prioritize fixing the issue of (potentially) >deleting several installed versions without mentioning (which, =D0=94=D0= =B8=D0=BB=D1=8F=D0=BD, >thank you again for reporting that that is happening)=2E > > >Corwin ------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable
Hello Corwin,

before inst= alling emacs-29=2E2=2E50_bug#58756-installer=2Eexe I have installed emacs-2= 9=2E2-installer=2Eexe =2E The latter has created a Start Menu group emacs 2= 9=2E2 with two icons - emacs and uninstall=2E After installing emacs-29=2E2= =2E50_bug#58756-installer=2Eexe it creates separate Start Menu directory 29= =2E2=2E50=2E The Start menu Emacs 29=2E2/uninstall disappears=2E After clic= king Start Menu/emacs 29=2E2=2E50/uninstall the entry Emacs 29=2E2/uninstal= l appears again, but it is now dysfunctional=2E Apart from this, uninstalli= ng 29=2E2=2E50 does remove the Start Menu entries it has created=2E I canno= t test if two different versions work during install/uninstall as expected,= since I have no two different versions which are at the same time =E2=80= =9Cfixed=E2=80=9D=2E

Kind regards
=C2=A0 =D0=94=D0=B8=D0=BB=D1=8F= =D0=BD


=D0=9D=D0= =B0 11 =D1=84=D0=B5=D0=B2=D1=80=D1=83=D0=B0=D1=80=D0=B8 2024 =D0=B3=2E 22:5= 6:17 UTC, Corwin Brust <corwin@bru=2Est> =D0=BD=D0=B0=D0=BF=D0=B8=D1= =81=D0=B0:
tags 68756 + patch
thanks
=D0=94=D0=B8=D0=BB=D1=8F=D0=BD,  I have created an installer based on the=
 attached patch and
posted it to my own site=2E  If you try that out ple=
ase let me know what
you think=2E

https://bru=2Est/i/emacs-29=
=2E2=2E50_bug%2358756-installer=2Eexe

Note, this is based on the=
 "tip" of the emacs-29 branch, and not built
from the release sources fo=
r no other reason than expediency: I am
running a CI locally so I can ea=
sily test changes to the NSI installer
without (especially) compiling ot=
her things=2E  And that also means I'm
quite open to trying things, if w=
e come up with more adventurous
changes than those proposed here=2E
<=
br>Reprising your original expectations:

=E2=80=A2 Uninstalling emacs =
should remove the Start Menu directories, created during installing emacs=
=2E

This is fixed, I believe, h=
owever a bug remains (I will file a new bug
given we wind up taking thin=
gs in pieces, as I'm suggesting):
customizing the name of the Start Menu=
 folder isn't working for me
with or without this patch=2E  Meanwhile:
=E2=80=A2 Installing emacs should ask to first remove the previously in=
stalled emacs version, as long as it does not do inplace upgrade (substitut=
ion)=2E

Per this patch I did no=
t add any Sections or controls, however a given
uninstaller will no-long=
er delete any other versions beside the one it
installed=2E

I am =
open to better and more dramatic changes, but I think it might
make sens=
e to work in stages, perhaps under quite granular bug
reports=2E  In any=
 event, I expect to "work my way up" to any more
complex changes needed =
to the NSI script incrementally=2E

Stefan,

I think the attach=
ed minimal change, plus the other patch for not
needing to "accept" lice=
nsing in 67667 (which tracker I've added in
CC), would be a good basis f=
or making a 29=2E2_2=2E  Ideally, we could
push these two and then I wil=
l create a 29=2E2_2 set=2E  From there, I'll
probably focus on improving=
 things for the 30=2E1 series pre-tests
notwithstanding "show stoppers" =
with the top-of-stack 29=2Ex binaries=2E
I can work on (each of) this sm=
aller changes as much as needed, but
I'd like to keep the installer simp=
le while we do=2E (E=2Eg=2E defer adding
any new Sections/pages or contr=
ols we can live without until Emacs
30=2E)

As an example of somet=
hing not addressed by the patch, only the mostly
recently installed Emac=
s can be uninstalled=2E  To address that will
require giving each uninst=
aller a unique name as part of creating it
under the installation target=
 directory=2E  I'm fairly confident I'll
get that right, but I'm not as =
confident as I am of the one attached=2E
Moreover, I would prioritize fi=
xing the issue of (potentially)
deleting several installed versions with=
out mentioning (which, =D0=94=D0=B8=D0=BB=D1=8F=D0=BD,
thank you again f=
or reporting that that is happening)=2E


Corwin
------5CO3JWEBLHFV1JDDIT0UD5UW7RVVYQ--