From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#12694: 24.2.50; `file-cache-add-file(-list)' commands Date: Sat, 20 Oct 2012 15:44:26 -0700 Message-ID: <5D93535BCDA54EA9BF30475E92222D4C@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1350773133 24134 80.91.229.3 (20 Oct 2012 22:45:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Oct 2012 22:45:33 +0000 (UTC) To: 12694@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 21 00:45:41 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TPhnU-0006Q3-5P for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Oct 2012 00:45:36 +0200 Original-Received: from localhost ([::1]:48918 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhnM-0000gp-Q8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 20 Oct 2012 18:45:28 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhnK-0000gk-DS for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPhnJ-0000bg-C3 for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhnJ-0000bc-8P for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:25 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TPhos-0006Rx-AE for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 20 Oct 2012 22:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 12694 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.135077321224775 (code B ref -1); Sat, 20 Oct 2012 22:47:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Oct 2012 22:46:52 +0000 Original-Received: from localhost ([127.0.0.1]:53550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPhoh-0006RX-DN for submit@debbugs.gnu.org; Sat, 20 Oct 2012 18:46:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:48877) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TPhoe-0006RK-FL for submit@debbugs.gnu.org; Sat, 20 Oct 2012 18:46:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPhmy-0000R5-L9 for submit@debbugs.gnu.org; Sat, 20 Oct 2012 18:45:05 -0400 Original-Received: from lists.gnu.org ([208.118.235.17]:58493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhmy-0000Qn-IM for submit@debbugs.gnu.org; Sat, 20 Oct 2012 18:45:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhmx-0000bl-Il for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TPhmw-0000OA-6x for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:03 -0400 Original-Received: from rcsinet15.oracle.com ([148.87.113.117]:42928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TPhmv-0000Lt-WB for bug-gnu-emacs@gnu.org; Sat, 20 Oct 2012 18:45:02 -0400 Original-Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q9KMixr7026005 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 20 Oct 2012 22:44:59 GMT Original-Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q9KMiw3l025183 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 20 Oct 2012 22:44:59 GMT Original-Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q9KMiw8R006451 for ; Sat, 20 Oct 2012 17:44:58 -0500 Original-Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 20 Oct 2012 15:44:58 -0700 X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac2vFHVrBMKsRSn8TM+K+dWobhr/kQ== X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:65800 Archived-At: 1. These two commands are not documented along with the others, in the Emacs manual. Fair enough, if they are not deemed useful enough. Just mentioning this here in case it was overlooked. 2. Doc string of `file-cache-add-file-list': a. Typo: "files names" -> "file names". b. The doc string should say that the input you provide is read as a Lisp sexp and evaluated to produce a list of (absolute?) file names. Otherwise users of the command will have no idea what to type! IOW, users do not see the `X' `interactive' spec, and the implementation of that spec provides no runtime help to users (AFAIK). 3. A cursory scan of the code suggests that the behavior might not be correct if you input a relative file name to `file-cache-add-file-list'. If you do that, directory of nil is recorded for the file, and I'm guessing that is incorrect (?). If so, then `file-cache-add-file-list' should, for example, expand the name relative to the default directory. If it is not incorrect, then #2 above should mention that your input can be an absolute or a relative file name, and it should explain what the interpretation of a relative file name is. IOW, how does the code use an element of `file-cache-alist' that looks like this: ("foo.el" nil)? Does it interpret the nil at runtime (i.e., during completion) as the default directory? Just what does it do? If a user doesn't know what form the input must take then s?he cannot use the command. To know that means to know something about the _treatment_ of an entry like ("foo.el" nil) (even if it does not imply that that form need be known to users), which form is allowed today (but whose behavior doesn't seem to be described anywhere). 4. `file-cache-add-file': Why does the file need to exist for interactive use? Why not let users add names of files that do not yet exist? In any case we provide a message for such a case. That message is used currently only when NOT interactive, which seems wrong in itself. Code executed non-interactively has little use for messages. (Of course, if the function is called from a command that is itself invoked interactively then showing the message might make sense.) In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600) of 2012-10-15 on DANI-PC Bzr revision: 110553 monnier@iro.umontreal.ca-20121015164957-6zms5w2js1xkldtg Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -I../../libs/libxpm-3.5.8/include -I../../libs/libxpm-3.5.8/src -I../../libs/libpng-1.4.10 -I../../libs/zlib-1.2.6 -I../../libs/giflib-4.1.4-1/include -I../../libs/jpeg-6b-4/include -I../../libs/tiff-3.8.2-1/include -I../../libs/libxml2-2.7.8-w32-bin/include/libxml2 -I../../libs/gnutls-3.0.16/include -I../../libs/libiconv-1.14-2-mingw32-dev/include'