From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#34765: 26.1; with-temp-buffer should not run buffer-list-update-hook Date: Thu, 07 Mar 2019 14:46:00 +0100 Message-ID: <5C812098.8020907@gmx.at> References: <939238bc-16a0-6679-bc80-043e0530f61e@web.de> <5C80D66E.5000101@gmx.at> <9acc3402-312f-0c3b-c2aa-4d1e2bcb77d4@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="264596"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34765@debbugs.gnu.org To: Alexander Miller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 07 14:49:26 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h1tOm-0016do-1U for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 14:49:24 +0100 Original-Received: from localhost ([127.0.0.1]:52038 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1tOk-0003aA-Pe for geb-bug-gnu-emacs@m.gmane.org; Thu, 07 Mar 2019 08:49:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h1tMV-0002F2-O4 for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 08:47:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h1tMU-0004Um-TI for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 08:47:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49739) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h1tMU-0004UH-1a for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 08:47:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h1tMT-0007de-L4 for bug-gnu-emacs@gnu.org; Thu, 07 Mar 2019 08:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Mar 2019 13:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34765 X-GNU-PR-Package: emacs Original-Received: via spool by 34765-submit@debbugs.gnu.org id=B34765.155196637829314 (code B ref 34765); Thu, 07 Mar 2019 13:47:01 +0000 Original-Received: (at 34765) by debbugs.gnu.org; 7 Mar 2019 13:46:18 +0000 Original-Received: from localhost ([127.0.0.1]:35050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1tLl-0007cj-MI for submit@debbugs.gnu.org; Thu, 07 Mar 2019 08:46:17 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:54231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h1tLj-0007cW-Hf for 34765@debbugs.gnu.org; Thu, 07 Mar 2019 08:46:16 -0500 Original-Received: from [192.168.1.101] ([212.95.5.145]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lmqxo-1gaYou2T52-00h3iu; Thu, 07 Mar 2019 14:46:08 +0100 In-Reply-To: <9acc3402-312f-0c3b-c2aa-4d1e2bcb77d4@web.de> X-Provags-ID: V03:K1:gfjXDSUvy2X50yvHU9BKNgXYTw6jJOwvmzvMk/9/SMEM3mLaZbZ jnuBG8pi0PEnzfFoKxQRs+47lnkY6PiBLNJM5w5zwpncSBV/WPlSZaKVVvi7D1gNiFAXuv3 2eaXeHfh1S6eGl/+bFkiiJwxvRrjHxM6RYK80ul7/Xd6pTeWc6b+RbQGJc/lxuk4IwbAB3q CqFSudcHZlGFqWpMnFiAA== X-UI-Out-Filterresults: notjunk:1;V03:K0:MI6UJQq0jeY=:tVyIfViySgM0UH9ydwHPdY qe5znQT4UQlKQ1EmDim0bV9TVBCgJz04b1/d6UsDnuD0zVyeP2biNwJWiC7eQwKID0v3bVZH3 rDFEVRoB34szxL+v/mw/aI2JkzdcKGT+Ub/aoWdA++YUbHdgRVEoZ99EXIXvZl8DxFFPV0wpj JBtss55EqEqLGeJTjqZQXOMo6oHg47sraCKJMv7BdfG7iFSynyoW0BK4TGKnpqzGtQfW76njZ HImr4LMAy/DswWnAClby+0Z/Rwy/x14r63Sim26/ETEow4W6SCidKJbtFsKxjSsKvnPdQ91jU zL5jLGX9WQbFT+nHGmSKqifeu3jHhNhxNWu0wkMQ0VOTWZEuPUUPU3yWF0jyfqX0m+aRjsOYH h9UPpBLQFz291M0bLtXqbZddx8NZrY85JNBeceppA1S1G1H6IGcg6r/zPBGd7haLRb20VKwk5 pGazcVsOCD26Ppyx02A+43Y+1GQUvaWw/eKcif9DE+aIAbsWKHxM6S+v1zmFvJhYCFXPxjtMs CQhX6TPGKRVJHicGXhlXQ2l4o5nqQzFHztPRiAGX7VmQCUNdZnS7mKrwi7fgXmT4VgxDINemw 32Csi+xjbqXgV+cO+KyGRj9iTUT3W9maANZgAkMIZ6gEhfSat/up28oCCdIxAzj6+y5zjE4Hu EuewWsT9NSdOsr2n1y4XfE+BJ1S3o/6XAuUlxMPKV8Zu8IAG5tYhDpuO2mFdgZu0bV6JZQ7vp NKr9Y/RQa4wLPw/1f5awyciuaUajumBx7sv8TJN8DW9Ww12mFPCMjL3pE2G6lq9JUZeu2wK9 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156120 Archived-At: > As I understand it: advising select-window served the purpose of > remembering the > current window so the modeline can be highlighted in tune with the > selection. The > advising code would also call force-mode-line-update, that in turn lead > to a re-calculation > of the frame title, in spacemacs this could in turn call format-spec, > that would use a > temp-buffer, that triggers buffer-list-update-hook, that triggers > treemacs' follow-mode > callback, that calls with-selected-window, that leads back to the > modeline's select-window > advice. That's more or less what the feedback loop looked like. Thanks. IIUC this means that we'll have to put an extra warning in the doc-string of 'buffer-list-update-hook' to not kill, rename or create buffers or select another window with NORECORD nil in its functions. I listed all functions calling that hook in the hope that people would then avoid that but your example shows that such endless recursions can be quite tricky to detect. One major design goal of the new window change functions was to simply not invoke them recursively so such scenarios should not happen there (and was immediately proven wrong by the redisplay mechanism itself). > > Can you pass me a corresponding URL? > > Did that already, Here it is again: > https://github.com/magit/magit/issues/3738#issuecomment-464520582 I thought you had another one (with more insight into how that problem triggered). But the scenario above is sufficient to imagine what can happen ... martin