From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#34317: 26.1.90; Wrong unbinding order in x_consider_frame_title Date: Sun, 24 Feb 2019 09:43:09 +0100 Message-ID: <5C72591D.40301@gmx.at> References: <5C588952.1080706@gmx.at> <5C6BC758.8040105@gmx.at> <83tvguq1q5.fsf@gnu.org> <5C7151FF.5070504@gmx.at> <83mummpi53.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="240444"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 34317@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 24 09:44:20 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxpOW-0010K5-9k for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 09:44:20 +0100 Original-Received: from localhost ([127.0.0.1]:47901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxpOV-0008An-CQ for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Feb 2019 03:44:19 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50351) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxpOJ-0008AW-Rk for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 03:44:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxpOH-0000mk-TY for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 03:44:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36276) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxpOE-0000iW-Fj for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 03:44:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxpOE-0007Lq-9T for bug-gnu-emacs@gnu.org; Sun, 24 Feb 2019 03:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Feb 2019 08:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34317 X-GNU-PR-Package: emacs Original-Received: via spool by 34317-submit@debbugs.gnu.org id=B34317.155099780128180 (code B ref 34317); Sun, 24 Feb 2019 08:44:02 +0000 Original-Received: (at 34317) by debbugs.gnu.org; 24 Feb 2019 08:43:21 +0000 Original-Received: from localhost ([127.0.0.1]:49817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxpNZ-0007KR-Io for submit@debbugs.gnu.org; Sun, 24 Feb 2019 03:43:21 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:45705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxpNX-0007KC-11 for 34317@debbugs.gnu.org; Sun, 24 Feb 2019 03:43:19 -0500 Original-Received: from [192.168.1.101] ([213.162.73.91]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MfF6I-1gdO3O1ciY-00OorO; Sun, 24 Feb 2019 09:43:12 +0100 In-Reply-To: <83mummpi53.fsf@gnu.org> X-Provags-ID: V03:K1:LSyu5Fmoy3Jrh20t1RnZGPzyUkdZsZrUrO6UAj9yz15UuVAenoY gPw8c2qav3VgRXMTobB0lplNzWj/SfKabixk8tT2MvNVZt6SneWZlkiIWaJlvHfnwwqyhK/ gVsdwagH/xUv04v2WNCEqY6H4tkY0pAlIpigkDHUXFJxeLErYMejtNmHc34tXVziLvkI+rH OaQ3DjnVXhH0iKxhWgpxQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:Pz754gkypjY=:M3Uvn/EUuaoOBOuCbGkwnj 7eP2FgbXQbKd63rlsPXJ+vxcpgISblFM0Ljk+NN49nR0e9iGmbJcN8zE+JU+nzgx+HsEh0fhc RCBS2mFjXotoO990vgXdtMKaiNklo5lkgjWRLLq/gcbLugikzK3Xne7lmzmnxi5HGce8AbKv0 f2d+8lfvBXv+MdjVwtw7FdOydTA1F7ayztp2W3o5Syr1qdX9z4V4WRnxmqr0db8sgkuVD0evd Hhy0isSwNom1mmf1Bu2/wkk+b/3hj/oWwvFStH+sLNAMxcXwHTaJro6olee2YC/kxbxkyJqSs VD5BggSJWjnbyld+tL6cWzrEKL84XXJsHtb2nBXXLna/R1ZTNzRlIVBXY+yRZmuvBiL9AdVnd ChrtQ0g3vZMU73tRePNHKGd9x++ikmF5vPG9+PIhmZD/Thwdo68+1cD9CNd9PEGByVfSVnfLZ ei+sWmJsCGMz5zBfK5lcHvWismz6WnPf8tAFlveCbnUtDPHrO25pttKVyxIxR5EJoT74oKASj q8DmedTrkDASCY0Mv/rS/PHx2IMxB45BIXUz1IsCEvPEPMwuuN+Rg1lcFV8KFvyoKyYZyCqtk qrVA0eUZ65FbWwSfA+Q9t9R+VO++DmuyP3ESwXCJrfJe3UjILGQewpohT6zAYwvO0KQwl96Pi Z+wPD/i7ckNEBwHg6PpNcosL9/eFBRsYofgeXU4YJtkEtK0aOQzTzDVVOtupmM+eUgCHy1WCk efpRukfOe08nR3PkrGKuSnUkSKyUUQ7zsAX303G21Vd5w9rY/TDysF4M4r+IwjtqwN3hxlst X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155707 Archived-At: >> first of all I'd like to know whether your change was intentionally >> asymmetric (if so, why?), experimentally asymmetric (which >> experiments did you conduct?), or accidentally so (it's rather >> atypical of you to install asymmetric behavior and not document it). > > I didn't realize we were discussing my change. Which change was that? commit 821ea144bd446268fbe4a4a4775a06da52dea8cb Display mini-window resized even when there are several frames * src/xdisp.c (x_consider_frame_title): Bind inhibit-redisplay to t to avoid resizing back the mini-window as result of considering the title of other frames. (Bug#24285) (redisplay_window): No need to bind inhibit-redisplay here. This means that in x_consider_frame_title we now do ptrdiff_t count = SPECPDL_INDEX (); ... record_unwind_protect (unwind_format_mode_line, format_mode_line_unwind_data (f, current_buffer, selected_window, false)); ... specbind (Qinhibit_redisplay, Qt); Fselect_window (f->selected_window, Qt); ... unbind_to (count, Qnil); where unwind_format_mode_line does Fselect_window (old_window, Qt); The asymmetry I mentioned is that while binding Qinhibit_redisplay covers the Fselect_window call in x_consider_frame_title, it does not cover the Fselect_window in unwind_format_mode_line since that is performed _after_ the special binding of Qinhibit_redisplay has been abolished. Which means that we call resize_mini_window for the first call when the corresponding windows are on different frames but not for the second. martin