all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: emacs-devel <emacs-devel@gnu.org>
Subject: *Completions* in minibuffer-only frames
Date: Tue, 19 Feb 2019 10:31:09 +0100	[thread overview]
Message-ID: <5C6BCCDD.3030907@gmx.at> (raw)

[-- Attachment #1: Type: text/plain, Size: 459 bytes --]

With Emacs 26 and a minibuffer-only frame, *Completions* may be
displayed in the minibuffer window.  To reproduce with emacs -Q do
(make-frame '((minibuffer . only))) and in that minibuffer-only frame
type C-h f followed by TAB.  This will display *Completions* in the
minibuffer window and it can become quite complicated to get rid of it
again.  Hence I would like to apply the attached trivial patch to the
release branch.  Any objections?

Thanks, martin

[-- Attachment #2: display-buffer-avoid-minibuffer-window.diff --]
[-- Type: text/plain, Size: 881 bytes --]

diff --git a/lisp/window.el b/lisp/window.el
index 4b30609..0a36ae7 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7397,6 +7397,7 @@ display-buffer-below-selected
 	     (window--display-buffer
 	      buffer window 'window alist display-buffer-mark-dedicated))
 	(and (setq window (window-in-direction 'below))
+             (not (window-minibuffer-p window))
 	     (not (window-dedicated-p window))
 	     (window--display-buffer
 	      buffer window 'reuse alist display-buffer-mark-dedicated)))))
@@ -7432,6 +7433,7 @@ display-buffer-at-bottom
 	     (window--display-buffer
 	      buffer window 'window alist display-buffer-mark-dedicated))
 	(and (setq window bottom-window)
+             (not (window-minibuffer-p window))
 	     (not (window-dedicated-p window))
 	     (window--display-buffer
 	      buffer window 'reuse alist display-buffer-mark-dedicated)))))

             reply	other threads:[~2019-02-19  9:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19  9:31 martin rudalics [this message]
2019-02-19 16:26 ` *Completions* in minibuffer-only frames Eli Zaretskii
2019-02-19 17:46   ` martin rudalics
2019-02-19 18:15     ` Eli Zaretskii
2019-02-20 10:20       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C6BCCDD.3030907@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.