From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 34318@debbugs.gnu.org, Andreas Schwab <schwab@linux-m68k.org>
Subject: bug#34318: 26.1.90; Strange behavior of two line message with running shell
Date: Tue, 19 Feb 2019 10:00:47 +0100 [thread overview]
Message-ID: <5C6BC5BF.1010203@gmx.at> (raw)
In-Reply-To: <jwvimxog24x.fsf-monnier+emacs@gnu.org>
fixed 34318 26.2
quit
>> Don't call swap_in_symval_forwarding since the currently swapped
>> binding is never one we've modified.
>
> Indeed, good spotting. I installed the patch below which mostly reverts
> this part of the commit.
Thanks for the fix.
> +(ert-deftest data-tests-make-local-forwarded-var () ;bug#34318
> + ;; Boy, this bug is tricky to trigger. You need to:
> + ;; - call make-local-variable on a forwarded var (i.e. one that
> + ;; has a corresponding C var linked via DEFVAR_(LISP|INT|BOOL))
> + ;; - cause the C code to modify this variable from the C side of the
> + ;; forwarding, but this needs to happen before the var is accessed
> + ;; from the Lisp side and before we switch to another buffer.
> + ;; The trigger in bug#34318 doesn't exist any more because the C code has
> + ;; changes.
I suppose you refer to Paul's "Don’t set print-escape-newlines in the
minibuffer" here. Right?
> Instead I found the trigger below.
> + (with-temp-buffer
> + (setq last-coding-system-used 'bug34318)
> + (make-local-variable 'last-coding-system-used)
> + ;; This should set last-coding-system-used to `no-conversion'.
> + (decode-coding-string "hello" nil)
> + (should (equal (list last-coding-system-used
> + (default-value 'last-coding-system-used))
> + '(no-conversion bug34318)))))
> +
> ;;; data-tests.el ends here
martin, closing this bug
next prev parent reply other threads:[~2019-02-19 9:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-04 18:52 bug#34318: 26.1.90; Strange behavior of two line message with running shell martin rudalics
2019-02-04 22:19 ` Andreas Schwab
2019-02-04 23:44 ` Glenn Morris
2019-02-05 8:36 ` martin rudalics
2019-02-05 9:05 ` Eli Zaretskii
2019-02-05 10:21 ` martin rudalics
2019-02-05 9:12 ` Andreas Schwab
2019-02-05 10:21 ` martin rudalics
2019-02-05 8:36 ` martin rudalics
2019-02-05 9:37 ` Andreas Schwab
2019-02-05 10:21 ` martin rudalics
2019-02-05 10:36 ` Eli Zaretskii
2019-02-05 11:39 ` Andreas Schwab
2019-02-05 13:25 ` Eli Zaretskii
2019-02-05 13:44 ` Andreas Schwab
2019-02-08 9:58 ` martin rudalics
2019-02-12 21:34 ` Stefan Monnier
2019-02-19 9:00 ` martin rudalics [this message]
2019-02-19 12:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C6BC5BF.1010203@gmx.at \
--to=rudalics@gmx.at \
--cc=34318@debbugs.gnu.org \
--cc=monnier@IRO.UMontreal.CA \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.