From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#34317: 26.1.90; Wrong unbinding order in x_consider_frame_title Date: Mon, 04 Feb 2019 19:49:54 +0100 Message-ID: <5C588952.1080706@gmx.at> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080804060506060105010307" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="181162"; mail-complaints-to="usenet@blaine.gmane.org" To: 34317@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 04 20:31:28 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gqjxn-000l00-Q7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 20:31:28 +0100 Original-Received: from localhost ([127.0.0.1]:48099 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjxm-0000jQ-Iy for geb-bug-gnu-emacs@m.gmane.org; Mon, 04 Feb 2019 14:31:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35920) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjKh-00005j-9m for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:51:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqjKg-00089H-F2 for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:51:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60432) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqjKg-00088z-Ar for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gqjKg-0004zf-4A for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 04 Feb 2019 18:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 34317 X-GNU-PR-Package: emacs X-Debbugs-Original-To: Bug-Gnu-Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.154930622319137 (code B ref -1); Mon, 04 Feb 2019 18:51:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 4 Feb 2019 18:50:23 +0000 Original-Received: from localhost ([127.0.0.1]:59712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqjK3-0004yb-AE for submit@debbugs.gnu.org; Mon, 04 Feb 2019 13:50:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gqjK1-0004yP-8x for submit@debbugs.gnu.org; Mon, 04 Feb 2019 13:50:22 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gqjJv-0007OL-ES for submit@debbugs.gnu.org; Mon, 04 Feb 2019 13:50:16 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:35477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gqjJu-0007uY-Ex for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:50:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gqjJt-0007N3-Ik for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:50:14 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:45443) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gqjJq-00076o-90 for bug-gnu-emacs@gnu.org; Mon, 04 Feb 2019 13:50:12 -0500 Original-Received: from [192.168.1.101] ([46.125.250.110]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MT60g-1gjgpY45d0-00S4bj for ; Mon, 04 Feb 2019 19:50:03 +0100 X-Provags-ID: V03:K1:bVQthvweYx96ori+GWhOjBPv0bExpxs9N+cB9unYmCoUU9MmD1E 1+71r2dlKC2L084obLfzuksnA9Ee9X/Buvcd02dZB8saU44VONhrWCt9S1i9+egwlibq6Gz z1I6QiYUc5Gajgy7Lw9qZ85XKIP2sANlbfVxxltYcDgeP31U4yuJ0NuO8aC4eXa0qTVzTgn IC/nbuQSj1rVfFUe5L4sA== X-UI-Out-Filterresults: notjunk:1;V03:K0:YMwaSHFsfBE=:5TBk7vnvGy3kamz7EG0aer OjXiMXi/1xCpErN/7V8kmiVQsL5yQnTH0FomGhLf8zbEWiVhN0oXDIpf/J6v+ONUZ3pG5nnB2 9HGF+fEuINmJBcgcnF6dXnw+++WXLsQ1Ct+X6nENLE4J+FJg60kx2jVLIOJGK8cZjWyjXxKMm E1UL5AcH8F05Jq8UelpVAeef+2+oM2t8umH0u9w7Ni0YY7jyL7eRavkvzfDYlyjpK1SkZyHaz J6VlCRlbtlG28YAl5057ZnOPMGNuS39PN76gtwqHOUfMg8+6NrGaV3Lj/uaS+oz2VKH3+DfUn SlWQLNg61n2zoG2F/HVj/m7ONxrc6ugXFaSPkTV+k/TqPT8ESsUQSOCzNty7O8MYm/+Wqd8cz fiEWmnX/dn+1ZGEommXP1XK07nCMtNdNPq5wmr/OeYUK7TNEAD4JILmXCrJ8AYQKh+zU2BfYd NeO+6F6Q2T5M2wRtVGtOSE+zHFbYRMnuqbUsLKsmg51uU021hOj3DVZEuy7rbnKwdM5p+68cs GpjAaLwhrgb5+BFk2VPlje2dNDpv8GLMKd2gcg/a0tJshC/l7o4TKpqb4T3TpAdL3KChP1n0G NuBWHMgQGxhuBeE9pZHeSQRQ/+mA4iJ0pdxiCONBiXcQgS5bhWwdUZfrSR16l1m/ufAdjcZRB Qc7eTfCSLVlnIpVS0SsblDkWuFwmu6fUEn3gQwRlfXOahOM2VoiwdVbHas4iL7PjRx7QUpncg lXKGkc0xRomu84UlSNXJkmrvpTE+Z7AgfEEZrYudpLo9T/JzVz0JjgCsPi6Xfqj7Oj5DNU10 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155086 Archived-At: This is a multi-part message in MIME format. --------------080804060506060105010307 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit The unbinding order in x_consider_frame_title is botched. Hence, while do_switch_frame will not resize the minibuffer window when the frame of the title bar gets selected, it will still resize when the old frame gets reselected in the unbind form. The behavior can be seen with emacs -Q evaluating the following two forms in row: (make-frame '((minibuffer . nil))) (y-or-n-p "\n") The attached trivial patch cures it. Obviously, there's no guarantee that some other client relies on the wrong order. martin --------------080804060506060105010307 Content-Type: text/plain; charset=windows-1252; name="x_consider_frame_title.diff~" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="x_consider_frame_title.diff~" ZGlmZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNwLmMNCmluZGV4IDI3NGFiOGQu LjBkMDg0ZjggMTAwNjQ0DQotLS0gYS9zcmMveGRpc3AuYw0KKysrIGIvc3JjL3hkaXNwLmMN CkBAIC0xMjAwMiwxMiArMTIwMDIsNiBAQCBzdGF0aWMgdm9pZCBBVFRSSUJVVEVfRk9STUFU X1BSSU5URiAoMSwgMCkNCiAgICAgICAvKiBTZXQgZ2xvYmFsIHZhcmlhYmxlIGluZGljYXRp bmcgdGhhdCBtdWx0aXBsZSBmcmFtZXMgZXhpc3QuICAqLw0KICAgICAgIG11bHRpcGxlX2Zy YW1lcyA9IENPTlNQICh0YWlsKTsNCiANCi0gICAgICAvKiBTd2l0Y2ggdG8gdGhlIGJ1ZmZl ciBvZiBzZWxlY3RlZCB3aW5kb3cgb2YgdGhlIGZyYW1lLiAgU2V0IHVwDQotCSBtb2RlX2xp bmVfdGFyZ2V0IHNvIHRoYXQgZGlzcGxheV9tb2RlX2VsZW1lbnQgd2lsbCBvdXRwdXQgaW50 bw0KLQkgbW9kZV9saW5lX25vcHJvcF9idWY7IHRoZW4gZGlzcGxheSB0aGUgdGl0bGUuICAq Lw0KLSAgICAgIHJlY29yZF91bndpbmRfcHJvdGVjdCAodW53aW5kX2Zvcm1hdF9tb2RlX2xp bmUsDQotCQkJICAgICBmb3JtYXRfbW9kZV9saW5lX3Vud2luZF9kYXRhDQotCQkJICAgICAg IChmLCBjdXJyZW50X2J1ZmZlciwgc2VsZWN0ZWRfd2luZG93LCBmYWxzZSkpOw0KICAgICAg IC8qIHNlbGVjdC1mcmFtZSBjYWxscyByZXNpemVfbWluaV93aW5kb3csIHdoaWNoIGNvdWxk IHJlc2l6ZSB0aGUNCiAJIG1pbmktd2luZG93IGFuZCBieSB0aGF0IHVuZG8gdGhlIGVmZmVj dCBvZiB0aGlzIHJlZGlzcGxheQ0KIAkgY3ljbGUgd3J0IG1pbmlidWZmZXIgYW5kIGVjaG8t YXJlYSBkaXNwbGF5LiAgQmluZGluZw0KQEAgLTEyMDE1LDYgKzEyMDA5LDEyIEBAIHN0YXRp YyB2b2lkIEFUVFJJQlVURV9GT1JNQVRfUFJJTlRGICgxLCAwKQ0KIAkgbm8tb3AsIHRodXMg YXZvaWRpbmcgdGhlIGFkdmVyc2Ugc2lkZSBlZmZlY3RzLiAgKi8NCiAgICAgICBzcGVjYmlu ZCAoUWluaGliaXRfcmVkaXNwbGF5LCBRdCk7DQogDQorICAgICAgLyogU3dpdGNoIHRvIHRo ZSBidWZmZXIgb2Ygc2VsZWN0ZWQgd2luZG93IG9mIHRoZSBmcmFtZS4gIFNldCB1cA0KKwkg bW9kZV9saW5lX3RhcmdldCBzbyB0aGF0IGRpc3BsYXlfbW9kZV9lbGVtZW50IHdpbGwgb3V0 cHV0IGludG8NCisJIG1vZGVfbGluZV9ub3Byb3BfYnVmOyB0aGVuIGRpc3BsYXkgdGhlIHRp dGxlLiAgKi8NCisgICAgICByZWNvcmRfdW53aW5kX3Byb3RlY3QgKHVud2luZF9mb3JtYXRf bW9kZV9saW5lLA0KKwkJCSAgICAgZm9ybWF0X21vZGVfbGluZV91bndpbmRfZGF0YQ0KKwkJ CSAgICAgICAoZiwgY3VycmVudF9idWZmZXIsIHNlbGVjdGVkX3dpbmRvdywgZmFsc2UpKTsN CiAgICAgICBGc2VsZWN0X3dpbmRvdyAoZi0+c2VsZWN0ZWRfd2luZG93LCBRdCk7DQogICAg ICAgc2V0X2J1ZmZlcl9pbnRlcm5hbF8xDQogCShYQlVGRkVSIChYV0lORE9XIChmLT5zZWxl Y3RlZF93aW5kb3cpLT5jb250ZW50cykpOw0KDQo= --------------080804060506060105010307--