all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: stephen.berman@gmx.net, 34138@debbugs.gnu.org,
	politza@hochschule-trier.de, tsdh@gnu.org
Subject: bug#34138: 27.0.50; Delayed display of PDF file images
Date: Sat, 26 Jan 2019 16:07:41 +0100	[thread overview]
Message-ID: <5C4C77BD.5070701@gmx.at> (raw)
In-Reply-To: <83h8dv668x.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

 > That's at the beginning of redisplay, so yes, I think it's a better
 > place.

Patch attached.  Everybody involved, please try.

Thanks, martin

[-- Attachment #2: run_window_change_functions.diff --]
[-- Type: text/plain, Size: 1741 bytes --]

diff --git a/src/xdisp.c b/src/xdisp.c
index 8649507..ed4474e 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -14153,6 +14153,9 @@ static void debug_method_add (struct window *, char const *, ...)
       clear_garbaged_frames ();
     }
 
+  if (!NILP (Vrun_hooks))
+    run_window_change_functions ();
+
   if (windows_or_buffers_changed && !update_mode_lines)
     /* Code that sets windows_or_buffers_changed doesn't distinguish whether
        only the windows's contents needs to be refreshed, or whether the
@@ -14332,18 +14335,6 @@ static void debug_method_add (struct window *, char const *, ...)
 		  && (w = XWINDOW (selected_window)) != sw)
 		goto retry;
 
-	      if (!NILP (Vrun_hooks))
-		{
-		  run_window_change_functions ();
-
-		  /* If windows or buffers changed or selected_window
-		     changed, redisplay again.  */
-		  if ((windows_or_buffers_changed)
-		      || (WINDOWP (selected_window)
-			  && (w = XWINDOW (selected_window)) != sw))
-		    goto retry;
-		}
-
 		/* We used to always goto end_of_redisplay here, but this
 		 isn't enough if we have a blinking cursor.  */
 	      if (w->cursor_off_p == w->last_cursor_off_p)
@@ -14707,18 +14698,6 @@ static void debug_method_add (struct window *, char const *, ...)
 	  && (w = XWINDOW (selected_window)) != sw))
     goto retry;
 
-  if (!NILP (Vrun_hooks))
-    {
-      run_window_change_functions ();
-
-      /* If windows or buffers changed or selected_window changed,
-	 redisplay again.  */
-      if ((windows_or_buffers_changed)
-	  || (WINDOWP (selected_window)
-	      && (w = XWINDOW (selected_window)) != sw))
-	goto retry;
-    }
-
   /* Clear the face and image caches.
 
      We used to do this only if consider_all_windows_p.  But the cache


  reply	other threads:[~2019-01-26 15:07 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19 21:13 bug#34138: 27.0.50; Delayed display of PDF file images Stephen Berman
2019-01-20  9:17 ` martin rudalics
2019-01-20 11:04   ` Andreas Politz
2019-01-20 14:19     ` martin rudalics
2019-01-20 11:18   ` Stephen Berman
2019-01-20 14:20     ` martin rudalics
2019-01-20 14:55       ` Stephen Berman
2019-01-20 15:32         ` Eli Zaretskii
2019-01-20 15:51           ` Stephen Berman
2019-01-20 16:08             ` Eli Zaretskii
2019-01-20 16:31               ` Stephen Berman
2019-01-20 16:50                 ` Eli Zaretskii
2019-01-20 17:14                   ` Stephen Berman
2019-01-20 17:42                     ` Eli Zaretskii
2019-01-20 20:45                       ` Stephen Berman
2019-01-21 15:58                         ` Eli Zaretskii
2019-01-21 16:13                           ` Stephen Berman
2019-01-21 16:36                             ` Eli Zaretskii
2019-01-21 18:17                               ` Stephen Berman
2019-01-21 18:42                                 ` Eli Zaretskii
2019-01-21 19:14                                   ` Andreas Politz
2019-01-21 19:47                                     ` Eli Zaretskii
2019-01-21 22:27                                       ` Stephen Berman
2019-01-22 16:25                                         ` Eli Zaretskii
2019-01-22 22:00                                           ` Stephen Berman
2019-01-23 14:31                                             ` Stephen Berman
2019-01-23 16:26                                               ` Eli Zaretskii
2019-01-23 17:22                                                 ` Stephen Berman
2019-01-23 16:13                                             ` Eli Zaretskii
2019-01-23 17:21                                               ` Stephen Berman
2019-01-23 22:20                                                 ` Stephen Berman
2019-01-23 18:27                                               ` martin rudalics
2019-01-23 18:39                                                 ` Eli Zaretskii
2019-01-24  9:08                                                   ` martin rudalics
2019-01-24 14:26                                                     ` Eli Zaretskii
2019-01-24 19:41                                                       ` Andreas Politz
2019-01-25  9:44                                                         ` martin rudalics
2019-01-26  9:19                                                       ` martin rudalics
2019-01-26 10:52                                                         ` Eli Zaretskii
2019-01-26 15:07                                                           ` martin rudalics [this message]
2019-01-26 15:33                                                             ` Stephen Berman
2019-02-02  9:28                                                               ` martin rudalics
2019-02-02  9:38                                                                 ` Andreas Politz
2019-02-19  8:47                                                                   ` martin rudalics
2019-02-02 12:59                                                                 ` Stephen Berman
2019-02-19  8:40                                                                   ` martin rudalics
2019-03-30  2:56                                                                     ` Noam Postavsky
2019-04-23  9:22                                                                       ` martin rudalics
2019-02-02  9:33                                                             ` Andreas Politz
2019-02-02  9:37                                                               ` martin rudalics
2019-01-21 20:33                                     ` Stephen Berman
2019-01-21 20:35                                       ` Eli Zaretskii
2019-01-21 20:43                                         ` Stephen Berman
2019-01-21 21:28                                           ` Andreas Politz
2019-01-21 18:47                                 ` martin rudalics
2019-01-21 19:19                                   ` Andreas Politz
2019-01-21 20:33                                     ` Stephen Berman
2019-01-20 17:55         ` martin rudalics
2019-01-20 20:45           ` Stephen Berman
2019-01-21  7:52             ` martin rudalics
2019-01-21 15:20               ` Stephen Berman
2019-01-21  6:11       ` Tassilo Horn
2019-01-21  7:52         ` martin rudalics
2019-01-21 15:20           ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5C4C77BD.5070701@gmx.at \
    --to=rudalics@gmx.at \
    --cc=34138@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=politza@hochschule-trier.de \
    --cc=stephen.berman@gmx.net \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.