From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#7381: 24.0.50; Provide a hook run when a window is selected Date: Sat, 12 Jan 2019 10:15:24 +0100 Message-ID: <5C39B02C.6040309@gmx.at> References: <87k4kjfldo.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1547285361 4445 195.159.176.226 (12 Jan 2019 09:29:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 09:29:21 +0000 (UTC) To: =?UTF-8?Q?=C5=A0t=C4=9Bp=C3=A1n_?= =?UTF-8?Q?N=C4=9Bmec?= , 7381@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 12 10:29:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giFbP-00010S-D6 for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 10:29:15 +0100 Original-Received: from localhost ([127.0.0.1]:44162 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giFdW-0006g1-4a for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Jan 2019 04:31:26 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56565) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giFdL-0006X0-14 for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 04:31:15 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giFOd-0004a6-SM for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 04:16:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1giFOd-0004Zw-Nb for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 04:16:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1giFOd-0004Ta-J2 for bug-gnu-emacs@gnu.org; Sat, 12 Jan 2019 04:16:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Jan 2019 09:16:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7381 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7381-submit@debbugs.gnu.org id=B7381.154728453417104 (code B ref 7381); Sat, 12 Jan 2019 09:16:03 +0000 Original-Received: (at 7381) by debbugs.gnu.org; 12 Jan 2019 09:15:34 +0000 Original-Received: from localhost ([127.0.0.1]:56508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giFOA-0004Rn-4C for submit@debbugs.gnu.org; Sat, 12 Jan 2019 04:15:34 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:48605) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giFO8-0004RX-1L; Sat, 12 Jan 2019 04:15:32 -0500 Original-Received: from [192.168.1.101] ([213.162.73.238]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MGip3-1gUir62yLx-00DXI4; Sat, 12 Jan 2019 10:15:25 +0100 In-Reply-To: <87k4kjfldo.fsf@gmail.com> X-Provags-ID: V03:K1:dhZ0b7Q58cE3mmTeaz6+tyu4VgfAmPOIQEIj8c4sWfJcyFEwiSH JnM5dj6cibAr4NNkqPpVSYDtfsNOx48GMd9wF0LI8/o0JuInn898xa0Vs+bjCwfyeOWPXpD SMROqjmefxM/GwBSeSqsPiGKpEQb9wqrrykO7UgkEbDPNFMiQiXyTU/jSdjHRXLzdZrutdM nX/hynbFqv2UDvXV7gscA== X-UI-Out-Filterresults: notjunk:1;V03:K0:AqAesS6h6UQ=:0z5/TjHWBnPQVGiyCI2RTU n58HQZ81tqmlxL0N0LtYT0ku2dqs9rNG2EZs6I634uRW103XzpIPnO510wp9ikwnkMZgAk7HX ru2duc0quRahFjnEB2BfUgK/CtNhXAWhNHV7GIrzJHOesIHfm74L/4XRXrkXK5mgga0IGZbTp hBLxDGGPD7dzEDZ7suHS87gx+ArpxuhD0SKfKY8jE2SWY/thyRQyjTioevXcJawDi8qxmWKEN DdfYLOIumNh7Z42V2unRsk0o9zQtbKmuE0boo/2fN7JZm6J0j+kK+6MpWO2qtD/C1Ny3PP/L+ DMGk/MslHSUoWzq3XqNoWLOqWjiCQAv106uC9xnUjSJVzLfDRZiZc9yNhqdLTuOKUqfesTra6 vEBmqF2o3Cp2B0Ec2lMCDxW3q4E1qqKRhGPyFdKAhUyel8gNYRJVSBlcvDTcRWqCmPPM4irSq pJlh1+LG26kvOuWPIIQQ4QDqqe1Ac/7h5SWjMCvJRlvJKDj9WosyIZRBhdiVjDRPKuCFSLU7j KDLhTUs9GJxjpDcpaLUZ1BInYPPgCUA2+0IJtlY6Emc4ufyaOta7NkX+iLiAiClBq8ZDQN+bP dsFuhLbSWWlYLumwBBFeltoRvHhF4DHatd9MAeTbC7giFCkuDW9SV/e7LE3Vs7SmmcvOQXqA6 1CU0aSvJxp+3UGmcrcuZkc7KSwp76zzjdcTkbtnNi4yVnrvBbqge+KVcE+JdVHbGVIdoaV2FR PNcTfkHtxOqDLtsU4HdGoed1CJLAyXfvhJypquLrAAHwz1pyHiwagUf/mBKG5IeAeqY0IO+7 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154370 Archived-At: ;; fixed 7381 27.1 ;; quit > The subject line says it all: could we get a `window-selected-hook' or > `window-selected-functions' or something? > > Use case: I wanted to make myself a command to select the last selected > window (i.e., repeating the command would toggle between two windows). > > After some head-scratching, the best I could come up with is this: > > (defun .goto-mru-window () > (interactive) > (select-window (frame-parameter nil '.last-selected-window))) > > (defadvice select-window (before .save-selected-window activate) > (set-frame-parameter nil '.last-selected-window (selected-window))) > > ...which seems to work most of the time, but using an advice doesn't > feel that great, esp. with C functions. Current master now provides a hook run when redisplay detects that the selected window has changed wrt last redisplay. The hook is called 'window-selection-change-functions' and is described in detail in the Elisp manual. Below I sketch how that hook could be used to provide the behavior you asked for. martin (defvar .old-selected-window (selected-window)) (defun .update-old-selected-window (frame) (unless (eq .update-old-selected-window old-selected-window) (setq .old-selected-window (old-selected-window)))) (add-hook 'window-selection-change-functions '.update-old-selected-window) (defun .goto-mru-window () (interactive) (select-window .old-selected-window)) (global-set-key [(control .)] '.goto-mru-window)