From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33870: 27.0.50; xref-goto-xref not configurable Date: Tue, 08 Jan 2019 10:25:10 +0100 Message-ID: <5C346C76.4050803@gmx.at> References: <87a7ktqqx7.fsf@mail.linkov.net> <9215183d-0a44-88b5-5b3c-d0da31f749ad@yandex.ru> <878t02egph.fsf@mail.linkov.net> <874lak9kr0.fsf@mail.linkov.net> <87zhscklhq.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1546939448 29677 195.159.176.226 (8 Jan 2019 09:24:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 Jan 2019 09:24:08 +0000 (UTC) Cc: 33870@debbugs.gnu.org, Stefan Monnier , Dmitry Gutov To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 08 10:24:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggncA-0007Zu-RB for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jan 2019 10:24:03 +0100 Original-Received: from localhost ([127.0.0.1]:55439 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggneH-0005P9-G7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 Jan 2019 04:26:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48517) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ggneA-0005P3-83 for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 04:26:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ggne9-0005Qv-GP for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 04:26:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49964) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ggne9-0005Pz-CP for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 04:26:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ggne6-0002E6-Bu for bug-gnu-emacs@gnu.org; Tue, 08 Jan 2019 04:26:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jan 2019 09:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33870-submit@debbugs.gnu.org id=B33870.15469395388524 (code B ref 33870); Tue, 08 Jan 2019 09:26:02 +0000 Original-Received: (at 33870) by debbugs.gnu.org; 8 Jan 2019 09:25:38 +0000 Original-Received: from localhost ([127.0.0.1]:49245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggndi-0002DQ-8g for submit@debbugs.gnu.org; Tue, 08 Jan 2019 04:25:38 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:41057) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ggndf-0002DC-PC for 33870@debbugs.gnu.org; Tue, 08 Jan 2019 04:25:36 -0500 Original-Received: from [192.168.1.101] ([212.95.5.97]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lj1Xa-1hHm4m3wmU-00dF8L; Tue, 08 Jan 2019 10:25:19 +0100 In-Reply-To: <87zhscklhq.fsf@gmail.com> X-Provags-ID: V03:K1:gYcQIVepQvj0a8bYtN72dxk0YMp1M/IEIBRABL7QPGgp0uy75VJ UknnKwHz12AEkQabpsT9Ea65nefLHCtTPJBzsnEEjZeSmTU/ysD79Tqq1zfMtO6JzF3qNlz HU55AzHbEjVezJBIekMYYN5v500AAGRkPVE1AULEHw0Exal+xE/pqWCsAQy1qUTS9QhQlUj WvfkOureHc/9Cu1T522KQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:fhdPSGhBNgA=:4jbuDx6nrY+T3YQ82EYXBL id5+pRRWrBrJKvIvduY7mI6yvq88KWxDrzBTS6AwCm0cfGLtnaMPnBI5G+DETMFXHCnZzMFRD FFE/PjHg33WCKemlGC2ib0fQhm1gijTqyRz9WEc+OVXFtwA+DqdW84wBGSHBYpzTCxkiXw1pX 7hPkmh5ZT6Rp6C2C2jK08lD6ynfkZuxHUC8vlL+WAjJdf6JVebolIWJzhCGcZ2AWcfI77uYRx rJXh2EXj1SRCigst7Jlqf+kQ9GcYUAf4UkURzJKHF9LVto6fEkABqVsrwhJsiiVKjEEMXqgov Wsqi/BPX2yAhJKvsE9yVn5yYRJYHirrpRdvV4ktR+71dM4NMgWs+7l5BhBfUlyRvBuL2GtXOz CPYM3ogXUFum24tm5fb7KmVD1iOIrQjRPPBP4oKyzmeQTGksWeDGirzZA9iBRnO1DUuDaU6dy AljSqOrOronESFWduL1wJR98SnWSH7TpQYq3s7rGw+O9HgNqNxD+LJBKBH21lDqQch68cQofp k7y/oW+eSTMLPCsa3PFzkl/W4p7cvahxnTuCH/XHMPSgqWd2N0YyGMQDF4FA9oaj5NRu6Tlsb ldHpn+Cuak7qGyW7BBS6LakCsASkVQHDh+TcdznmnUJQlYuN6LKWVHuIjudObjyYPv1WpJApr uYeJ163BawpqcSEPJ4eIsYcRHR/DFHOtJN7meyD0PBvOG2k3R+rPnk7DIgzB/9BTJQaJKYCmC gps1SmLSh4SGNEDnoYA9YLe/M7TzaLYfGs4Kdz+77uzUG4Wn/k6vninz4LJ2TeBnZAHhfBzZ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:154251 Archived-At: > You may argue that by making them public *now* we are going to have a > more deprecation problem if we decide to rename them again *in the > future*. I would agree with you there. The DEDICATED argument of 'window--display-buffer' is a very gross hack that nobody among us will understand in all its consequences. Try to guess its semantics from the fairly underdocumented variable 'display-buffer-mark-dedicated' and how it's set by the various buffer display actions - most of them copying the call scheme from another. IIUC the idea is that a "reused" window should not be made dedicated while a new window could be made dedicated. So we could guess the intention from the TYPE argument - unless it's 'reuse', dedicate the window if asked for. But we do not implement that consistently. So before making this function public, we should resolve this calling convention. Personally, I'd proceed as follows: (1) Deprecate the variable 'display-buffer-mark-dedicated'. (2) Remove the DEDICATED argument from this function. (3) Add a 'dedicated' action alist entry to implement the functionality. And we should specify once and for all whether a window can remain or become dedicated when our function displays another buffer in it. And another thing: The term "reuse" has two meanings in the context of buffer display: OT1H "reuse" stands for reusing a window showing one and the same buffer like in 'display-buffer-reuse-window'. In 'window--display-buffer', if TYPE equals 'reuse' this just means that an existing window has been reused for showing BUFFER - that window might have shown another buffer before. This confusion would have to be resolved as well before going public with this function. martin