all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* display-buffer-use-some-frame
@ 2018-10-28 18:37 martin rudalics
  2018-12-11 19:31 ` display-buffer-use-some-frame Stephen Leake
  0 siblings, 1 reply; 8+ messages in thread
From: martin rudalics @ 2018-10-28 18:37 UTC (permalink / raw)
  To: emacs-devel, Stephen Leake

Sorry for returning to this after more than three years.  Somehow your
final installation must have slipped under the carpet here.  As it
stands 'display-buffer-use-some-frame' has the following deficencies:

- The first sentence of the doc-string doesn't fit on a whole line.

- The line

          (window (and frame (get-lru-window frame nil (cdr (assq 'inhibit-same-window alist))))))

   is too long.

- In the call

           (window--display-buffer
            buffer window 'frame alist display-buffer-mark-dedicated)

   you should write 'reuse instead of 'frame.  The latter means that a
   new frame has been made but you just reuse an existing window.  I
   noticed this because I made the same error in (an undocumented part
   of) 'display-buffer-in-child-frame'.

Please fix these on the release branch.  Also, I wonder why you call
'frame-first-window' here:

                            (not (window-dedicated-p
                                  (or
                                   (get-lru-window frame)
                                   (frame-first-window frame)))))

It's nowhere used in the rest of the function.  What am I missing?

Thank you, martin



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-12-24 13:53 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-28 18:37 display-buffer-use-some-frame martin rudalics
2018-12-11 19:31 ` display-buffer-use-some-frame Stephen Leake
2018-12-12  8:31   ` display-buffer-use-some-frame martin rudalics
2018-12-23 18:23   ` display-buffer-use-some-frame Stephen Leake
2018-12-23 19:07     ` display-buffer-use-some-frame martin rudalics
2018-12-23 22:19     ` display-buffer-use-some-frame Stefan Monnier
2018-12-24  8:13       ` display-buffer-use-some-frame martin rudalics
2018-12-24 13:53         ` display-buffer-use-some-frame Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.