From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33458: 27.0.50; dired loses position when reverted from outside place Date: Thu, 13 Dec 2018 10:02:57 +0100 Message-ID: <5C122041.8010204@gmx.at> References: <87k1l6f9li@posteo.net> <5C063BD6.5020707@gmx.at> <87tvjhri3h@posteo.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1544691736 13777 195.159.176.226 (13 Dec 2018 09:02:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Dec 2018 09:02:16 +0000 (UTC) To: v88m@posteo.net, 33458@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 13 10:02:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXMsk-0003PZ-Hp for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2018 10:02:10 +0100 Original-Received: from localhost ([::1]:51240 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXMuq-0005Gk-SG for geb-bug-gnu-emacs@m.gmane.org; Thu, 13 Dec 2018 04:04:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gXMuh-0005FK-Hd for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 04:04:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gXMuY-00019K-VV for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 04:04:09 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gXMuY-00018Q-DM for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 04:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gXMuY-0006Jk-7S for bug-gnu-emacs@gnu.org; Thu, 13 Dec 2018 04:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Dec 2018 09:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33458-submit@debbugs.gnu.org id=B33458.154469179424221 (code B ref 33458); Thu, 13 Dec 2018 09:04:02 +0000 Original-Received: (at 33458) by debbugs.gnu.org; 13 Dec 2018 09:03:14 +0000 Original-Received: from localhost ([127.0.0.1]:45799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXMtl-0006Ia-Jv for submit@debbugs.gnu.org; Thu, 13 Dec 2018 04:03:13 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:47631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gXMtk-0006IL-B4 for 33458@debbugs.gnu.org; Thu, 13 Dec 2018 04:03:12 -0500 Original-Received: from [192.168.1.101] ([213.162.73.124]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MQzoI-1h0Z8R2fmw-00ULnV; Thu, 13 Dec 2018 10:03:05 +0100 In-Reply-To: <87tvjhri3h@posteo.net> X-Provags-ID: V03:K1:YvjqMzoy+3f3WYtIvuXM/5vwwEuCRudRUBd5x6vUZk4G55Uqq2z ez2mHVzgImz0E1XE9T6HKjI2lSKzx4TLJWD5ZeYRxICM3YaCSRMpiJRXc5kINkEHc0NRLJE 8VXYX6jIma6+Ikuj4NQmFfmh1SyRFYixCxjxQr0+/zJbWQX/ZTaIQOle2YANZebBCaeh304 wnc565qQtYPBHy+NRs46Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:GIPC1h02RlU=:hIGXCyaIXdtBgBtfLtnTsS IP9Ti73Ol3VfUNcssiV/w7PGuC7upCdETXXjGYTY9bKsCYhlKkyBg8ZVmDuPofnF/3u3hRV10 WgENpDhU9EGnIfDaRKUACegvMxLFeniI3tMsECW+SIyy2ScGWOItwmxXFeKlW3Z6Gwpe6T5Pm mIJwSuuBgLIUPjk7jhket+6/cI271HpJLFTIsoLznva6oOX7xrjCvqZ5xW16XfhFnrvOsrBKw nNFqh6FLlcOPik8ze8EqZrYkYsx8CY1I2MQAZFPjpJRVu6eqbjLnxSnlzsLAsd/Io3wTgeLKp 8R4A4zSUPgZmuqPk02kTl/MUDwrBIjEh8/vvAAnRNmzmp1TQSrTtY8Vmp8KNrFfXHUyESrBx3 fb+5SH90Fuiul9r5/tWdwYp9i8ga0yIENrfFe1dpl5ezuWalpkGLCMmcTiWBDjjEkaYuc4BOg 3Y7N7hA9i0vrdOcIs0qbtZ9YRAX53/frgiVTJ6V8D/uOFC7mRGH0DxXyItNXILZBicnLf3u/h nNDSbiuzRVyGxLbjBP8UktMrVY/1wijuVZ68xUrpqjcxULwwsc4PZhidaGrEDYWDXJdLQ8Xez /JsL1HrqmIemKWNE+bT4YIuXTeLj0kFohIuUtJu9smJah+vZ6UERvk5xhm/MZsxXQRon7vavl 7qQgkYSkzJmsf+Jqxog+K3dArRQZEi1Pf17BmJS0oMDu7Y1Yw03r44SQD4LVOC2L8NeAH4q/c FDP1La9xKCIaaiuSvKFsv3Zvo/OH1K1JmcbwVPKd9UVT+V9O9oaBc0XsbkD2lQvVnQdZjg4U X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153399 Archived-At: > Playing with patched dired.el I can see error message in some cases > while buffer creating, deleting and selecting: > > "wrong-type-argument stringp nil" Are you sure you've seen this happening _after_ my last fix two days ago? Because if 'dired-goto-file' _now_ chokes on (nth 1 prev) this should be due to any other value but nil. > + (ignore-errors > + (dired-goto-file (nth 1 prev)))) If you still see an error now we can do that. It should never harm. But for the moment I'm mostly curious whether you can still see the "wrong-type-argument stringp nil" message. > May be we need same treatment for other `dired-goto-file' lines or make > more general check for `prev's structure? All these are heuristics based on the idea that in most cases a file is still present after reverting its directory's list of files. Yet, 'dired-goto-file' should not choke on a file name previously produced by 'dired-get-filename'. Thanks, martin