From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33458: 27.0.50; dired loses position when reverted from outside place Date: Mon, 10 Dec 2018 08:58:21 +0100 Message-ID: <5C0E1C9D.3040106@gmx.at> References: <87k1l6f9li@posteo.net> <5C063BD6.5020707@gmx.at> <874lbt73s3@posteo.net> <5C079794.6080500@gmx.at> <5C0B91AD.4050909@gmx.at> <87y38yjkqk.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010409090600030500040400" X-Trace: blaine.gmane.org 1544428627 971 195.159.176.226 (10 Dec 2018 07:57:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 10 Dec 2018 07:57:07 +0000 (UTC) Cc: 33458@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 10 08:57:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWGR4-00007A-1b for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2018 08:57:02 +0100 Original-Received: from localhost ([::1]:59661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWGTA-0004D2-OU for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 Dec 2018 02:59:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWGT4-0004Ci-8x for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 02:59:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWGT0-0006Kq-3D for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 02:59:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36428) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gWGSz-0006KX-Up for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 02:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gWGSz-0007fL-Ir for bug-gnu-emacs@gnu.org; Mon, 10 Dec 2018 02:59:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Dec 2018 07:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33458-submit@debbugs.gnu.org id=B33458.154442872729446 (code B ref 33458); Mon, 10 Dec 2018 07:59:01 +0000 Original-Received: (at 33458) by debbugs.gnu.org; 10 Dec 2018 07:58:47 +0000 Original-Received: from localhost ([127.0.0.1]:40686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWGSl-0007er-8W for submit@debbugs.gnu.org; Mon, 10 Dec 2018 02:58:47 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:37465) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWGSi-0007eb-JW for 33458@debbugs.gnu.org; Mon, 10 Dec 2018 02:58:45 -0500 Original-Received: from [192.168.1.101] ([213.162.68.240]) by mail.gmx.com (mrgmx101 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MHLNn-1gjD180Crj-00E7QB; Mon, 10 Dec 2018 08:58:25 +0100 In-Reply-To: <87y38yjkqk.fsf@mail.linkov.net> X-Provags-ID: V03:K1:V5ExFxn3feFn/RH7D5C6p+DMezuUCKoCRxaVG1jBu/o/vxx8lvA A7e001AUawcs5gDXIIoA1Fagz67HyJKPKiHqawYDDBP6lQEG/uuMfPbpny4M2EjQwqlf/jE vuamoFckLqvr8QkvccA6VHCTard0JKclGFt1f6wJuTVB84JW6yq0NjrCbCGKETutgHlUsaz GeWA9LFM94sh8jFwOSb0w== X-UI-Out-Filterresults: notjunk:1;V03:K0:kx2+49V+ejU=:H/p7hMhyCKvixEyb3R9Vp9 OwMaMMOdvS0GsxKaKBtGbyFFCWLMFlQHNq0d8t9VW4mCMOf1/55ODP+5ykhgPa7LeEkcsMyMq 9uVIR30VgV+ZFGN76SBni1RLxxVVvvNVMXJzxtDS9g1TsXagzfJJh6n9KeDi5VAr8DzlsUNjf DqHR0fteakdO7g01Zfg0/GG7kv01klC1ySPiS++qwY3WoFW6VbLNXgqBy+aWsbZxpPNxY23Nh wrD3wk4hc+Gji4y9ZK0yTkqlWH3wLNHNelM02uxrXz25KI0D8ZeS3tzbGcT9KaGjAKnXLWFao urOR93/IOb/hLIqP9WoPFUUs6pJi4SR2rJWLRd0cbaVRiFe0kDp22866rzpL72UqzkLtb1n+y qqM/nbDKw9lyHek0Rdyk/Vy7IKFOyvFdtU5mZAvsl9asYTGu56PNWruHp9jzzCU9+l6b90Kks USQogei8ZN5DFXSH3YQVM8g4YZ1X+9+qMDCdXfxfjFidybD6/9QOAmWyk6G5/laiUrdkvOHse /xHGkoVM5wGlmFSiJADLKdkZrbmp65sU1el6xXkRa8Q+1Sbjmtz16J6orRqZ69Ie1cX3Gqw5B XNEI1DUJAyAJxsYXdGhw4Q+GrMSOQu3plyN+HCq7OsuZcUR6ksYAwvjZL6fcdGfJ5XTMX2PvU tDun9FRtUDFbeQ1dTiYxeaWl+fydSvE9JbBgpu7GAMR/Jv5tNLgNugezYnIcqMdi43JXFSwsP mqSkndrhTyVurQ9v2FtHMaVtMCrmjA3RLrBtl4LKqNMCsJP+IwLzFSnjqoCzWSxumcMwRsHs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153297 Archived-At: This is a multi-part message in MIME format. --------------010409090600030500040400 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > Unfortunately, now Dired fails to visit a directory: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > file-name-absolute-p(nil) > dired-goto-file(nil) > dired-restore-positions(((# nil 3) nil ((# nil 3)))) > dired-revert(nil nil) > revert-buffer() > dired-internal-noselect("/tmp/" nil) > dired-noselect("/tmp/" nil) > dired("/tmp/") > dired-jump(nil nil) > funcall-interactively(dired-jump nil nil) > call-interactively(dired-jump nil nil) > command-execute(dired-jump) > > Maybe this happens when a reverted directory window is restored > from a window configuration, so point-marker is at 1, > and (dired-get-filename nil t) returns nil in `dired-save-positions'. Looks like a silly typo. Please try the attached patch. If it does not help, please provide me a simple scenario to reproduce the bug. Thanks, martin --------------010409090600030500040400 Content-Type: text/plain; charset=windows-1252; name="dired.el.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="dired.el.diff" ZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwgYi9saXNwL2RpcmVkLmVsDQppbmRleCBlNWRj ODYyLi43MjcyNWRjIDEwMDY0NA0KLS0tIGEvbGlzcC9kaXJlZC5lbA0KKysrIGIvbGlzcC9k aXJlZC5lbA0KQEAgLTE1MzAsNyArMTUzMCw3IEBAIGRpcmVkLXJlc3RvcmUtcG9zaXRpb25z DQogICAgICAgICAgICAgICA7OyBTYW5pdHkgY2hlY2sgb2YgdGhlIHBvaW50IG1hcmtlci4N CiAgICAgICAgICAgICAgICh3aGVuIChhbmQgKG1hcmtlcnAgcG9pbnQpDQogICAgICAgICAg ICAgICAgICAgICAgICAgIChlcSAobWFya2VyLWJ1ZmZlciBwb2ludCkgYnVmZmVyKSkNCi0g ICAgICAgICAgICAgICAgKHVubGVzcyAoYW5kIChudGggMCBwcmV2KQ0KKyAgICAgICAgICAg ICAgICAodW5sZXNzIChhbmQgKG50aCAxIHByZXYpDQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAoZGlyZWQtZ290by1maWxlIChudGggMSBwcmV2KSkpDQogICAgICAgICAgICAg ICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkNCiAJICAgICAgICAgIChmb3J3YXJkLWxp bmUgKDEtIChudGggMiBwcmV2KSkpKQ0K --------------010409090600030500040400--