From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33458: 27.0.50; dired loses position when reverted from outside place Date: Tue, 04 Dec 2018 09:33:26 +0100 Message-ID: <5C063BD6.5020707@gmx.at> References: <87k1l6f9li@posteo.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050904000003060502000002" X-Trace: blaine.gmane.org 1543912330 16529 195.159.176.226 (4 Dec 2018 08:32:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2018 08:32:10 +0000 (UTC) To: v88m@posteo.net, 33458@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 04 09:32:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU67h-0004E6-ME for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2018 09:32:05 +0100 Original-Received: from localhost ([::1]:54568 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gU69o-0004Lk-DG for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2018 03:34:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gU69d-0004LY-32 for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 03:34:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gU69Z-00063A-Tf for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 03:34:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55508) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gU69Z-000632-PQ for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 03:34:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gU69Z-00048D-Lu for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 03:34:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Dec 2018 08:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33458 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33458-submit@debbugs.gnu.org id=B33458.154391242115852 (code B ref 33458); Tue, 04 Dec 2018 08:34:01 +0000 Original-Received: (at 33458) by debbugs.gnu.org; 4 Dec 2018 08:33:41 +0000 Original-Received: from localhost ([127.0.0.1]:59766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU69E-00047a-Hn for submit@debbugs.gnu.org; Tue, 04 Dec 2018 03:33:41 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:55113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gU69C-00047M-EQ for 33458@debbugs.gnu.org; Tue, 04 Dec 2018 03:33:38 -0500 Original-Received: from [192.168.1.101] ([213.162.73.140]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0M6zkD-1hOf2U3vnh-00wjpa; Tue, 04 Dec 2018 09:33:32 +0100 In-Reply-To: <87k1l6f9li@posteo.net> X-Provags-ID: V03:K1:hiaj9CqUTgILB76NHuapgFFmmL8lDb5IMz5AkekbXGUO3GZV3UE QnIwL1nENFtSqsoB0xZHf9kvG0RNkZjl/2CGeN7zjbt9VUIHxkzOqIZNo1xlqwipYGs2hLx tcZz1IZshcHNja+4Bi/mIcgcujnym2potAcKVQOpHDkvPpcukRInXaEyroHxBCtiQk2qZQR P7/I5V5FB7vBVOQECpQdg== X-UI-Out-Filterresults: notjunk:1;V03:K0:pV9f0SoSc5g=:Gsc4Vh2wafsL+JA05Xc06e 8vpPdyk7j/F/6754wGfa1eVrP9ZCgW8+SOIMnMPCM2memqLcmZjfMJLwDoVjOezWFpORXDvq4 Ev2UgjP8fKOoX2O2UjEFfnc8delb8dJ1ZAYWbJVHAPYafN9MkZj4qF3bv7TFunCvLECz4wXnV IpnCdwv6M0CEZSua8VmLm1IwkXCq2ZfIpDbSNj+67KUc5qDHzlyerfrRCxZ4kH+RJMELtucNY KKRzbsqx6UwM46AD8AkIZ9p94A5YFNTGkoaBZH0hq4+VmQcWB6nwAEDv4jboixaeWNuyRk6G+ BLYyDMviN9PKjtLm4Vggjq464BdV9zc7Dpveno8HJZKDy1PyfGobEj5BlTPbqjXtbux1AHdfs 6KstbnT4uInM4YOGxMn5azHOHOSlRzAKOrY6FAWYu2FhyXgT8oZxUEnrmau/2CitrwDItN6Td IzgeV9Y4Z7jjVJAUawZXtayT6nmLizOMl5Nmj+5ZQt3hJz/Rl1/UuymLcIMOpfnqgsh1zLu0i GAcY9m6np8a/xa0pTz0qXGF59QizBzfDVz4Ege90Ou/SqSE6SdyKtwf73D5CfpdYs97n4pKm4 92mCleq7DKuDv0AR6Wqf+r4B3GUzSdXOc+lmhd2sl1hNFnZFn7wRTg9/ybuXT412RBEnliFaQ XsSec5hTVnpw5Np/dvbC4oxAX2kTYe/5/tDDcEb430CN2xDaLSOr4Fn5obwX8hxVpM3c/1ZAF DhB/Hbh8jctnj5NTbHz3n9c1knYUXc1KNoIGKhQEloUKzNXJH5r4g9n0NBGLGUzRlOP9/Y3c X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153059 Archived-At: This is a multi-part message in MIME format. --------------050904000003060502000002 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit > If dired buffer reverted from outside it, cursor jumps to begin of the > buffer once this buffer becomes current again. > > How to reproduce: > > 0. emacs -Q > > 1. Open some directory, say "DIR-A" in dired. > > 2. Move cursor to subdirectory, say "DIR-B", M-: (point) ;=> e.g. 225. > > 3. Dive into subdirectory "DIR-B". > > 4. Let's check position: M-: (with-current-buffer "DIR-A" (point)) ;=> 225, so cursor in the right place. > > 5. Revert original buffer: M-: (with-current-buffer "DIR-A" (dired-revert)) > > 6. Check position again: M-: (with-current-buffer "DIR-A" (point)) ;=> 225, seems right here... > > 7. Switch back from the buffer with "DIR-B" to the buffer with "DIR-A". > > 8. Position lost! M-: (point) ;=> 1, but 225 expected. > > The issue very spunky if auto-revert-mode is used. > > Can't reproduce this issue with regular buffer, so it seems dired-specific. The attached patch should fix this problem and the other ones with 'dired' that have been cited in this context. Please try it. Thanks, martin --------------050904000003060502000002 Content-Type: text/plain; charset=windows-1252; name="dired.diffs" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="dired.diffs" ZGlmZiAtLWdpdCBhL2xpc3AvZGlyZWQuZWwgYi9saXNwL2RpcmVkLmVsCmluZGV4IGNiZDg1 ZmUuLmU1ZGM4NjIgMTAwNjQ0Ci0tLSBhL2xpc3AvZGlyZWQuZWwKKysrIGIvbGlzcC9kaXJl ZC5lbApAQCAtMTQ3OCwxMiArMTQ3OCwzNiBAQCBkaXJlZC1zYXZlLXBvc2l0aW9ucwogICAg ICAgICAgICAgICAgKGxpc3QgdwogCQkgICAgIChkaXJlZC1nZXQtZmlsZW5hbWUgbmlsIHQp CiAgICAgICAgICAgICAgICAgICAgICAobGluZS1udW1iZXItYXQtcG9zICh3aW5kb3ctcG9p bnQgdykpKSkpCi0JICAgKGdldC1idWZmZXItd2luZG93LWxpc3QgbmlsIDAgdCkpKSkKKwkg ICAoZ2V0LWJ1ZmZlci13aW5kb3ctbGlzdCBuaWwgMCB0KSkKKyAgIDs7IEZvciBlYWNoIHdp bmRvdyB0aGF0IHNob3dlZCB0aGUgY3VycmVudCBidWZmZXIgYmVmb3JlLCBzY2FuIGl0cwor ICAgOzsgbGlzdCBvZiBwcmV2aW91cyBidWZmZXJzLiAgRm9yIGVhY2ggYXNzb2NpYXRpb24g dGh1cyBmb3VuZCBzYXZlCisgICA7OyBhIHRyaXBsZSA8cG9pbnQsIG5hbWUsIGxpbmU+IHdo ZXJlICdwb2ludCcgaXMgdGhhdCB3aW5kb3cncworICAgOzsgd2luZG93LXBvaW50IG1hcmtl ciBzdG9yZWQgaW4gdGhlIHdpbmRvdydzIGxpc3Qgb2YgcHJldmlvdXMKKyAgIDs7IGJ1ZmZl cnMsICduYW1lJyBpcyB0aGUgZmlsZW5hbWUgYXQgdGhlIHBvc2l0aW9uIG9mICdwb2ludCcg YW5kCisgICA7OyAnbGluZScgaXMgdGhlIGxpbmUgbnVtYmVyIGF0IHRoZSBwb3NpdGlvbiBv ZiAncG9pbnQnLgorICAgKGxldCAoKGJ1ZmZlciAoY3VycmVudC1idWZmZXIpKQorICAgICAg ICAgcHJldnMpCisgICAgICh3YWxrLXdpbmRvd3MKKyAgICAgIChsYW1iZGEgKHdpbmRvdykK KyAgICAgICAgKGxldCAoKHByZXYgKGFzc3EgYnVmZmVyICh3aW5kb3ctcHJldi1idWZmZXJz IHdpbmRvdykpKSkKKyAgICAgICAgICAod2hlbiBwcmV2CisgICAgICAgICAgICAod2l0aC1j dXJyZW50LWJ1ZmZlciBidWZmZXIKKyAgICAgICAgICAgICAgKHNhdmUtZXhjdXJzaW9uCisg ICAgICAgICAgICAgICAgKGdvdG8tY2hhciAobnRoIDIgcHJldikpCisgICAgICAgICAgICAg ICAgKHNldHEgcHJldnMKKyAgICAgICAgICAgICAgICAgICAgICAoY29ucworICAgICAgICAg ICAgICAgICAgICAgICAobGlzdCAobnRoIDIgcHJldikKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKGRpcmVkLWdldC1maWxlbmFtZSBuaWwgdCkKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGxpbmUtbnVtYmVyLWF0LXBvcyAocG9pbnQpKSkKKyAgICAgICAgICAg ICAgICAgICAgICAgcHJldnMpKSkpKSkpCisgICAgICAnbm9taW5pIHQpCisgICAgIHByZXZz KSkpCiAKIChkZWZ1biBkaXJlZC1yZXN0b3JlLXBvc2l0aW9ucyAocG9zaXRpb25zKQogICAi UmVzdG9yZSBQT1NJVElPTlMgc2F2ZWQgd2l0aCBgZGlyZWQtc2F2ZS1wb3NpdGlvbnMnLiIK ICAgKGxldCogKChidWYtZmlsZS1wb3MgKG50aCAwIHBvc2l0aW9ucykpCi0JIChidWZmZXIg KG50aCAwIGJ1Zi1maWxlLXBvcykpKQorCSAoYnVmZmVyIChudGggMCBidWYtZmlsZS1wb3Mp KQorICAgICAgICAgKHByZXZzIChudGggMiBwb3NpdGlvbnMpKSkKICAgICAodW5sZXNzIChh bmQgKG50aCAxIGJ1Zi1maWxlLXBvcykKIAkJIChkaXJlZC1nb3RvLWZpbGUgKG50aCAxIGJ1 Zi1maWxlLXBvcykpKQogICAgICAgKGdvdG8tY2hhciAocG9pbnQtbWluKSkKQEAgLTE0OTcs NyArMTUyMSwyMSBAQCBkaXJlZC1yZXN0b3JlLXBvc2l0aW9ucwogCQkgICAgICAgKGRpcmVk LWdvdG8tZmlsZSAobnRoIDEgd2luLWZpbGUtcG9zKSkpCiAgICAgICAgICAgICAoZ290by1j aGFyIChwb2ludC1taW4pKQogCSAgICAoZm9yd2FyZC1saW5lICgxLSAobnRoIDIgd2luLWZp bGUtcG9zKSkpCi0JICAgIChkaXJlZC1tb3ZlLXRvLWZpbGVuYW1lKSkpKSkpKQorCSAgICAo ZGlyZWQtbW92ZS10by1maWxlbmFtZSkpKSkpCisgICAgKHdoZW4gcHJldnMKKyAgICAgICh3 aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZmZlcgorICAgICAgICAoc2F2ZS1leGN1cnNpb24KKyAg ICAgICAgICAoZG9saXN0IChwcmV2IHByZXZzKQorICAgICAgICAgICAgKGxldCAoKHBvaW50 IChudGggMCBwcmV2KSkpCisgICAgICAgICAgICAgIDs7IFNhbml0eSBjaGVjayBvZiB0aGUg cG9pbnQgbWFya2VyLgorICAgICAgICAgICAgICAod2hlbiAoYW5kIChtYXJrZXJwIHBvaW50 KQorICAgICAgICAgICAgICAgICAgICAgICAgIChlcSAobWFya2VyLWJ1ZmZlciBwb2ludCkg YnVmZmVyKSkKKyAgICAgICAgICAgICAgICAodW5sZXNzIChhbmQgKG50aCAwIHByZXYpCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChkaXJlZC1nb3RvLWZpbGUgKG50aCAxIHBy ZXYpKSkKKyAgICAgICAgICAgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisJICAg ICAgICAgIChmb3J3YXJkLWxpbmUgKDEtIChudGggMiBwcmV2KSkpKQorCSAgICAgICAgKGRp cmVkLW1vdmUtdG8tZmlsZW5hbWUpCisgICAgICAgICAgICAgICAgKG1vdmUtbWFya2VyIHBv aW50IChwb2ludCkgYnVmZmVyKSkpKSkpKSkpCiAKIChkZWZ1biBkaXJlZC1yZW1lbWJlci1t YXJrcyAoYmVnIGVuZCkKICAgIlJldHVybiBhbGlzdCBvZiBmaWxlcyBhbmQgdGhlaXIgbWFy a3MsIGZyb20gQkVHIHRvIEVORC4iCg== --------------050904000003060502000002--