all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: 14130@debbugs.gnu.org
Subject: bug#14130: 24.3.50; doc/help for advice and advised functions
Date: Wed, 3 Apr 2013 08:13:57 -0700	[thread overview]
Message-ID: <5BF8E36FD3EF4D1BBE8A1E79A0DCC421@us.oracle.com> (raw)

Mostly an enhancement request, I guess, but partly a bug report.
 
1. (elisp) `Advising Functions'
 
Says "Note that enabling a piece of advice and activating advice for a
function are not the same thing."  But it does not say clearly what the
difference is.  It says only this:
 
a. A piece of advice can be "enabled"/"disabled".  It does not explain
what this means.
 
b. Advice takes effect only if both enabled and activated.
 
That's pretty incomplete.  The difference between these two things
(enabling, activating) is presumably important, and it is not made
clear.  It is not enough to tell users not to confuse the two, without
telling them clearly what the difference is.  Start with this question:
What is the purpose of each of them (enabling, activating)?
 
2. The definition of "forward advice", and the *important* fact that you
can advise a function without the function being defined yet, should be
moved from (elisp) `Defining Advice' to (elisp) `Advising Functions'.
It is not a detail concerning just the keyword `activate'.  (Note too
that there is zero use of or reference to "forward advice" in the
manual.)
 
3. If these concepts apply also to the new advice facility written by
Stefan, then please keep this request in mind in that context: document
each of the various states of a piece of advice (enabled but not
activated etc.) etc.  (And where is the doc for that new facility?)
 
 
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-03-28 on ODIEONE
Bzr revision: 112173 monnier@iro.umontreal.ca-20130328163306-419khox8aneaoaxv
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 






             reply	other threads:[~2013-04-03 15:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-03 15:13 Drew Adams [this message]
2021-09-25 17:15 ` bug#14130: 24.3.50; doc/help for advice and advised functions Stefan Kangas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BF8E36FD3EF4D1BBE8A1E79A0DCC421@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=14130@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.