all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Gary Fredericks <fredericksgary@gmail.com>
Cc: 32720@debbugs.gnu.org
Subject: bug#32720: term-mode ignores certain window size changes
Date: Fri, 16 Nov 2018 13:57:51 +0100	[thread overview]
Message-ID: <5BEEBECF.5060601@gmx.at> (raw)
In-Reply-To: <CAMMdeLgsdkSshCc-8NxmYCycqTh=Bj1qp_g+F++jO87z3rRoNw@mail.gmail.com>

 > Yep, it seems to work with the patch applied.

Thanks for the feedback.  But after more carefully looking into the
'window-adjust-process-windows' code I am now almost convinced that
your original proposal is the way to go.  That is, I nowhere found in
that code anything that depends on the change of the window
configuration.  The only thing that code is interested in is tracing
window size changes which 'window-configuration-change-hook' does not
handle particularly well.

So if you already have run Emacs for some time with your

(add-hook
  'window-size-change-functions
  (lambda (_frame) (window--adjust-process-windows)))

and did not see any adversary effects I am inclined to install that
for Emacs 26.2.  For Emacs 27 I would then (after the release of Emacs
26.2) remove the

(add-hook 'window-configuration-change-hook 'window--adjust-process-windows)

call.

Eli would that be OK with you as well?  I'd still have to amend the
doc of 'window-configuration-change-hook' but the net change would be
considerably smaller than the one I proposed in the other thread.

martin





  reply	other threads:[~2018-11-16 12:57 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-12 12:09 bug#32720: term-mode ignores certain window size changes Gary Fredericks
2018-09-13  8:07 ` martin rudalics
2018-09-13 14:06   ` Eli Zaretskii
2018-09-14  8:32     ` martin rudalics
2018-11-04  9:56 ` martin rudalics
2018-11-16 12:15   ` Gary Fredericks
2018-11-16 12:57     ` martin rudalics [this message]
2018-11-16 13:15       ` Gary Fredericks
2018-11-18  9:22         ` martin rudalics
2018-11-16 14:45       ` Eli Zaretskii
2018-11-17  9:20         ` martin rudalics
2018-11-17  9:43           ` Eli Zaretskii
2018-11-17 18:40             ` martin rudalics
2018-11-18  3:30               ` Eli Zaretskii
2018-11-18  9:22                 ` martin rudalics
2018-11-18 15:21                   ` Eli Zaretskii
2018-11-18 19:37                     ` martin rudalics
2018-11-18 20:10                       ` Eli Zaretskii
2018-11-19  9:41                         ` martin rudalics
2018-11-19 15:04                           ` Gary Fredericks
2018-11-19 15:14                             ` martin rudalics
2018-12-22 22:53                               ` Gary Fredericks
2018-12-23  9:38                                 ` martin rudalics
2018-12-23 13:16                                   ` Gary Fredericks
2018-12-23 13:40                                     ` martin rudalics
2018-12-23 13:47                                       ` Gary Fredericks
2018-12-23 18:02                                         ` martin rudalics
2018-12-23 18:54                                           ` Gary Fredericks
2018-12-25  9:51                                             ` martin rudalics
2018-12-29 23:23                                               ` Gary Fredericks
2018-12-30  9:53                                                 ` martin rudalics
2018-12-31 12:45                                                   ` Gary Fredericks
2018-12-31 14:16                                                     ` martin rudalics
2019-01-01 15:37                                                       ` Gary Fredericks
2019-01-01 17:25                                                         ` martin rudalics
2019-01-01 17:31                                                           ` Gary Fredericks
2019-01-01 17:55                                                             ` martin rudalics
2019-01-06 22:51                                                               ` Gary Fredericks
2019-01-07 12:29                                                                 ` Gary Fredericks
2019-01-07 16:11                                                                   ` martin rudalics
2019-01-11  9:24                                                                   ` martin rudalics
2019-01-16 14:07                                                                     ` Gary Fredericks
2019-01-16 17:30                                                                       ` martin rudalics
2019-01-16 17:44                                                                         ` Gary Fredericks
2020-08-22 14:59                                                                           ` Lars Ingebrigtsen
2020-08-22 16:57                                                                             ` Gary Fredericks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5BEEBECF.5060601@gmx.at \
    --to=rudalics@gmx.at \
    --cc=32720@debbugs.gnu.org \
    --cc=fredericksgary@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.