From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33230: 26.1; Soft-wrap issue in term.el with term-suppress-hard-newline Date: Wed, 14 Nov 2018 09:32:57 +0100 Message-ID: <5BEBDDB9.20401@gmx.at> References: <87h8h0if4u.fsf@gmail.com> <87bm76j496.fsf@gmail.com> <5BDEB6CD.2050407@gmx.at> <5BDEC244.3040002@gmx.at> <5BEA9469.7080502@gmx.at> <83muqc99rf.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1542184346 9061 195.159.176.226 (14 Nov 2018 08:32:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Nov 2018 08:32:26 +0000 (UTC) Cc: 33230@debbugs.gnu.org, bruno@charron.email, npostavs@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 14 09:32:22 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMqau-00026p-Ag for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 09:32:16 +0100 Original-Received: from localhost ([::1]:58893 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMqd0-0001pI-LN for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Nov 2018 03:34:26 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gMqci-0001ln-97 for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 03:34:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gMqcd-0000eI-8l for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 03:34:08 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gMqcd-0000eB-5I for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 03:34:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gMqcd-00013m-1g for bug-gnu-emacs@gnu.org; Wed, 14 Nov 2018 03:34:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Nov 2018 08:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 33230-submit@debbugs.gnu.org id=B33230.15421844063991 (code B ref 33230); Wed, 14 Nov 2018 08:34:02 +0000 Original-Received: (at 33230) by debbugs.gnu.org; 14 Nov 2018 08:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:50917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMqc1-00012I-LC for submit@debbugs.gnu.org; Wed, 14 Nov 2018 03:33:25 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:41799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gMqbv-00011y-Ah for 33230@debbugs.gnu.org; Wed, 14 Nov 2018 03:33:20 -0500 Original-Received: from [192.168.1.101] ([212.95.5.83]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUZKF-1fvah131Up-00RG4l; Wed, 14 Nov 2018 09:33:04 +0100 In-Reply-To: <83muqc99rf.fsf@gnu.org> X-Provags-ID: V03:K1:I1ka981aLZv49Sz3+fpe1fGw+7KzCavH+rHfSdb1ehDakf5gYYo b6PPRbZ8ACH+0zsWg+RRhofiJwFRmi4vFPT9NsVQot/h6Qai6vAnJDL5OjMbiKRPE+NI2c/ +XUq7qnpUtzeJqXscsRf+17kGxWKFKOs7b43SNiI/fFlFV3pLneAIZL9uJR23ijke/e4QSS IbaE1L7XgTNAF0hilEoyg== X-UI-Out-Filterresults: notjunk:1;V01:K0:nM46f8bVk0o=:v/rknfHF1u6bnu8Gr5EAJd UXUaJJNVrkMsOiE9mGid7iQMUDzFFT/KNeKHzS7elOG2w+0a+LiGBgJy5xwCmnKJw/bK8NZIm 6rybDzhV1ePChCBIgr7On3jJROltr76AUFsBxOGQ3eZuCErUoreuNMnrPXfRxTyjrQ/+zLiq4 wT1COnV4XnVYUVbdRCOACPMzaBja4DoU7NCLsAcpiGaEc3Cvk9YPcSWgu/xvSYMa3tg/RU8jc AcXC9ndlNMCNSbWpp+Xf/2uwrgy/sfUXZKrDoSU8Xnnjnoa/uEGrVF7tEQfRW4V4Eg1gTUIOp dWcvLI+phVy+/bxsByZuwISi+dWqnWFMm+Rd+UqGnhlQjNVqyfs7oaBEvV9PifkF5AjAIqyck 8Tx2a93C7C2UPRqQ7xwU71C/9K7/1BNYcaT3hUYMwSpqyiMIsczDimPlASrF4w0ggCZee/8yr QX9CM4dPcq2d4MVKCp5kwWeCdzYjzTCX12014ygN4cFOyOXllwPFW9hGHjgKex+CDhsNa2BVv pnejU9vA2gj5q6XrnZx7F8kSIbEkutb2QocaePUuYBb+Nj/yMKlHFv5wVDU50+HkJKGFpN3qQ 5Uar9ox1jyjRf7BL8hNtrZ5zwg1/LimOtwGKYBDwa01ROH3UqfYXQOx6KGrX2ZNCqCJNhZZdb mP7KBykkBq175+FtAWbrHBFTHxDBwY0BKBLR9IcqFjhiK8zcB0uHm/sgTFwNDUtmNxEGaICby ZTFJUjH4rTopvamfA0chhMEd51eKpiT9b++ic7kAkPeS+9MczNGgejPkfmbSV32zc5E1LNIo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152374 Archived-At: >> FWIW this is Bug#32720 for which I am responsible. It will be fixed >> in Emacs 26.2 by reestablishing the behavior of Emacs 25. > > And your proposed change runs window-configuration-change-hook in two > additional places. Right. > My confusion about this is twofold: (1) the original report for this > bug doesn't seem to involve any resizing of a frame, At the end it says: Another issue I found that may need to be addressed to get a behavior similar to gnome-terminal above is that the shell is not aware (checking $COLUMS) of when the frame is resized, only when its window is resized and there is another window on the side. > and (2) the ELisp > manual explicitly says that "resizing the frame or individual windows > do not count as configuration changes", and thus this hook shouldn't > be run when the frame is resized. > > So how does the proposed change fix the problem at hand, By running 'window-configuration-change-hook' for frame resizes as with Emacs 25. > and why do > you want to do exactly what the ELisp manual says we don't? The Elisp manual doesn't represent the facts because we still run the hook when resizing single windows. The idea behind that text was to avoid that new code runs 'window-configuration-change-hook' to trace window size changes because that is unreliable (not all size changes are caught) and costly (it's often run when no sizes changed at all). Also NEWS warned that *** Resizing a frame no longer runs 'window-configuration-change-hook'. 'window-size-change-functions' should be used instead. and I checked known clients of 'window-configuration-change-hook' whether they should call 'window-size-change-functions' instead. Little did I expect to find such a client in window.el though, so this went unnoticed. We could add a call to 'window-size-change-functions' as Gary proposed in the report of Bug#32720. But then 'window--adjust-process-windows' would be run by both 'window-configuration-change-hook' and 'window-size-change-functions' effectively increasing the number of calls of that function instead of decreasing it. If you prefer that solution we can certainly do it. martin