From: martin rudalics <rudalics@gmx.at>
To: Michael Heerdegen <michael_heerdegen@web.de>
Cc: 32825@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#32825: 27.0.50; Deterministic window management
Date: Fri, 09 Nov 2018 13:51:32 +0100 [thread overview]
Message-ID: <5BE582D4.8010201@gmx.at> (raw)
In-Reply-To: <874lcqmu6u.fsf@web.de>
[-- Attachment #1: Type: text/plain, Size: 747 bytes --]
> There are only two places where debugger-previous-window is set - both
> in `debug': in the first, the value is set when the debugger pops up, to
> the window that has been chosen to display it. In the second place,
> it's reset to nil when the debugger "won't be back".
>
> So, when the value is a (live) window, it should be respected. I didn't
> follow your discussion very attentively, but I'm not sure how the
> debugger-previous-window variable is concerned in what you discussed
> recently. AFAIK its only use is to remember the window while a debugger
> session is still active.
You're right - FWIW this is the same bug I proposed to fix earlier
with the patch I reattach now. Juri, you never tried it, I suppose?
martin
[-- Attachment #2: debug.diff --]
[-- Type: text/plain, Size: 2177 bytes --]
--- a/lisp/emacs-lisp/debug.el
+++ b/lisp/emacs-lisp/debug.el
@@ -101,7 +101,10 @@ debugger-old-buffer
"This is the buffer that was current when the debugger was entered.")
(defvar debugger-previous-window nil
- "This is the window last showing the debugger buffer.")
+ "The last debugger window from the same session.")
+
+(defvar debugger-pre-previous-window nil
+ "The last debugger window from the previous session.")
(defvar debugger-previous-window-height nil
"The last recorded height of `debugger-previous-window'.")
@@ -240,10 +243,16 @@ debug
debugger-buffer
`((display-buffer-reuse-window
display-buffer-in-previous-window)
- . (,(when (and (window-live-p debugger-previous-window)
- (frame-visible-p
- (window-frame debugger-previous-window)))
- `(previous-window . ,debugger-previous-window)))))
+ . (,(cond
+ ((and (window-live-p debugger-previous-window)
+ (frame-visible-p
+ (window-frame debugger-previous-window)))
+ `(previous-window . ,debugger-previous-window))
+ ((and (window-live-p debugger-pre-previous-window)
+ (eq (window-frame debugger-pre-previous-window)
+ (selected-frame)))
+ `(previous-window . ,debugger-pre-previous-window)))
+ (inhibit-same-window . t))))
(setq debugger-window (selected-window))
(if (eq debugger-previous-window debugger-window)
(when debugger-jumping-flag
@@ -297,7 +306,9 @@ debug
(quit-restore-window debugger-window debugger-bury-or-kill)
;; Restore current buffer (Bug#12502).
(set-buffer debugger-old-buffer)))
- ;; Forget debugger window, it won't be back (Bug#17882).
+ ;; Forget debugger window, it won't be back (Bug#17882)
+ ;; unless it's on the selected frame (Bug#32825).
+ (setq debugger-pre-previous-window debugger-previous-window)
(setq debugger-previous-window nil))
;; Restore previous state of debugger-buffer in case we were
;; in a recursive invocation of the debugger, otherwise just
next prev parent reply other threads:[~2018-11-09 12:51 UTC|newest]
Thread overview: 135+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-24 18:59 bug#32825: 27.0.50; Deterministic window management Juri Linkov
2018-09-25 7:28 ` martin rudalics
2018-09-25 12:34 ` Michael Heerdegen
2018-09-25 17:56 ` martin rudalics
2018-09-25 18:29 ` Michael Heerdegen
2018-09-26 8:50 ` martin rudalics
2018-09-26 23:23 ` Juri Linkov
2018-09-27 18:45 ` martin rudalics
2018-09-26 23:19 ` Juri Linkov
2018-09-27 11:31 ` Michael Heerdegen
2018-10-25 19:33 ` Juri Linkov
2018-10-25 20:00 ` Michael Heerdegen
2018-10-27 20:14 ` Juri Linkov
2018-10-27 20:28 ` Michael Heerdegen
2018-10-27 20:59 ` Juri Linkov
2018-10-27 21:21 ` Michael Heerdegen
2018-10-27 21:34 ` Juri Linkov
2018-10-27 22:02 ` Michael Heerdegen
2018-10-28 9:06 ` martin rudalics
2018-10-28 19:02 ` Juri Linkov
2018-10-29 8:43 ` martin rudalics
2018-10-29 22:47 ` Juri Linkov
2018-10-30 21:18 ` Juri Linkov
2018-10-31 8:10 ` martin rudalics
2018-10-31 21:10 ` Juri Linkov
2018-11-01 9:01 ` martin rudalics
2018-11-01 22:27 ` Juri Linkov
2018-11-02 8:43 ` martin rudalics
2018-11-04 0:27 ` Juri Linkov
2018-11-04 9:07 ` martin rudalics
2018-11-04 21:33 ` Juri Linkov
2018-11-05 9:34 ` martin rudalics
2018-11-05 21:49 ` Juri Linkov
2018-11-06 8:46 ` martin rudalics
2018-11-06 22:13 ` Juri Linkov
2018-11-07 9:23 ` martin rudalics
2018-11-07 21:50 ` Juri Linkov
2018-11-08 8:53 ` martin rudalics
2018-11-08 21:58 ` Juri Linkov
2018-11-09 9:13 ` martin rudalics
2018-11-09 10:17 ` Michael Heerdegen
2018-11-09 12:51 ` martin rudalics [this message]
2018-11-10 21:53 ` Juri Linkov
2018-11-11 8:53 ` martin rudalics
2018-11-11 20:13 ` Juri Linkov
2018-11-12 8:45 ` martin rudalics
2018-11-12 23:39 ` Juri Linkov
2018-11-13 0:29 ` Juri Linkov
2018-11-13 9:12 ` martin rudalics
2018-11-13 23:29 ` Juri Linkov
2018-11-14 8:33 ` martin rudalics
2018-11-14 23:52 ` Juri Linkov
2018-11-15 9:12 ` martin rudalics
2018-11-15 21:43 ` Juri Linkov
2018-11-16 8:53 ` martin rudalics
2018-11-16 12:57 ` martin rudalics
2018-11-17 22:23 ` Juri Linkov
2018-11-18 9:24 ` martin rudalics
2018-11-18 23:01 ` Juri Linkov
2018-11-19 9:43 ` martin rudalics
[not found] ` <87h8gcy95d.fsf@mail.linkov.net>
2018-11-20 9:32 ` martin rudalics
2018-11-21 0:16 ` Juri Linkov
2018-11-21 8:19 ` martin rudalics
2018-11-21 23:54 ` Juri Linkov
2018-11-22 7:41 ` martin rudalics
2018-11-13 9:09 ` martin rudalics
2018-11-04 9:36 ` martin rudalics
2018-11-04 21:35 ` Juri Linkov
2018-11-05 9:34 ` martin rudalics
2018-11-05 21:56 ` Juri Linkov
2018-11-06 8:46 ` martin rudalics
2018-11-06 22:08 ` Juri Linkov
2018-11-07 9:23 ` martin rudalics
2018-11-07 21:55 ` Juri Linkov
2018-11-08 8:53 ` martin rudalics
2018-11-08 22:09 ` Juri Linkov
2018-11-09 9:13 ` martin rudalics
2018-11-10 21:39 ` Juri Linkov
2018-11-11 8:52 ` martin rudalics
2018-11-11 20:09 ` Juri Linkov
2018-11-12 8:36 ` martin rudalics
2018-11-12 23:40 ` Juri Linkov
2018-11-13 9:09 ` martin rudalics
2018-11-13 23:44 ` Juri Linkov
2018-11-14 8:33 ` martin rudalics
2018-12-03 23:07 ` Juri Linkov
2018-12-04 8:32 ` martin rudalics
2018-12-04 22:24 ` Juri Linkov
2018-12-05 9:15 ` martin rudalics
2018-12-05 18:55 ` martin rudalics
2018-12-06 0:04 ` Juri Linkov
2018-12-06 9:09 ` martin rudalics
2018-12-06 23:31 ` Juri Linkov
2018-12-08 9:41 ` martin rudalics
2018-12-08 9:41 ` martin rudalics
2018-12-08 23:40 ` Juri Linkov
2018-12-09 8:25 ` martin rudalics
2018-12-10 0:17 ` Juri Linkov
2018-12-10 1:01 ` Michael Heerdegen
2018-12-11 0:07 ` Juri Linkov
2018-12-11 1:08 ` Michael Heerdegen
2018-12-11 8:34 ` martin rudalics
2018-12-20 23:57 ` Juri Linkov
2018-12-21 9:15 ` martin rudalics
2018-12-22 23:45 ` Juri Linkov
2018-12-23 9:41 ` martin rudalics
2018-12-23 23:32 ` Juri Linkov
2018-12-24 8:14 ` martin rudalics
2018-12-25 21:16 ` Juri Linkov
2018-12-26 9:41 ` martin rudalics
2018-12-27 0:10 ` Juri Linkov
2018-12-27 9:37 ` martin rudalics
2018-09-27 18:44 ` martin rudalics
2018-09-27 22:47 ` Juri Linkov
2018-09-30 8:00 ` martin rudalics
2018-09-30 11:40 ` Michael Heerdegen
2018-09-30 12:22 ` martin rudalics
2018-09-30 12:32 ` Noam Postavsky
2018-09-30 12:43 ` martin rudalics
2018-09-30 13:04 ` Noam Postavsky
2018-09-30 13:38 ` Michael Heerdegen
2018-09-30 21:26 ` Noam Postavsky
2018-09-30 23:33 ` Michael Heerdegen
2018-10-01 8:36 ` martin rudalics
2018-10-01 13:18 ` Michael Heerdegen
2018-10-01 15:07 ` martin rudalics
2018-10-01 18:10 ` Michael Heerdegen
2018-10-02 7:38 ` martin rudalics
2018-10-02 13:24 ` Michael Heerdegen
2018-10-01 13:05 ` Michael Heerdegen
2018-10-01 13:14 ` Noam Postavsky
2018-10-01 15:06 ` martin rudalics
2022-04-30 14:52 ` Lars Ingebrigtsen
2022-04-30 14:54 ` Lars Ingebrigtsen
2022-05-01 17:00 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BE582D4.8010201@gmx.at \
--to=rudalics@gmx.at \
--cc=32825@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=michael_heerdegen@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.