From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#33258: inhibit-select-window Date: Thu, 08 Nov 2018 09:52:32 +0100 Message-ID: <5BE3F950.1040103@gmx.at> References: <87muqpj8ib.fsf@mail.linkov.net> <5BE00E99.1020003@gmx.at> <87bm731abq.fsf@mail.linkov.net> <5BE154BC.4080707@gmx.at> <878t25vpd7.fsf@mail.linkov.net> <5BE2AEDE.1090109@gmx.at> <871s7wzips.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1541667076 12370 195.159.176.226 (8 Nov 2018 08:51:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 8 Nov 2018 08:51:16 +0000 (UTC) Cc: 33258@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 08 09:51:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg1u-00034P-Ua for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 09:51:11 +0100 Original-Received: from localhost ([::1]:55043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKg41-0001pe-Af for geb-bug-gnu-emacs@m.gmane.org; Thu, 08 Nov 2018 03:53:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gKg3l-0001nn-VT for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:53:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gKg3i-0001lj-Pt for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:53:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35991) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gKg3i-0001l8-KT for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gKg3i-0000JV-HL for bug-gnu-emacs@gnu.org; Thu, 08 Nov 2018 03:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Nov 2018 08:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33258 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33258-submit@debbugs.gnu.org id=B33258.15416671701184 (code B ref 33258); Thu, 08 Nov 2018 08:53:02 +0000 Original-Received: (at 33258) by debbugs.gnu.org; 8 Nov 2018 08:52:50 +0000 Original-Received: from localhost ([127.0.0.1]:40249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg3V-0000J2-LI for submit@debbugs.gnu.org; Thu, 08 Nov 2018 03:52:49 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:53599) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gKg3U-0000Ik-D8 for 33258@debbugs.gnu.org; Thu, 08 Nov 2018 03:52:48 -0500 Original-Received: from [192.168.1.101] ([212.95.5.129]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MA9FV-1gDl6t0PeL-00BLyQ; Thu, 08 Nov 2018 09:52:38 +0100 In-Reply-To: <871s7wzips.fsf@mail.linkov.net> X-Provags-ID: V03:K1:3KVp7Wzn3yot5DF2eJxIrw4qqd2NAezoTNlDqFaWEPMU8XJk2/Q rorbQ4RTZR1293fP95LkYolNbiZUeUnuGQTldg448Bm34m0GHBAWE8YHWGbKsQdpc4khmSu 3GuKVY/8Lr2eTeoyReeAcmR9PfUuNnzItkgA0iHK8eDNRCaP+/JUPr8CZxMjw0d75Ga9LrY OCTtW3Lj5O468MWuTU9CA== X-UI-Out-Filterresults: notjunk:1;V01:K0:tD0Uaa1s4Is=:RhAit/NjlJLCk5dT6Wvpgj jC6yYGrOU0gOkwtGnfG1cpRTlsa9tZZW3fjGZfvPoJ5FA7vL0bdjze2YSYgb82PiIiDWylsx2 qw5fglISydCt8CdRmXfnZ2Z12g8jz35cttqFPN5C+zpv2mCPXnZwOlsLXXTxZiBU49cxHO7TW bQpnx0KBmCOpudiWkJRZni/JpWl3ecDzvQbqmdmV2O84QXUOL9s4dqQ2qPaPjP+djuErIMBky MzClPtha/c6XPLPfcUEHu1yIwbG4bJLq/ShCeldgOUlQyVNBRXkPCdPF2T7LvHMH9EASV6E8R XVWAuk1bUetvJfInRvEomJgS4G3S/Gcx1mPxcqK73+so0bgwPg2Dwhe4DWPPTc9aAk4jd2vOU DKMl8pV/1VExjP75dQLfLcM3humWszE70jPx7qkTDIMerrlAOLLGlrAFuWaJlibUSgSnFBSQb fuz5eg9uuNH1bv1toOXbwsg+kNFqQHatI0M24cKrEIuqXmRVJ7tT7T2MN2IyfwdR5qgtJgHuL 6AiU+9xMiNLBs8DmMECUiFNd2cWMqW8f2XuEVQQ0/FXlLEmVeXe/6xqd3ypPOs3+btfMzReWC HqlvZFo2CD00W0vChURsdT4hbcPNBwz5a7DT++wz/i8GPSqQhpf9QCqNa+uvhBSZ3dCvK6nLA nQGiVWI+QAgKHUsqGer5wtJBxKmWFOMjvw8sD02XkDD7SNn01TWltZcKUPSTqwi5dCIjnIRqh k5sL15ymXNz7QuLCnLFS0IQ3YNefd/o+yuf2hbe0tJCllH+5XqprEiCN1364qa8TThqoAFDS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152148 Archived-At: > So to rule out non-interactive callers of vc-diff we need to check > for (eq this-command 'vc-diff)? For example. > But there is a simpler and safer solution that I already mentioned: > to restore an original window in post-command-hook. Or even better > using your new window-state-change-functions: when inhibit-select-window > was found in an alist from display-buffer-alist then check whether > the selected window was changed in an alist of changes provided by > window-state-change-functions and restore an old selected window. In either case let's get 'display-buffer' out of this. After all, its doc-string says "Display BUFFER-OR-NAME in some window, without selecting it." so we'd be preaching to the choir here. We might call it 'pop-to-buffer-no-select'. martin